From: Will Deacon <will@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Hildenbrand <david@redhat.com>,
Robin Murphy <robin.murphy@arm.com>,
Mike Rapoport <rppt@kernel.org>, Alex Bee <knaerzche@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases)
Date: Wed, 25 Aug 2021 11:32:23 +0100 [thread overview]
Message-ID: <20210825103223.GE24546@willie-the-truck> (raw)
In-Reply-To: <20210825102856.GD24546@willie-the-truck>
On Wed, Aug 25, 2021 at 11:28:56AM +0100, Will Deacon wrote:
> On Wed, Aug 25, 2021 at 11:20:46AM +0100, Catalin Marinas wrote:
> > Given how later we are in the -rc cycle, I suggest we revert Anshuman's
> > commit 16c9afc77660 ("arm64/mm: drop HAVE_ARCH_PFN_VALID") and try to
> > assess the implications in 5.15 (the patch doesn't seem to have the
> > arm64 maintainers' ack anyway ;)).
>
> I'll stick the revert (below) into kernelci now so we can get some coverage
> in case it breaks something else.
Bah, having said that...
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index fcb535560028..ee70f21a79d5 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1463,15 +1463,6 @@ static inline int pfn_valid(unsigned long pfn)
> {
> struct mem_section *ms;
>
> - /*
> - * Ensure the upper PAGE_SHIFT bits are clear in the
> - * pfn. Else it might lead to false positives when
> - * some of the upper bits are set, but the lower bits
> - * match a valid pfn.
> - */
> - if (PHYS_PFN(PFN_PHYS(pfn)) != pfn)
> - return 0;
> -
I suppose we should leave this bit as-is, since the whole point here is
trying to minimise the impact on other architectures.
Will
next prev parent reply other threads:[~2021-08-25 10:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 13:40 [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases) Alex Bee
2021-08-24 17:37 ` Catalin Marinas
2021-08-24 18:06 ` Robin Murphy
2021-08-24 18:28 ` Mike Rapoport
2021-08-24 18:46 ` Robin Murphy
2021-08-24 18:59 ` David Hildenbrand
2021-08-25 10:20 ` Catalin Marinas
2021-08-25 10:28 ` Will Deacon
2021-08-25 10:32 ` Will Deacon [this message]
2021-08-25 10:33 ` Robin Murphy
2021-08-25 10:38 ` David Hildenbrand
2021-08-25 10:54 ` Mike Rapoport
2021-08-25 10:55 ` Catalin Marinas
2021-08-25 11:12 ` David Hildenbrand
2021-08-25 17:15 ` Catalin Marinas
2021-08-25 10:58 ` Robin Murphy
2021-08-25 11:21 ` David Hildenbrand
2021-08-25 10:52 ` Mike Rapoport
2021-09-17 21:22 ` Mike Rapoport
2021-09-18 5:18 ` Christoph Hellwig
2021-09-18 8:37 ` Mike Rapoport
2021-09-18 11:39 ` Mike Rapoport
2021-09-20 10:57 ` Catalin Marinas
2021-09-21 8:20 ` Christoph Hellwig
2021-09-21 9:34 ` Mike Rapoport
2021-09-21 15:38 ` Christoph Hellwig
2021-09-22 7:22 ` Mike Rapoport
2021-09-20 11:13 ` David Hildenbrand
2021-08-24 20:14 ` Alex Bee
2021-08-25 4:39 ` Mike Rapoport
2021-08-25 10:00 ` Alex Bee
2021-08-24 20:07 ` Alex Bee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825103223.GE24546@willie-the-truck \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=knaerzche@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).