[linux-next:master 9487/10945] arch/um/drivers/vector_kern.c:1519:18: error: initialization of 'int (*)(struct net_device *, struct ethtool_coalesce *, struct kernel_ethtool_coalesce *, struct netlink_ext_ack *)' from incompatible pointer type 'int (*)(struct net_device *, struct ethto...

[linux-next:master 9487/10945] arch/um/drivers/vector_kern.c:1519:18: error: initialization of 'int (*)(struct net_device *, struct ethtool_coalesce *, struct kernel_ethtool_coalesce *, struct netlink_ext_ack *)' from incompatible pointer type 'int (*)(struct net_device *, struct ethto...

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4234 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   5e63226c72287bc6c6724d4fc7e157af0e3d7908
commit: f3ccfda1931977b80267ba54070a1aeafa18f6ca [9487/10945] ethtool: extend coalesce setting uAPI with CQE mode
config: um-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f3ccfda1931977b80267ba54070a1aeafa18f6ca
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout f3ccfda1931977b80267ba54070a1aeafa18f6ca
        # save the attached .config to linux build tree
        make W=1 ARCH=um 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/um/drivers/vector_kern.c: In function 'get_bpf_flash':
   arch/um/drivers/vector_kern.c:144:18: warning: ordered comparison of pointer with integer zero [-Wextra]
     144 |    return (allow > 0);
         |                  ^
   arch/um/drivers/vector_kern.c: In function 'vector_parse':
   arch/um/drivers/vector_kern.c:718:9: warning: variable 'len' set but not used [-Wunused-but-set-variable]
     718 |  int n, len, err;
         |         ^~~
   arch/um/drivers/vector_kern.c: At top level:
>> arch/um/drivers/vector_kern.c:1519:18: error: initialization of 'int (*)(struct net_device *, struct ethtool_coalesce *, struct kernel_ethtool_coalesce *, struct netlink_ext_ack *)' from incompatible pointer type 'int (*)(struct net_device *, struct ethtool_coalesce *)' [-Werror=incompatible-pointer-types]
    1519 |  .get_coalesce = vector_get_coalesce,
         |                  ^~~~~~~~~~~~~~~~~~~
   arch/um/drivers/vector_kern.c:1519:18: note: (near initialization for 'vector_net_ethtool_ops.get_coalesce')
   arch/um/drivers/vector_kern.c:1520:18: error: initialization of 'int (*)(struct net_device *, struct ethtool_coalesce *, struct kernel_ethtool_coalesce *, struct netlink_ext_ack *)' from incompatible pointer type 'int (*)(struct net_device *, struct ethtool_coalesce *)' [-Werror=incompatible-pointer-types]
    1520 |  .set_coalesce = vector_set_coalesce,
         |                  ^~~~~~~~~~~~~~~~~~~
   arch/um/drivers/vector_kern.c:1520:18: note: (near initialization for 'vector_net_ethtool_ops.set_coalesce')
   cc1: some warnings being treated as errors


vim +1519 arch/um/drivers/vector_kern.c

49da7e64f33e80 Anton Ivanov   2017-11-20  1509  
49da7e64f33e80 Anton Ivanov   2017-11-20  1510  static const struct ethtool_ops vector_net_ethtool_ops = {
cdc7aaca074d46 Jakub Kicinski 2020-03-05  1511  	.supported_coalesce_params = ETHTOOL_COALESCE_TX_USECS,
49da7e64f33e80 Anton Ivanov   2017-11-20  1512  	.get_drvinfo	= vector_net_get_drvinfo,
49da7e64f33e80 Anton Ivanov   2017-11-20  1513  	.get_link	= ethtool_op_get_link,
49da7e64f33e80 Anton Ivanov   2017-11-20  1514  	.get_ts_info	= ethtool_op_get_ts_info,
49da7e64f33e80 Anton Ivanov   2017-11-20  1515  	.get_ringparam	= vector_get_ringparam,
49da7e64f33e80 Anton Ivanov   2017-11-20  1516  	.get_strings	= vector_get_strings,
49da7e64f33e80 Anton Ivanov   2017-11-20  1517  	.get_sset_count	= vector_get_sset_count,
49da7e64f33e80 Anton Ivanov   2017-11-20  1518  	.get_ethtool_stats = vector_get_ethtool_stats,
49da7e64f33e80 Anton Ivanov   2017-11-20 @1519  	.get_coalesce	= vector_get_coalesce,
49da7e64f33e80 Anton Ivanov   2017-11-20  1520  	.set_coalesce	= vector_set_coalesce,
9807019a62dc67 Anton Ivanov   2019-10-02  1521  	.flash_device	= vector_net_load_bpf_flash,
49da7e64f33e80 Anton Ivanov   2017-11-20  1522  };
49da7e64f33e80 Anton Ivanov   2017-11-20  1523  
49da7e64f33e80 Anton Ivanov   2017-11-20  1524  

:::::: The code at line 1519 was first introduced by commit
:::::: 49da7e64f33e80edffb1a9eeb230fa4c3f42dffb High Performance UML Vector Network Driver

:::::: TO: Anton Ivanov <anton.ivanov@cambridgegreys.com>
:::::: CC: Richard Weinberger <richard@nod.at>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62708 bytes --]