linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: Make SLAB_MERGE_DEFAULT depend on SL[AU]B
@ 2021-12-25  6:09 Hyeonggon Yoo
  2022-01-05 18:06 ` Vlastimil Babka
  0 siblings, 1 reply; 2+ messages in thread
From: Hyeonggon Yoo @ 2021-12-25  6:09 UTC (permalink / raw)
  To: linux-mm; +Cc: akpm, vbabka, cl, rientjes, iamjoonsoo.kim, penberg, 42.hyeyoo

SLOB always manage objects of different caches in same page regardless of
SLAB_MERGE_DEFAULT. Because it has no effect on SLOB, make it depend on
SLAB || SLUB.

Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
---
 init/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/init/Kconfig b/init/Kconfig
index 4b7bac10c72d..03e1b863f5ce 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1933,6 +1933,7 @@ endchoice
 config SLAB_MERGE_DEFAULT
 	bool "Allow slab caches to be merged"
 	default y
+	depends on SLAB || SLUB
 	help
 	  For reduced kernel memory fragmentation, slab caches can be
 	  merged when they share the same size and other characteristics.
-- 
2.33.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: Make SLAB_MERGE_DEFAULT depend on SL[AU]B
  2021-12-25  6:09 [PATCH] mm: Make SLAB_MERGE_DEFAULT depend on SL[AU]B Hyeonggon Yoo
@ 2022-01-05 18:06 ` Vlastimil Babka
  0 siblings, 0 replies; 2+ messages in thread
From: Vlastimil Babka @ 2022-01-05 18:06 UTC (permalink / raw)
  To: Hyeonggon Yoo, linux-mm; +Cc: akpm, cl, rientjes, iamjoonsoo.kim, penberg

On 12/25/21 07:09, Hyeonggon Yoo wrote:
> SLOB always manage objects of different caches in same page regardless of
> SLAB_MERGE_DEFAULT. Because it has no effect on SLOB, make it depend on
> SLAB || SLUB.
> 
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>

I will take this to the slab tree, thanks!

> ---
>  init/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 4b7bac10c72d..03e1b863f5ce 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1933,6 +1933,7 @@ endchoice
>  config SLAB_MERGE_DEFAULT
>  	bool "Allow slab caches to be merged"
>  	default y
> +	depends on SLAB || SLUB
>  	help
>  	  For reduced kernel memory fragmentation, slab caches can be
>  	  merged when they share the same size and other characteristics.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-05 18:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-25  6:09 [PATCH] mm: Make SLAB_MERGE_DEFAULT depend on SL[AU]B Hyeonggon Yoo
2022-01-05 18:06 ` Vlastimil Babka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).