linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] proc: Avoid unused variable warning in pagemap_pmd_range()
@ 2022-02-07 17:10 Nathan Chancellor
  0 siblings, 0 replies; only message in thread
From: Nathan Chancellor @ 2022-02-07 17:10 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Yang Shi, David Hildenbrand, linux-kernel, linux-mm, Nathan Chancellor

When building with CONFIG_TRANSPARENT_HUGEPAGE=n, there is a warning
about migration being unused:

  fs/proc/task_mmu.c:1444:7: warning: unused variable 'migration' [-Wunused-variable]
          bool migration = false;
               ^
  1 warning generated.

Move the ifdef preprocessor directive up to include migration so it is
only included in the file when it is used.

Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---

This is a fix for fs-proc-task_mmuc-dont-read-mapcount-for-migration-entry-v4.patch.

 fs/proc/task_mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index bc2f46033231..6e97ed775074 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -1441,9 +1441,9 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,
 	spinlock_t *ptl;
 	pte_t *pte, *orig_pte;
 	int err = 0;
+#ifdef CONFIG_TRANSPARENT_HUGEPAGE
 	bool migration = false;
 
-#ifdef CONFIG_TRANSPARENT_HUGEPAGE
 	ptl = pmd_trans_huge_lock(pmdp, vma);
 	if (ptl) {
 		u64 flags = 0, frame = 0;

base-commit: b3c0a155ef77550d48f6eb7c6fdd6075764a5622
-- 
2.35.1



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-07 17:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 17:10 [PATCH] proc: Avoid unused variable warning in pagemap_pmd_range() Nathan Chancellor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).