* [akpm-mm:mm-unstable 179/180] fs/xfs/xfs_file.c:1273:1: warning: no previous prototype for 'xfs_dax_fault'
@ 2022-06-04 12:33 kernel test robot
2022-06-04 18:48 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-06-04 12:33 UTC (permalink / raw)
To: Shiyang Ruan
Cc: kbuild-all, linux-kernel, Andrew Morton,
Linux Memory Management List, Darrick J. Wong
tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
head: f06e3c5104126b9a6660b58f29619b53bfa33b2b
commit: d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c [179/180] xfs: support CoW in fsdax mode
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220604/202206042008.WcIK2oVM-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?id=d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c
git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git
git fetch --no-tags akpm-mm mm-unstable
git checkout d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash fs/xfs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/xfs/xfs_file.c:1273:1: warning: no previous prototype for 'xfs_dax_fault' [-Wmissing-prototypes]
1273 | xfs_dax_fault(
| ^~~~~~~~~~~~~
vim +/xfs_dax_fault +1273 fs/xfs/xfs_file.c
1257
1258 #ifdef CONFIG_FS_DAX
1259 int
1260 xfs_dax_fault(
1261 struct vm_fault *vmf,
1262 enum page_entry_size pe_size,
1263 bool write_fault,
1264 pfn_t *pfn)
1265 {
1266 return dax_iomap_fault(vmf, pe_size, pfn, NULL,
1267 (write_fault && !vmf->cow_page) ?
1268 &xfs_dax_write_iomap_ops :
1269 &xfs_read_iomap_ops);
1270 }
1271 #else
1272 int
> 1273 xfs_dax_fault(
1274 struct vm_fault *vmf,
1275 enum page_entry_size pe_size,
1276 bool write_fault,
1277 pfn_t *pfn)
1278 {
1279 return 0;
1280 }
1281 #endif
1282
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [akpm-mm:mm-unstable 179/180] fs/xfs/xfs_file.c:1273:1: warning: no previous prototype for 'xfs_dax_fault'
2022-06-04 12:33 [akpm-mm:mm-unstable 179/180] fs/xfs/xfs_file.c:1273:1: warning: no previous prototype for 'xfs_dax_fault' kernel test robot
@ 2022-06-04 18:48 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2022-06-04 18:48 UTC (permalink / raw)
To: kernel test robot
Cc: Shiyang Ruan, kbuild-all, linux-kernel,
Linux Memory Management List, Darrick J. Wong
On Sat, 4 Jun 2022 20:33:01 +0800 kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
> head: f06e3c5104126b9a6660b58f29619b53bfa33b2b
> commit: d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c [179/180] xfs: support CoW in fsdax mode
> config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220604/202206042008.WcIK2oVM-lkp@intel.com/config)
> compiler: mips-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?id=d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c
> git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git
> git fetch --no-tags akpm-mm mm-unstable
> git checkout d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash fs/xfs/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> fs/xfs/xfs_file.c:1273:1: warning: no previous prototype for 'xfs_dax_fault' [-Wmissing-prototypes]
> 1273 | xfs_dax_fault(
> | ^~~~~~~~~~~~~
>
Works OK for me with gcc-12.1.0.
I assume this will fix it.
--- a/fs/xfs/xfs_file.c~xfs-support-cow-in-fsdax-mode-fix
+++ a/fs/xfs/xfs_file.c
@@ -1256,7 +1256,7 @@ xfs_file_llseek(
}
#ifdef CONFIG_FS_DAX
-int
+static int
xfs_dax_fault(
struct vm_fault *vmf,
enum page_entry_size pe_size,
@@ -1269,7 +1269,7 @@ xfs_dax_fault(
&xfs_read_iomap_ops);
}
#else
-int
+static int
xfs_dax_fault(
struct vm_fault *vmf,
enum page_entry_size pe_size,
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-04 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-04 12:33 [akpm-mm:mm-unstable 179/180] fs/xfs/xfs_file.c:1273:1: warning: no previous prototype for 'xfs_dax_fault' kernel test robot
2022-06-04 18:48 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).