* [PATCH mm-unstable] mm/khugepaged: add missing kfree() to madvise_collapse()
@ 2022-07-13 16:18 Zach O'Keefe
0 siblings, 0 replies; only message in thread
From: Zach O'Keefe @ 2022-07-13 16:18 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-mm, Dan Carpenter, Souptick Joarder, kernel test robot,
Yang Shi, Zach O'Keefe
smatch warnings:
mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of
'cc'
Link: https://lore.kernel.org/linux-mm/202207100715.TBIYQ4fc-lkp@intel.com/
Link: https://lore.kernel.org/linux-mm/20220713024109.62810-1-jrdr.linux@gmail.com/
Fixes: 3f7416127072 ("mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zach O'Keefe <zokeefe@google.com>
---
This is in addition to the patch submitted by "Souptick Joarder (HPE)"
<jrdr.linux@gmail.com>: "mm/khugepaged: Avoid possible memory leak in failure path"
---
mm/khugepaged.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 0207fc0a5b2a..944cf6c8a252 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -2472,6 +2472,7 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
out_nolock:
mmap_assert_locked(mm);
mmdrop(mm);
+ kfree(cc);
return thps == ((hend - hstart) >> HPAGE_PMD_SHIFT) ? 0
: madvise_collapse_errno(last_fail);
--
2.37.0.144.g8ac04bfd2-goog
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-13 16:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 16:18 [PATCH mm-unstable] mm/khugepaged: add missing kfree() to madvise_collapse() Zach O'Keefe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).