linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 6202/7934] sound/soc/intel/skylake/skl.c:735:30: error: 'skl' undeclared
@ 2022-09-19 17:36 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-09-19 17:36 UTC (permalink / raw)
  To: Gaosheng Cui; +Cc: kbuild-all, Linux Memory Management List, Mark Brown

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   4c9ca5b1597e3222177ba2a94658f78fa5ef4f58
commit: 515626a33a194c4caaf2879dbf9e00e882582af0 [6202/7934] ASoC: Intel: fix unused-variable warning in probe_codec
config: loongarch-randconfig-r035-20220919 (https://download.01.org/0day-ci/archive/20220920/202209200142.oTTHCQyD-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=515626a33a194c4caaf2879dbf9e00e882582af0
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 515626a33a194c4caaf2879dbf9e00e882582af0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash sound/soc/intel/skylake/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

Note: the linux-next/master HEAD 4c9ca5b1597e3222177ba2a94658f78fa5ef4f58 builds fine.
      It may have been fixed somewhere.

All errors (new ones prefixed by >>):

   sound/soc/intel/skylake/skl.c: In function 'probe_codec':
>> sound/soc/intel/skylake/skl.c:735:30: error: 'skl' undeclared (first use in this function)
     735 |         hdev = devm_kzalloc(&skl->pci->dev, sizeof(*hdev), GFP_KERNEL);
         |                              ^~~
   sound/soc/intel/skylake/skl.c:735:30: note: each undeclared identifier is reported only once for each function it appears in


vim +/skl +735 sound/soc/intel/skylake/skl.c

8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  691  
d8c2dab8381d583 Jeeja KP             2015-07-09  692  /*
d8c2dab8381d583 Jeeja KP             2015-07-09  693   * Probe the given codec address
d8c2dab8381d583 Jeeja KP             2015-07-09  694   */
76f56fae1cf9040 Rakesh Ughreja       2018-06-01  695  static int probe_codec(struct hdac_bus *bus, int addr)
d8c2dab8381d583 Jeeja KP             2015-07-09  696  {
d8c2dab8381d583 Jeeja KP             2015-07-09  697  	unsigned int cmd = (addr << 28) | (AC_NODE_ROOT << 20) |
d8c2dab8381d583 Jeeja KP             2015-07-09  698  		(AC_VERB_PARAMETERS << 8) | AC_PAR_VENDOR_ID;
e6a33532affd14c Dan Carpenter        2017-04-20  699  	unsigned int res = -1;
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  700  #if IS_ENABLED(CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC)
515626a33a194c4 Gaosheng Cui         2022-08-22  701  	struct skl_dev *skl = bus_to_skl(bus);
6bae5ea94989264 Rakesh Ughreja       2018-08-22  702  	struct hdac_hda_priv *hda_codec;
6bae5ea94989264 Rakesh Ughreja       2018-08-22  703  	int err;
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  704  #endif
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  705  	struct hdac_device *hdev;
d8c2dab8381d583 Jeeja KP             2015-07-09  706  
d8c2dab8381d583 Jeeja KP             2015-07-09  707  	mutex_lock(&bus->cmd_mutex);
d8c2dab8381d583 Jeeja KP             2015-07-09  708  	snd_hdac_bus_send_cmd(bus, cmd);
d8c2dab8381d583 Jeeja KP             2015-07-09  709  	snd_hdac_bus_get_response(bus, addr, &res);
d8c2dab8381d583 Jeeja KP             2015-07-09  710  	mutex_unlock(&bus->cmd_mutex);
d8c2dab8381d583 Jeeja KP             2015-07-09  711  	if (res == -1)
d8c2dab8381d583 Jeeja KP             2015-07-09  712  		return -EIO;
00deadb5d86a3c1 Rakesh Ughreja       2018-08-22  713  	dev_dbg(bus->dev, "codec #%d probed OK: %x\n", addr, res);
d8c2dab8381d583 Jeeja KP             2015-07-09  714  
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  715  #if IS_ENABLED(CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC)
6bae5ea94989264 Rakesh Ughreja       2018-08-22  716  	hda_codec = devm_kzalloc(&skl->pci->dev, sizeof(*hda_codec),
6bae5ea94989264 Rakesh Ughreja       2018-08-22  717  				 GFP_KERNEL);
6bae5ea94989264 Rakesh Ughreja       2018-08-22  718  	if (!hda_codec)
6298542fa33b6ba Rakesh Ughreja       2018-06-01  719  		return -ENOMEM;
6298542fa33b6ba Rakesh Ughreja       2018-06-01  720  
6bae5ea94989264 Rakesh Ughreja       2018-08-22  721  	hda_codec->codec.bus = skl_to_hbus(skl);
6bae5ea94989264 Rakesh Ughreja       2018-08-22  722  	hdev = &hda_codec->codec.core;
6bae5ea94989264 Rakesh Ughreja       2018-08-22  723  
163cd1059a85d22 Kai Vehmanen         2020-09-21  724  	err = snd_hdac_ext_bus_device_init(bus, addr, hdev, HDA_DEV_ASOC);
6bae5ea94989264 Rakesh Ughreja       2018-08-22  725  	if (err < 0)
6bae5ea94989264 Rakesh Ughreja       2018-08-22  726  		return err;
6bae5ea94989264 Rakesh Ughreja       2018-08-22  727  
6bae5ea94989264 Rakesh Ughreja       2018-08-22  728  	/* use legacy bus only for HDA codecs, idisp uses ext bus */
6bae5ea94989264 Rakesh Ughreja       2018-08-22  729  	if ((res & 0xFFFF0000) != IDISP_INTEL_VENDOR_ID) {
6bae5ea94989264 Rakesh Ughreja       2018-08-22  730  		hdev->type = HDA_DEV_LEGACY;
6bae5ea94989264 Rakesh Ughreja       2018-08-22  731  		load_codec_module(&hda_codec->codec);
6bae5ea94989264 Rakesh Ughreja       2018-08-22  732  	}
6bae5ea94989264 Rakesh Ughreja       2018-08-22  733  	return 0;
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  734  #else
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18 @735  	hdev = devm_kzalloc(&skl->pci->dev, sizeof(*hdev), GFP_KERNEL);
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  736  	if (!hdev)
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  737  		return -ENOMEM;
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  738  
163cd1059a85d22 Kai Vehmanen         2020-09-21  739  	return snd_hdac_ext_bus_device_init(bus, addr, hdev, HDA_DEV_ASOC);
8c4e7c2ee8096b5 Pierre-Louis Bossart 2018-11-18  740  #endif /* CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC */
d8c2dab8381d583 Jeeja KP             2015-07-09  741  }
d8c2dab8381d583 Jeeja KP             2015-07-09  742  

:::::: The code at line 735 was first introduced by commit
:::::: 8c4e7c2ee8096b5ca8214418f287b3878d578cc0 ASoC: Intel: Skylake: fix Kconfigs, make HDaudio codec optional

:::::: TO: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
:::::: CC: Mark Brown <broonie@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2022-09-19 17:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 17:36 [linux-next:master 6202/7934] sound/soc/intel/skylake/skl.c:735:30: error: 'skl' undeclared kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).