linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: Wei Wang <weiwan@google.com>, Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: [PATCH net-next] net-memcg: pass in gfp_t mask to mem_cgroup_charge_skmem()
Date: Wed, 12 Oct 2022 18:40:50 -0700	[thread overview]
Message-ID: <20221012184050.5a7f3bde@kernel.org> (raw)
In-Reply-To: <20221013005431.wzjurocrdoozykl7@google.com>

On Thu, 13 Oct 2022 00:54:31 +0000 Shakeel Butt wrote:
> So, before the patch, the memcg code may force charges but it will
> return false and make the networking code to uncharge memcg for
> SK_MEM_RECV.

Ah, right, I see it now :(

I guess I'll have to try to test (some approximation of) a revert 
after all.

Did the fact that we used to force charge not potentially cause
reclaim, tho?  Letting TCP accept the next packet even if it had
to drop the current one?


  reply	other threads:[~2022-10-13  1:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 19:40 [PATCH net-next] net-memcg: pass in gfp_t mask to mem_cgroup_charge_skmem() Wei Wang
2021-08-18 10:50 ` patchwork-bot+netdevbpf
2022-10-12 23:33 ` Jakub Kicinski
2022-10-13  0:17   ` Shakeel Butt
2022-10-13  0:38     ` Jakub Kicinski
2022-10-13  0:54       ` Shakeel Butt
2022-10-13  1:40         ` Jakub Kicinski [this message]
2022-10-13  3:16           ` Jakub Kicinski
2022-10-13  3:34             ` Wei Wang
2022-10-13  3:49               ` Jakub Kicinski
2022-10-13  4:04                 ` Wei Wang
2022-10-13  4:18                   ` Shakeel Butt
2022-10-13 21:49   ` Jakub Kicinski
2022-10-13 22:02     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221012184050.5a7f3bde@kernel.org \
    --to=kuba@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    --cc=weiwan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).