From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Jann Horn <jannh@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Zach O'Keefe <zokeefe@google.com>,
linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH] mm/khugepaged: Fix ->anon_vma race
Date: Sun, 15 Jan 2023 22:06:54 +0300 [thread overview]
Message-ID: <20230115190654.mehtlyz2rxtg34sl@box.shutemov.name> (raw)
In-Reply-To: <CAG48ez3434wZBKFFbdx4M9j6eUwSUVPd4dxhzW_k_POneSDF+A@mail.gmail.com>
On Fri, Jan 13, 2023 at 08:28:59PM +0100, Jann Horn wrote:
> No, that lockdep assert has to be there. Page table traversal is
> allowed under any one of the mmap lock, the anon_vma lock (if the VMA
> is associated with an anon_vma), and the mapping lock (if the VMA is
> associated with a mapping); and so to be able to remove page tables,
> we must hold all three of them.
Okay, that's fair. I agree with the patch now. Maybe adjust the commit
message a bit?
Anyway:
Acked-by: Kirill A. Shutemov <kirill.shutemov@intel.linux.com>
BTW, I've noticied that you recently added tlb_remove_table_sync_one().
I'm not sure why it is needed. Why IPI in pmdp_collapse_flush() in not
good enough to serialize against GUP fast?
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2023-01-15 19:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:33 [PATCH] mm/khugepaged: Fix ->anon_vma race Jann Horn
2023-01-12 1:06 ` Yang Shi
2023-01-13 19:36 ` Jann Horn
2023-01-12 8:56 ` Kirill A. Shutemov
2023-01-12 18:12 ` Yang Shi
2023-01-13 0:10 ` Kirill A. Shutemov
2023-01-13 3:22 ` Yang Shi
2023-01-13 19:28 ` Jann Horn
2023-01-15 19:06 ` Kirill A. Shutemov [this message]
2023-01-16 12:06 ` Jann Horn
2023-01-16 12:34 ` Kirill A. Shutemov
2023-01-16 12:54 ` Jann Horn
2023-01-16 13:07 ` David Hildenbrand
2023-01-16 13:47 ` Kirill A. Shutemov
2023-01-23 11:07 ` David Hildenbrand
2023-01-24 0:51 ` Kirill A. Shutemov
2023-01-24 10:19 ` David Hildenbrand
2023-01-17 18:57 ` Yang Shi
2023-01-17 19:12 ` Jann Horn
2023-01-17 22:55 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230115190654.mehtlyz2rxtg34sl@box.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).