From: maobibo <maobibo@loongson.cn>
To: "Qi Zheng" <zhengqi.arch@bytedance.com>,
"David Hildenbrand" <david@redhat.com>,
akpm@linux-foundation.org, muchun.song@linux.dev,
陈华才 <chenhuacai@loongson.cn>
Cc: chris@zankel.net, jcmvbkbc@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v2] mm: use update_mmu_tlb() on the second thread
Date: Thu, 29 Sep 2022 12:05:33 +0800 [thread overview]
Message-ID: <24f6df23-82cc-1290-e015-cba2a284e060@loongson.cn> (raw)
In-Reply-To: <d4e4a362-fbf2-7eea-e021-16ae7782e06e@bytedance.com>
在 2022/9/29 11:47, Qi Zheng 写道:
>
>
> On 2022/9/29 11:27, maobibo wrote:
>> 在 2022/9/29 11:07, Qi Zheng 写道:
>>>
>>>
>>> On 2022/9/26 22:34, David Hildenbrand wrote:
>>>> On 26.09.22 13:56, Qi Zheng wrote:
>>>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB
>>>>> if PTE entry exists") said, we should update local TLB only on the
>>>>> second thread. So in the do_anonymous_page() here, we should use
>>>>> update_mmu_tlb() instead of update_mmu_cache() on the second thread.
>>>>>
>>>>> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
>>>>> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
>>>>> ---
>>>>> v1: https://lore.kernel.org/lkml/20220924053239.91661-1-zhengqi.arch@bytedance.com/
>>>>>
>>>>> Changelog in v1 -> v2:
>>>>> - change the subject and commit message (David)
>>>>>
>>>>> mm/memory.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/mm/memory.c b/mm/memory.c
>>>>> index 118e5f023597..9e11c783ba0e 100644
>>>>> --- a/mm/memory.c
>>>>> +++ b/mm/memory.c
>>>>> @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf)
>>>>> vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address,
>>>>> &vmf->ptl);
>>>>> if (!pte_none(*vmf->pte)) {
>>>>> - update_mmu_cache(vma, vmf->address, vmf->pte);
>>>>> + update_mmu_tlb(vma, vmf->address, vmf->pte);
>>>>> goto release;
>>>>> }
>>>>
>>>>
>>>> Staring at 7df676974359, it indeed looks like an accidental use [nothing else in that patch uses update_mmu_cache].
>>>>
>>>> So it looks good to me, but a confirmation from Bibo Mao might be good.
>>>
>>> Thanks, and Hi Bibo, any comments here? :)
>>
>> update_mmu_tlb is defined as empty on loongarch, maybe some lines should
>> be added in file arch/loongarch/include/asm/pgtable.h like this:
>
> Seems like a bug? Because there are many other places where
> update_mmu_tlb() is called.
>
>>
>> +#define __HAVE_ARCH_UPDATE_MMU_TLB
>> +#define update_mmu_tlb update_mmu_cache
>
> If so, I can make the above as a separate fix patch.
It sounds good to me.
Huacai, do you have any comments?
regards
bibo, mao
>
> Thanks,
> Qi
>
>>
>> regards
>> bibo mao
>>>
>>>>
>>>
>>
>
next prev parent reply other threads:[~2022-09-29 4:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 11:56 [PATCH v2] mm: use update_mmu_tlb() on the second thread Qi Zheng
2022-09-26 14:34 ` David Hildenbrand
2022-09-29 3:07 ` Qi Zheng
2022-09-29 3:27 ` maobibo
2022-09-29 3:47 ` Qi Zheng
2022-09-29 4:05 ` maobibo [this message]
2022-09-29 8:38 ` 陈华才
2022-09-29 8:42 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24f6df23-82cc-1290-e015-cba2a284e060@loongson.cn \
--to=maobibo@loongson.cn \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@loongson.cn \
--cc=chris@zankel.net \
--cc=david@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=songmuchun@bytedance.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).