From: "Wang, Kemi" <kemi.wang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Christopher Lameter <cl@linux.com>,
YASUAKI ISHIMATSU <yasu.isimatu@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Nikolay Borisov <nborisov@suse.com>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
David Rientjes <rientjes@google.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Dave <dave.hansen@linux.intel.com>,
"Kleen, Andi" <andi.kleen@intel.com>,
"Chen, Tim C" <tim.c.chen@intel.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
"Huang, Ying" <ying.huang@intel.com>,
"Lu, Aaron" <aaron.lu@intel.com>,
"Li, Aubrey" <aubrey.li@intel.com>, Linux MM <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement
Date: Thu, 30 Nov 2017 11:06:51 +0000 [thread overview]
Message-ID: <25017BF213203E48912DB000DE5F5E1E6B70EA3C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20171130094523.vvcljyfqjpbloe5e@dhcp22.suse.cz>
Of course, we should do that AFAP. Thanks for your comments :)
-----Original Message-----
From: owner-linux-mm@kvack.org [mailto:owner-linux-mm@kvack.org] On Behalf Of Michal Hocko
Sent: Thursday, November 30, 2017 5:45 PM
To: Wang, Kemi <kemi.wang@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Andrew Morton <akpm@linux-foundation.org>; Vlastimil Babka <vbabka@suse.cz>; Mel Gorman <mgorman@techsingularity.net>; Johannes Weiner <hannes@cmpxchg.org>; Christopher Lameter <cl@linux.com>; YASUAKI ISHIMATSU <yasu.isimatu@gmail.com>; Andrey Ryabinin <aryabinin@virtuozzo.com>; Nikolay Borisov <nborisov@suse.com>; Pavel Tatashin <pasha.tatashin@oracle.com>; David Rientjes <rientjes@google.com>; Sebastian Andrzej Siewior <bigeasy@linutronix.de>; Dave <dave.hansen@linux.intel.com>; Kleen, Andi <andi.kleen@intel.com>; Chen, Tim C <tim.c.chen@intel.com>; Jesper Dangaard Brouer <brouer@redhat.com>; Huang, Ying <ying.huang@intel.com>; Lu, Aaron <aaron.lu@intel.com>; Li, Aubrey <aubrey.li@intel.com>; Linux MM <linux-mm@kvack.org>; Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement
On Thu 30-11-17 17:32:08, kemi wrote:
[...]
> Your patch saves more code than mine because the node stats framework
> is reused for numa stats. But it has a performance regression because
> of the limitation of threshold size (125 at most, see
> calculate_normal_threshold() in vmstat.c) in inc_node_state().
But this "regression" would be visible only on those workloads which really need to squeeze every single cycle out of the allocation hot path and those are supposed to disable the accounting altogether. Or is this visible on a wider variety of workloads.
Do not get me wrong. If we want to make per-node stats more optimal, then by all means let's do that. But having 3 sets of counters is just way to much.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-30 11:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 6:00 [PATCH 1/2] mm: NUMA stats code cleanup and enhancement Kemi Wang
2017-11-28 6:00 ` [PATCH 2/2] mm: Rename zone_statistics() to numa_statistics() Kemi Wang
2017-11-28 8:09 ` [PATCH 1/2] mm: NUMA stats code cleanup and enhancement Vlastimil Babka
2017-11-28 8:33 ` kemi
2017-11-28 18:40 ` Andi Kleen
2017-11-28 21:56 ` Andrew Morton
2017-11-28 22:52 ` Vlastimil Babka
2017-11-29 12:17 ` Michal Hocko
2017-11-30 5:56 ` kemi
2017-11-30 8:53 ` Michal Hocko
2017-11-30 9:32 ` kemi
2017-11-30 9:45 ` Michal Hocko
2017-11-30 11:06 ` Wang, Kemi [this message]
2017-12-08 8:38 ` kemi
2017-12-08 8:47 ` Michal Hocko
2017-12-12 2:05 ` kemi
2017-12-12 8:11 ` Michal Hocko
2017-12-14 1:40 ` kemi
2017-12-14 7:29 ` Michal Hocko
2017-12-14 8:55 ` kemi
2017-12-14 9:23 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25017BF213203E48912DB000DE5F5E1E6B70EA3C@SHSMSX101.ccr.corp.intel.com \
--to=kemi.wang@intel.com \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=aryabinin@virtuozzo.com \
--cc=aubrey.li@intel.com \
--cc=bigeasy@linutronix.de \
--cc=brouer@redhat.com \
--cc=cl@linux.com \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=nborisov@suse.com \
--cc=pasha.tatashin@oracle.com \
--cc=rientjes@google.com \
--cc=tim.c.chen@intel.com \
--cc=vbabka@suse.cz \
--cc=yasu.isimatu@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).