From: David Hildenbrand <david@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Michal Hocko <mhocko@kernel.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 0/3] create hugetlb flags to consolidate state
Date: Tue, 12 Jan 2021 11:41:04 +0100 [thread overview]
Message-ID: <250496a6-edfb-6a0e-9ca2-f1ceea6a0c8a@redhat.com> (raw)
In-Reply-To: <20210111210152.118394-1-mike.kravetz@oracle.com>
On 11.01.21 22:01, Mike Kravetz wrote:
> While discussing a series of hugetlb fixes in [1], it became evident
> that the hugetlb specific page state information is stored in a somewhat
> haphazard manner. Code dealing with state information would be easier
> to read, understand and maintain if this information was stored in a
> consistent manner.
>
> This RFC series uses page.private of the hugetlb head page for storing a
> set of hugetlb specific page flags. Routines to manipulate the flags
> are copied from normal page flag manipulation code and use atomic
> operations. This is likely overkill for the uses in hugetlb code, and
> can be changed after additional auditing of code.
Haven't looked into the code but that sounds like a good idea.
>
> For now, only 3 state flags are added as part of this series. However,
> the suggested fix in [2] could use another flag. In addition, a flag
> could be used to track whether or not a huge page has been cleared to
> optimize code paths if the init_on_alloc security feature is enabled.
Right, that will be helpful: indicating pages that were either cleared
directly when allocating (init_on_alloc) or via some asynchronous
mechanism in the future.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-01-12 10:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 21:01 [RFC PATCH 0/3] create hugetlb flags to consolidate state Mike Kravetz
2021-01-11 21:01 ` [RFC PATCH 1/3] hugetlb: use page.private for hugetlb specific page flags Mike Kravetz
2021-01-12 3:24 ` [External] " Muchun Song
2021-01-13 13:54 ` Oscar Salvador
2021-01-13 17:49 ` Mike Kravetz
2021-01-13 14:45 ` Matthew Wilcox
2021-01-13 17:51 ` Mike Kravetz
2021-01-11 21:01 ` [RFC PATCH 2/3] hugetlb: convert page_huge_active() to HPageMigratable flag Mike Kravetz
2021-01-12 3:45 ` [External] " Muchun Song
2021-01-15 9:17 ` Oscar Salvador
2021-01-15 17:43 ` Mike Kravetz
2021-01-15 20:05 ` Mike Kravetz
2021-01-15 20:29 ` Oscar Salvador
2021-01-15 21:25 ` Mike Kravetz
2021-01-15 20:38 ` Oscar Salvador
2021-01-11 21:01 ` [RFC PATCH 3/3] hugetlb: convert PageHugeTemporary() to HPageTempSurplus Mike Kravetz
2021-01-15 10:16 ` Oscar Salvador
2021-01-15 17:47 ` Mike Kravetz
2021-01-12 10:41 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=250496a6-edfb-6a0e-9ca2-f1ceea6a0c8a@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).