From: Oscar Salvador <osalvador@suse.de>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@kernel.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Muchun Song <songmuchun@bytedance.com>,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 2/3] hugetlb: convert page_huge_active() to HPageMigratable flag
Date: Fri, 15 Jan 2021 21:29:15 +0100 [thread overview]
Message-ID: <20210115202915.GA3322@localhost.localdomain> (raw)
In-Reply-To: <41ca9f90-63e3-f991-3f78-433f77250527@oracle.com>
On Fri, Jan 15, 2021 at 12:05:29PM -0800, Mike Kravetz wrote:
> I went back and took a closer look. Migration is the reason the existing
> page_huge_active interfaces were introduced. And, the only use of the
> page_huge_active check is to determine if a page can be migrated. So,
> I think 'Migratable' may be the most suitable name.
Ok, I did not know that. Let us stick with 'Migratable' then.
> To address the concern about not all hugetlb sizes are migratable, we can
> just make a check before setting the flag. This should even help in the
> migration/offline paths as we will know sooner if the page can be
> migrated or not.
This sounds like a good idea to me.
> We can address naming in the 'migrating free hugetlb pages' issue when
> that code is written.
Sure, it was just a suggestion as when I though about that something
like 'InUse' or 'Active' made more sense to me, but your point is valid.
Sorry for the confusion.
About that alloc_contig_range topic, I would like to take a look unless
someone is already on it or about to be.
Thanks Mike for the time ;-)
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-01-15 20:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 21:01 [RFC PATCH 0/3] create hugetlb flags to consolidate state Mike Kravetz
2021-01-11 21:01 ` [RFC PATCH 1/3] hugetlb: use page.private for hugetlb specific page flags Mike Kravetz
2021-01-12 3:24 ` [External] " Muchun Song
2021-01-13 13:54 ` Oscar Salvador
2021-01-13 17:49 ` Mike Kravetz
2021-01-13 14:45 ` Matthew Wilcox
2021-01-13 17:51 ` Mike Kravetz
2021-01-11 21:01 ` [RFC PATCH 2/3] hugetlb: convert page_huge_active() to HPageMigratable flag Mike Kravetz
2021-01-12 3:45 ` [External] " Muchun Song
2021-01-15 9:17 ` Oscar Salvador
2021-01-15 17:43 ` Mike Kravetz
2021-01-15 20:05 ` Mike Kravetz
2021-01-15 20:29 ` Oscar Salvador [this message]
2021-01-15 21:25 ` Mike Kravetz
2021-01-15 20:38 ` Oscar Salvador
2021-01-11 21:01 ` [RFC PATCH 3/3] hugetlb: convert PageHugeTemporary() to HPageTempSurplus Mike Kravetz
2021-01-15 10:16 ` Oscar Salvador
2021-01-15 17:47 ` Mike Kravetz
2021-01-12 10:41 ` [RFC PATCH 0/3] create hugetlb flags to consolidate state David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115202915.GA3322@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).