linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range
@ 2019-01-11 15:12 Souptick Joarder
  2019-01-14 23:27 ` Boris Ostrovsky
  0 siblings, 1 reply; 6+ messages in thread
From: Souptick Joarder @ 2019-01-11 15:12 UTC (permalink / raw)
  To: akpm, willy, mhocko, boris.ostrovsky, jgross, linux, robin.murphy
  Cc: xen-devel, linux-kernel, linux-mm

Convert to use vm_insert_range() to map range of kernel
memory to user vma.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/xen/gntdev.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index b0b02a5..ca4acee 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -1082,18 +1082,17 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 {
 	struct gntdev_priv *priv = flip->private_data;
 	int index = vma->vm_pgoff;
-	int count = vma_pages(vma);
 	struct gntdev_grant_map *map;
-	int i, err = -EINVAL;
+	int err = -EINVAL;
 
 	if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED))
 		return -EINVAL;
 
 	pr_debug("map %d+%d at %lx (pgoff %lx)\n",
-			index, count, vma->vm_start, vma->vm_pgoff);
+			index, vma_pages(vma), vma->vm_start, vma->vm_pgoff);
 
 	mutex_lock(&priv->lock);
-	map = gntdev_find_map_index(priv, index, count);
+	map = gntdev_find_map_index(priv, index, vma_pages(vma));
 	if (!map)
 		goto unlock_out;
 	if (use_ptemod && map->vma)
@@ -1145,12 +1144,9 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 		goto out_put_map;
 
 	if (!use_ptemod) {
-		for (i = 0; i < count; i++) {
-			err = vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE,
-				map->pages[i]);
-			if (err)
-				goto out_put_map;
-		}
+		err = vm_insert_range(vma, map->pages, map->count);
+		if (err)
+			goto out_put_map;
 	} else {
 #ifdef CONFIG_X86
 		/*
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range
  2019-01-11 15:12 [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range Souptick Joarder
@ 2019-01-14 23:27 ` Boris Ostrovsky
  2019-01-15  4:49   ` Souptick Joarder
  0 siblings, 1 reply; 6+ messages in thread
From: Boris Ostrovsky @ 2019-01-14 23:27 UTC (permalink / raw)
  To: Souptick Joarder, akpm, willy, mhocko, jgross, linux, robin.murphy
  Cc: xen-devel, linux-kernel, linux-mm

On 1/11/19 10:12 AM, Souptick Joarder wrote:
> Convert to use vm_insert_range() to map range of kernel
> memory to user vma.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

(although it would be good to mention in the commit that you are also
replacing count with vma_pages(vma), and why)


> ---
>  drivers/xen/gntdev.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index b0b02a5..ca4acee 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -1082,18 +1082,17 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
>  {
>  	struct gntdev_priv *priv = flip->private_data;
>  	int index = vma->vm_pgoff;
> -	int count = vma_pages(vma);
>  	struct gntdev_grant_map *map;
> -	int i, err = -EINVAL;
> +	int err = -EINVAL;
>  
>  	if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED))
>  		return -EINVAL;
>  
>  	pr_debug("map %d+%d at %lx (pgoff %lx)\n",
> -			index, count, vma->vm_start, vma->vm_pgoff);
> +			index, vma_pages(vma), vma->vm_start, vma->vm_pgoff);
>  
>  	mutex_lock(&priv->lock);
> -	map = gntdev_find_map_index(priv, index, count);
> +	map = gntdev_find_map_index(priv, index, vma_pages(vma));
>  	if (!map)
>  		goto unlock_out;
>  	if (use_ptemod && map->vma)
> @@ -1145,12 +1144,9 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
>  		goto out_put_map;
>  
>  	if (!use_ptemod) {
> -		for (i = 0; i < count; i++) {
> -			err = vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE,
> -				map->pages[i]);
> -			if (err)
> -				goto out_put_map;
> -		}
> +		err = vm_insert_range(vma, map->pages, map->count);
> +		if (err)
> +			goto out_put_map;
>  	} else {
>  #ifdef CONFIG_X86
>  		/*

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range
  2019-01-14 23:27 ` Boris Ostrovsky
@ 2019-01-15  4:49   ` Souptick Joarder
  2019-01-15  4:49     ` Souptick Joarder
  2019-01-15 15:29     ` Boris Ostrovsky
  0 siblings, 2 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-01-15  4:49 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: Andrew Morton, Matthew Wilcox, Michal Hocko, Juergen Gross,
	Russell King - ARM Linux, robin.murphy, xen-devel, linux-kernel,
	Linux-MM

On Tue, Jan 15, 2019 at 4:58 AM Boris Ostrovsky
<boris.ostrovsky@oracle.com> wrote:
>
> On 1/11/19 10:12 AM, Souptick Joarder wrote:
> > Convert to use vm_insert_range() to map range of kernel
> > memory to user vma.
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> (although it would be good to mention in the commit that you are also
> replacing count with vma_pages(vma), and why)

The original code was using count ( *count = vma_pages(vma)* )
which is same as this patch. Do I need capture it change log ?

>
>
> > ---
> >  drivers/xen/gntdev.c | 16 ++++++----------
> >  1 file changed, 6 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> > index b0b02a5..ca4acee 100644
> > --- a/drivers/xen/gntdev.c
> > +++ b/drivers/xen/gntdev.c
> > @@ -1082,18 +1082,17 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
> >  {
> >       struct gntdev_priv *priv = flip->private_data;
> >       int index = vma->vm_pgoff;
> > -     int count = vma_pages(vma);
> >       struct gntdev_grant_map *map;
> > -     int i, err = -EINVAL;
> > +     int err = -EINVAL;
> >
> >       if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED))
> >               return -EINVAL;
> >
> >       pr_debug("map %d+%d at %lx (pgoff %lx)\n",
> > -                     index, count, vma->vm_start, vma->vm_pgoff);
> > +                     index, vma_pages(vma), vma->vm_start, vma->vm_pgoff);
> >
> >       mutex_lock(&priv->lock);
> > -     map = gntdev_find_map_index(priv, index, count);
> > +     map = gntdev_find_map_index(priv, index, vma_pages(vma));
> >       if (!map)
> >               goto unlock_out;
> >       if (use_ptemod && map->vma)
> > @@ -1145,12 +1144,9 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
> >               goto out_put_map;
> >
> >       if (!use_ptemod) {
> > -             for (i = 0; i < count; i++) {
> > -                     err = vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE,
> > -                             map->pages[i]);
> > -                     if (err)
> > -                             goto out_put_map;
> > -             }
> > +             err = vm_insert_range(vma, map->pages, map->count);
> > +             if (err)
> > +                     goto out_put_map;
> >       } else {
> >  #ifdef CONFIG_X86
> >               /*
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range
  2019-01-15  4:49   ` Souptick Joarder
@ 2019-01-15  4:49     ` Souptick Joarder
  2019-01-15 15:29     ` Boris Ostrovsky
  1 sibling, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-01-15  4:49 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: Andrew Morton, Matthew Wilcox, Michal Hocko, Juergen Gross,
	Russell King - ARM Linux, robin.murphy, xen-devel, linux-kernel,
	Linux-MM

On Tue, Jan 15, 2019 at 4:58 AM Boris Ostrovsky
<boris.ostrovsky@oracle.com> wrote:
>
> On 1/11/19 10:12 AM, Souptick Joarder wrote:
> > Convert to use vm_insert_range() to map range of kernel
> > memory to user vma.
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> (although it would be good to mention in the commit that you are also
> replacing count with vma_pages(vma), and why)

The original code was using count ( *count = vma_pages(vma)* )
which is same as this patch. Do I need capture it change log ?

>
>
> > ---
> >  drivers/xen/gntdev.c | 16 ++++++----------
> >  1 file changed, 6 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> > index b0b02a5..ca4acee 100644
> > --- a/drivers/xen/gntdev.c
> > +++ b/drivers/xen/gntdev.c
> > @@ -1082,18 +1082,17 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
> >  {
> >       struct gntdev_priv *priv = flip->private_data;
> >       int index = vma->vm_pgoff;
> > -     int count = vma_pages(vma);
> >       struct gntdev_grant_map *map;
> > -     int i, err = -EINVAL;
> > +     int err = -EINVAL;
> >
> >       if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED))
> >               return -EINVAL;
> >
> >       pr_debug("map %d+%d at %lx (pgoff %lx)\n",
> > -                     index, count, vma->vm_start, vma->vm_pgoff);
> > +                     index, vma_pages(vma), vma->vm_start, vma->vm_pgoff);
> >
> >       mutex_lock(&priv->lock);
> > -     map = gntdev_find_map_index(priv, index, count);
> > +     map = gntdev_find_map_index(priv, index, vma_pages(vma));
> >       if (!map)
> >               goto unlock_out;
> >       if (use_ptemod && map->vma)
> > @@ -1145,12 +1144,9 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
> >               goto out_put_map;
> >
> >       if (!use_ptemod) {
> > -             for (i = 0; i < count; i++) {
> > -                     err = vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE,
> > -                             map->pages[i]);
> > -                     if (err)
> > -                             goto out_put_map;
> > -             }
> > +             err = vm_insert_range(vma, map->pages, map->count);
> > +             if (err)
> > +                     goto out_put_map;
> >       } else {
> >  #ifdef CONFIG_X86
> >               /*
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range
  2019-01-15  4:49   ` Souptick Joarder
  2019-01-15  4:49     ` Souptick Joarder
@ 2019-01-15 15:29     ` Boris Ostrovsky
  1 sibling, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2019-01-15 15:29 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: Andrew Morton, Matthew Wilcox, Michal Hocko, Juergen Gross,
	Russell King - ARM Linux, robin.murphy, xen-devel, linux-kernel,
	Linux-MM

On 1/14/19 11:49 PM, Souptick Joarder wrote:
> On Tue, Jan 15, 2019 at 4:58 AM Boris Ostrovsky
> <boris.ostrovsky@oracle.com> wrote:
>> On 1/11/19 10:12 AM, Souptick Joarder wrote:
>>> Convert to use vm_insert_range() to map range of kernel
>>> memory to user vma.
>>>
>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>
>> (although it would be good to mention in the commit that you are also
>> replacing count with vma_pages(vma), and why)
> The original code was using count ( *count = vma_pages(vma)* )
> which is same as this patch. Do I need capture it change log ?


I'd just say that because theoretically count might not be equal to
map->count we should use the latter as input to vm_insert_range().

Thanks.
-boris



>
>>
>>> ---
>>>  drivers/xen/gntdev.c | 16 ++++++----------
>>>  1 file changed, 6 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
>>> index b0b02a5..ca4acee 100644
>>> --- a/drivers/xen/gntdev.c
>>> +++ b/drivers/xen/gntdev.c
>>> @@ -1082,18 +1082,17 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
>>>  {
>>>       struct gntdev_priv *priv = flip->private_data;
>>>       int index = vma->vm_pgoff;
>>> -     int count = vma_pages(vma);
>>>       struct gntdev_grant_map *map;
>>> -     int i, err = -EINVAL;
>>> +     int err = -EINVAL;
>>>
>>>       if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED))
>>>               return -EINVAL;
>>>
>>>       pr_debug("map %d+%d at %lx (pgoff %lx)\n",
>>> -                     index, count, vma->vm_start, vma->vm_pgoff);
>>> +                     index, vma_pages(vma), vma->vm_start, vma->vm_pgoff);
>>>
>>>       mutex_lock(&priv->lock);
>>> -     map = gntdev_find_map_index(priv, index, count);
>>> +     map = gntdev_find_map_index(priv, index, vma_pages(vma));
>>>       if (!map)
>>>               goto unlock_out;
>>>       if (use_ptemod && map->vma)
>>> @@ -1145,12 +1144,9 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
>>>               goto out_put_map;
>>>
>>>       if (!use_ptemod) {
>>> -             for (i = 0; i < count; i++) {
>>> -                     err = vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE,
>>> -                             map->pages[i]);
>>> -                     if (err)
>>> -                             goto out_put_map;
>>> -             }
>>> +             err = vm_insert_range(vma, map->pages, map->count);
>>> +             if (err)
>>> +                     goto out_put_map;
>>>       } else {
>>>  #ifdef CONFIG_X86
>>>               /*

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range
@ 2018-11-15 15:51 Souptick Joarder
  0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2018-11-15 15:51 UTC (permalink / raw)
  To: akpm, willy, mhocko, boris.ostrovsky, jgross
  Cc: xen-devel, linux-kernel, linux-mm

Convert to use vm_insert_range() to map range of kernel
memory to user vma.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Matthew Wilcox <willy@infradead.org>
---
 drivers/xen/gntdev.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index b0b02a5..430d4cb 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -1084,7 +1084,7 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 	int index = vma->vm_pgoff;
 	int count = vma_pages(vma);
 	struct gntdev_grant_map *map;
-	int i, err = -EINVAL;
+	int err = -EINVAL;
 
 	if ((vma->vm_flags & VM_WRITE) && !(vma->vm_flags & VM_SHARED))
 		return -EINVAL;
@@ -1145,12 +1145,9 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 		goto out_put_map;
 
 	if (!use_ptemod) {
-		for (i = 0; i < count; i++) {
-			err = vm_insert_page(vma, vma->vm_start + i*PAGE_SIZE,
-				map->pages[i]);
-			if (err)
-				goto out_put_map;
-		}
+		err = vm_insert_range(vma, vma->vm_start, map->pages, count);
+		if (err)
+			goto out_put_map;
 	} else {
 #ifdef CONFIG_X86
 		/*
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-15 15:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 15:12 [PATCH 8/9] xen/gntdev.c: Convert to use vm_insert_range Souptick Joarder
2019-01-14 23:27 ` Boris Ostrovsky
2019-01-15  4:49   ` Souptick Joarder
2019-01-15  4:49     ` Souptick Joarder
2019-01-15 15:29     ` Boris Ostrovsky
  -- strict thread matches above, loose matches on Subject: below --
2018-11-15 15:51 Souptick Joarder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).