From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@suse.com>, Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
joaodias@google.com
Subject: Re: [PATCH] mm: be more verbose for alloc_contig_range faliures
Date: Thu, 18 Feb 2021 10:02:43 +0100 [thread overview]
Message-ID: <2f167b3c-5f0a-444a-c627-49181fc8fe0d@redhat.com> (raw)
In-Reply-To: <YC4rsr9zkNAvdL4T@dhcp22.suse.cz>
On 18.02.21 09:56, Michal Hocko wrote:
> On Wed 17-02-21 08:36:03, Minchan Kim wrote:
>> alloc_contig_range is usually used on cma area or movable zone.
>> It's critical if the page migration fails on those areas so
>> dump more debugging message like memory_hotplug unless user
>> specifiy __GFP_NOWARN.
>
> I agree with David that this has a potential to generate a lot of output
> and it is not really clear whether it is worth it. Page isolation code
> already has REPORT_FAILURE mode which currently used only for the memory
> hotplug because this was just too noisy from the CMA path - d381c54760dc
> ("mm: only report isolation failures when offlining memory").
>
> Maybe migration failures are less likely to fail but still.
Side note: I really dislike that uncontrolled error reporting on memory
offlining path we have enabled as default. Yeah, it might be useful for
ZONE_MOVABLE in some cases, but otherwise it's just noise.
Just do a "sudo stress-ng --memhotplug 1" and see the log getting
flooded ...
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-02-18 9:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 16:36 [PATCH] mm: be more verbose for alloc_contig_range faliures Minchan Kim
2021-02-17 16:51 ` David Hildenbrand
2021-02-17 17:26 ` Minchan Kim
2021-02-17 17:34 ` David Hildenbrand
2021-02-17 17:45 ` Minchan Kim
2021-02-18 8:56 ` Michal Hocko
2021-02-18 9:02 ` David Hildenbrand [this message]
2021-02-18 9:35 ` Michal Hocko
2021-02-18 9:43 ` David Hildenbrand
2021-02-18 9:59 ` Michal Hocko
2021-02-18 16:19 ` Minchan Kim
2021-02-18 16:26 ` David Hildenbrand
2021-02-18 16:47 ` Minchan Kim
2021-02-18 16:53 ` David Hildenbrand
2021-02-19 9:28 ` Michal Hocko
2021-02-19 9:30 ` David Hildenbrand
2021-02-19 10:02 ` Michal Hocko
2021-02-19 10:34 ` David Hildenbrand
[not found] ` <YD50pcPuwV456vwm@google.com>
2021-03-04 16:01 ` Minchan Kim
2021-03-04 16:10 ` David Hildenbrand
2021-03-04 16:23 ` Minchan Kim
2021-03-04 16:28 ` David Hildenbrand
2021-03-04 17:11 ` Minchan Kim
2021-03-04 17:23 ` David Hildenbrand
2021-03-04 18:11 ` Minchan Kim
2021-03-04 18:22 ` Minchan Kim
2021-03-08 12:49 ` Michal Hocko
2021-03-08 13:22 ` David Hildenbrand
2021-03-08 14:11 ` Michal Hocko
2021-03-08 14:13 ` David Hildenbrand
2021-03-08 15:42 ` Michal Hocko
2021-03-08 15:58 ` Minchan Kim
2021-03-08 16:21 ` Michal Hocko
2021-03-08 17:01 ` Minchan Kim
2021-03-08 20:27 ` Minchan Kim
2021-02-18 16:10 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f167b3c-5f0a-444a-c627-49181fc8fe0d@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).