From: David Hildenbrand <david@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mempolicy: use helper range_in_vma() in queue_pages_test_walk()
Date: Mon, 1 Feb 2021 12:09:41 +0100 [thread overview]
Message-ID: <33c3c6cb-c13d-0bb3-1c65-c16d6ffe0cac@redhat.com> (raw)
In-Reply-To: <20210130091352.20220-1-linmiaohe@huawei.com>
On 30.01.21 10:13, Miaohe Lin wrote:
> The helper range_in_vma() is introduced via commit 017b1660df89 ("mm:
> migration: fix migration of huge PMD shared pages"). But we forgot to
> use it in queue_pages_test_walk().
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/mempolicy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 6961238c7ef5..ab51132547b8 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -677,7 +677,7 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
> unsigned long flags = qp->flags;
>
> /* range check first */
> - VM_BUG_ON_VMA((vma->vm_start > start) || (vma->vm_end < end), vma);
> + VM_BUG_ON_VMA(!range_in_vma(vma, start, end), vma);
>
> if (!qp->first) {
> qp->first = vma;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-02-01 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 9:13 [PATCH] mm/mempolicy: use helper range_in_vma() in queue_pages_test_walk() Miaohe Lin
2021-02-01 11:09 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c3c6cb-c13d-0bb3-1c65-c16d6ffe0cac@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).