From: Jens Axboe <axboe@kernel.dk>
To: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
Cc: io-uring@vger.kernel.org,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 07/15] mm: add support for async page locking
Date: Tue, 7 Jul 2020 08:32:59 -0600 [thread overview]
Message-ID: <3eb94b6c-eebd-8c0d-fe29-365df50b8949@kernel.dk> (raw)
In-Reply-To: <CAHpGcM+iUnrLg+2jLzUPS45+E0ne8EiNEHt81Bjqko51u--+CA@mail.gmail.com>
On 7/7/20 5:32 AM, Andreas Grünbacher wrote:
>> @@ -2131,6 +2166,11 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb,
>> }
>>
>> readpage:
>> + if (iocb->ki_flags & IOCB_NOWAIT) {
>> + unlock_page(page);
>> + put_page(page);
>> + goto would_block;
>> + }
>
> This hunk should have been part of "mm: allow read-ahead with
> IOCB_NOWAIT set" ...
It probably should have... Oh well, it's been queued up multiple weeks
at this point, not worth rebasing to move this hunk.
--
Jens Axboe
next prev parent reply other threads:[~2020-07-07 14:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 14:43 Jens Axboe
2020-06-18 14:43 ` [PATCH 01/15] block: provide plug based way of signaling forced no-wait semantics Jens Axboe
2020-06-18 14:43 ` [PATCH 02/15] io_uring: always plug for any number of IOs Jens Axboe
2020-06-18 14:43 ` [PATCH 03/15] io_uring: catch -EIO from buffered issue request failure Jens Axboe
2020-06-18 14:43 ` [PATCH 04/15] io_uring: re-issue block requests that failed because of resources Jens Axboe
2020-06-19 14:12 ` Pavel Begunkov
2020-06-19 14:22 ` Jens Axboe
2020-06-19 14:30 ` Pavel Begunkov
2020-06-19 14:36 ` Jens Axboe
2020-06-18 14:43 ` [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set Jens Axboe
2020-06-24 1:02 ` Dave Chinner
2020-06-24 1:46 ` Matthew Wilcox
2020-06-24 15:00 ` Jens Axboe
2020-06-24 15:35 ` Jens Axboe
2020-06-24 16:41 ` Matthew Wilcox
2020-06-24 16:44 ` Jens Axboe
2020-07-07 11:38 ` Andreas Grünbacher
2020-07-07 14:31 ` Jens Axboe
2020-08-10 22:56 ` Dave Chinner
2020-08-10 23:03 ` Jens Axboe
2020-06-24 4:38 ` Dave Chinner
2020-06-24 15:01 ` Jens Axboe
2020-06-18 14:43 ` [PATCH 06/15] mm: abstract out wake_page_match() from wake_page_function() Jens Axboe
2020-06-18 14:43 ` [PATCH 07/15] mm: add support for async page locking Jens Axboe
2020-07-07 11:32 ` Andreas Grünbacher
2020-07-07 14:32 ` Jens Axboe [this message]
2020-06-18 14:43 ` [PATCH 08/15] mm: support async buffered reads in generic_file_buffered_read() Jens Axboe
2020-06-18 14:43 ` [PATCH 09/15] fs: add FMODE_BUF_RASYNC Jens Axboe
2020-06-18 14:43 ` [PATCH 10/15] block: flag block devices as supporting IOCB_WAITQ Jens Axboe
2020-06-18 14:43 ` [PATCH 11/15] xfs: flag files as supporting buffered async reads Jens Axboe
2020-06-18 14:43 ` [PATCH 12/15] btrfs: " Jens Axboe
2020-06-19 11:11 ` David Sterba
2020-06-18 14:43 ` [PATCH 13/15] ext4: flag " Jens Axboe
2020-06-18 14:43 ` [PATCH 14/15] mm: add kiocb_wait_page_queue_init() helper Jens Axboe
2020-06-18 14:43 ` [PATCH 15/15] io_uring: support true async buffered reads, if file provides it Jens Axboe
2020-06-23 12:39 ` Pavel Begunkov
2020-06-23 14:38 ` Jens Axboe
2020-06-18 14:45 ` [PATCHSET v7 0/12] Add support for async buffered reads Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eb94b6c-eebd-8c0d-fe29-365df50b8949@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=andreas.gruenbacher@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).