* [PATCH] writeback: remove the unused function parameter
@ 2017-11-03 3:44 Wang Long
2017-11-04 11:41 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Wang Long @ 2017-11-03 3:44 UTC (permalink / raw)
To: jack, tj, akpm, gregkh
Cc: axboe, nborisov, hannes, vdavydov.dev, jlayton, linux-kernel, linux-mm
Signed-off-by: Wang Long <wanglong19@meituan.com>
---
include/linux/backing-dev.h | 2 +-
mm/page-writeback.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index 1662157..186a2e7 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -95,7 +95,7 @@ static inline s64 wb_stat_sum(struct bdi_writeback *wb, enum wb_stat_item item)
/*
* maximal error of a stat counter.
*/
-static inline unsigned long wb_stat_error(struct bdi_writeback *wb)
+static inline unsigned long wb_stat_error(void)
{
#ifdef CONFIG_SMP
return nr_cpu_ids * WB_STAT_BATCH;
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 0b9c5cb..9287466 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1543,7 +1543,7 @@ static inline void wb_dirty_limits(struct dirty_throttle_control *dtc)
* actually dirty; with m+n sitting in the percpu
* deltas.
*/
- if (dtc->wb_thresh < 2 * wb_stat_error(wb)) {
+ if (dtc->wb_thresh < 2 * wb_stat_error()) {
wb_reclaimable = wb_stat_sum(wb, WB_RECLAIMABLE);
dtc->wb_dirty = wb_reclaimable + wb_stat_sum(wb, WB_WRITEBACK);
} else {
@@ -1802,7 +1802,7 @@ static void balance_dirty_pages(struct address_space *mapping,
* more page. However wb_dirty has accounting errors. So use
* the larger and more IO friendly wb_stat_error.
*/
- if (sdtc->wb_dirty <= wb_stat_error(wb))
+ if (sdtc->wb_dirty <= wb_stat_error())
break;
if (fatal_signal_pending(current))
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] writeback: remove the unused function parameter
2017-11-03 3:44 [PATCH] writeback: remove the unused function parameter Wang Long
@ 2017-11-04 11:41 ` Greg KH
2017-11-04 12:43 ` [PATCH] writeback: remove the unused function parameter 【外域邮件.谨慎查阅】 wanglong
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2017-11-04 11:41 UTC (permalink / raw)
To: Wang Long
Cc: jack, tj, akpm, axboe, nborisov, hannes, vdavydov.dev, jlayton,
linux-kernel, linux-mm
On Thu, Nov 02, 2017 at 11:44:32PM -0400, Wang Long wrote:
> Signed-off-by: Wang Long <wanglong19@meituan.com>
> ---
I know I don't take patches without any changelog text :(
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] writeback: remove the unused function parameter 【外域邮件.谨慎查阅】
2017-11-04 11:41 ` Greg KH
@ 2017-11-04 12:43 ` wanglong
0 siblings, 0 replies; 3+ messages in thread
From: wanglong @ 2017-11-04 12:43 UTC (permalink / raw)
To: gregkh
Cc: jack, tj, akpm, axboe, nborisov, hannes, vdavydov.dev, jlayton,
linux-kernel, linux-mm
> On 4 Nov 2017, at 7:41 PM, gregkh@linuxfoundation.org wrote:
>
> On Thu, Nov 02, 2017 at 11:44:32PM -0400, Wang Long wrote:
>> Signed-off-by: Wang Long <wanglong19@meituan.com>
>> ---
>
> I know I don't take patches without any changelog text :(
>
I will add some changelog and send v2 patch. thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-04 12:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 3:44 [PATCH] writeback: remove the unused function parameter Wang Long
2017-11-04 11:41 ` Greg KH
2017-11-04 12:43 ` [PATCH] writeback: remove the unused function parameter 【外域邮件.谨慎查阅】 wanglong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).