From: George Kennedy <george.kennedy@oracle.com>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Andrey Konovalov <andreyknvl@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Will Deacon <will.deacon@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Peter Collingbourne <pcc@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Christoph Hellwig <hch@infradead.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Dhaval Giani <dhaval.giani@oracle.com>
Subject: Re: [PATCH] mm, kasan: don't poison boot memory
Date: Tue, 23 Feb 2021 16:46:28 -0500 [thread overview]
Message-ID: <450a9895-a2b4-d11b-97ca-1bd33d5308d4@oracle.com> (raw)
In-Reply-To: <20210223213237.GI1741768@linux.ibm.com>
On 2/23/2021 4:32 PM, Mike Rapoport wrote:
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 7bdc0239a943..c118dd54a747 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -1551,6 +1551,7 @@ void __init acpi_boot_table_init(void)
> if (acpi_disabled)
> return;
>
> +#if 0
> /*
> * Initialize the ACPI boot-time table parser.
> */
> @@ -1558,6 +1559,7 @@ void __init acpi_boot_table_init(void)
> disable_acpi();
> return;
> }
> +#endif
>
> acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf);
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index d883176ef2ce..c8a07a7b9577 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -1032,6 +1032,14 @@ void __init setup_arch(char **cmdline_p)
> */
> find_smp_config();
>
> + /*
> + * Initialize the ACPI boot-time table parser.
> + */
> + if (acpi_table_init()) {
> + disable_acpi();
> + return;
> + }
> +
> reserve_ibft_region();
>
> early_alloc_pgt_buf();
> diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c
> index 64bb94523281..1be7481d5c69 100644
> --- a/drivers/firmware/iscsi_ibft_find.c
> +++ b/drivers/firmware/iscsi_ibft_find.c
> @@ -80,6 +80,27 @@ static int __init find_ibft_in_mem(void)
> done:
> return len;
> }
> +
> +static void __init acpi_find_ibft_region(unsigned long *sizep)
> +{
> + int i;
> + struct acpi_table_header *table = NULL;
> + acpi_status status;
> +
> + if (acpi_disabled)
> + return;
> +
> + for (i = 0; i < ARRAY_SIZE(ibft_signs) && !ibft_addr; i++) {
> + status = acpi_get_table(ibft_signs[i].sign, 0, &table);
> + if (ACPI_SUCCESS(status)) {
> + ibft_addr = (struct acpi_table_ibft *)table;
> + *sizep = PAGE_ALIGN(ibft_addr->header.length);
> + acpi_put_table(table);
> + break;
> + }
> + }
> +}
> +
> /*
> * Routine used to find the iSCSI Boot Format Table. The logical
> * kernel address is set in the ibft_addr global variable.
> @@ -91,14 +112,16 @@ unsigned long __init find_ibft_region(unsigned long *sizep)
> /* iBFT 1.03 section 1.4.3.1 mandates that UEFI machines will
> * only use ACPI for this */
>
> - if (!efi_enabled(EFI_BOOT))
> + if (!efi_enabled(EFI_BOOT)) {
> find_ibft_in_mem();
> -
> - if (ibft_addr) {
> *sizep = PAGE_ALIGN(ibft_addr->header.length);
> - return (u64)virt_to_phys(ibft_addr);
> + } else {
> + acpi_find_ibft_region(sizep);
> }
>
> + if (ibft_addr)
> + return (u64)virt_to_phys(ibft_addr);
> +
> *sizep = 0;
> return 0;
> }
>
Mike,
Still no luck.
[ 30.193723] iscsi: registered transport (iser)
[ 30.195970] iBFT detected.
[ 30.196571] BUG: unable to handle page fault for address:
ffffffffff240004
[ 30.196824] #PF: supervisor read access in kernel mode
[ 30.196824] #PF: error_code(0x0000) - not-present page
[ 30.196824] PGD 24e34067 P4D 24e34067 PUD 24e36067 PMD 27a0e067 PTE 0
[ 30.196824] Oops: 0000 [#1] SMP KASAN PTI
[ 30.196824] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 5.11.0-f9593a0 #10
[ 30.196824] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 0.0.0 02/06/2015
[ 30.196824] RIP: 0010:ibft_init+0x13d/0xc33
[ 30.196824] Code: c1 40 84 ce 75 11 83 e0 07 38 c2 0f 9e c1 84 d2 0f
95 c0 84 c1 74 0a be 04 00 00 00 e8 77 f2 5f ef 49 8d 7f 08 b8 ff ff 37
00 <4d> 63 6f 04 48 89 fa 48 c1 e0 2a 48 c1 ea 03 8a 04 02 48 89 fa 83
[ 30.196824] RSP: 0000:ffff888100fafc30 EFLAGS: 00010246
[ 30.196824] RAX: 000000000037ffff RBX: ffffffff937c6fc0 RCX:
ffffffff815fcf01
[ 30.196824] RDX: dffffc0000000000 RSI: 0000000000000001 RDI:
ffffffffff240008
[ 30.196824] RBP: ffff888100fafcf8 R08: ffffed10201f5f12 R09:
ffffed10201f5f12
[ 30.196824] R10: ffff888100faf88f R11: ffffed10201f5f11 R12:
dffffc0000000000
[ 30.196824] R13: ffff888100fafdc0 R14: ffff888100fafcd0 R15:
ffffffffff240000
[ 30.196824] FS: 0000000000000000(0000) GS:ffff88810ad80000(0000)
knlGS:0000000000000000
[ 30.196824] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 30.196824] CR2: ffffffffff240004 CR3: 0000000024e30000 CR4:
00000000000006e0
[ 30.196824] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
0000000000000000
[ 30.196824] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
0000000000000400
[ 30.196824] Call Trace:
[ 30.196824] ? write_comp_data+0x2f/0x90
[ 30.196824] ? __sanitizer_cov_trace_pc+0x21/0x50
[ 30.196824] ? ibft_check_initiator_for+0x159/0x159
[ 30.196824] ? dmi_setup+0x46c/0x46c
[ 30.196824] ? write_comp_data+0x2f/0x90
[ 30.196824] ? ibft_check_initiator_for+0x159/0x159
[ 30.196824] do_one_initcall+0xc4/0x3e0
[ 30.196824] ? perf_trace_initcall_level+0x3e0/0x3e0
[ 30.196824] ? asm_sysvec_error_interrupt+0x10/0x20
[ 30.196824] ? do_one_initcall+0x18c/0x3e0
[ 30.196824] kernel_init_freeable+0x596/0x652
[ 30.196824] ? console_on_rootfs+0x7d/0x7d
[ 30.196824] ? __sanitizer_cov_trace_pc+0x21/0x50
[ 30.196824] ? rest_init+0xf0/0xf0
[ 30.196824] kernel_init+0x16/0x1d0
[ 30.196824] ? rest_init+0xf0/0xf0
[ 30.196824] ret_from_fork+0x22/0x30
[ 30.196824] Modules linked in:
[ 30.196824] Dumping ftrace buffer:
[ 30.196824] (ftrace buffer empty)
[ 30.196824] CR2: ffffffffff240004
[ 30.196824] ---[ end trace 293eae51adac1398 ]---
[ 30.196824] RIP: 0010:ibft_init+0x13d/0xc33
[ 30.196824] Code: c1 40 84 ce 75 11 83 e0 07 38 c2 0f 9e c1 84 d2 0f
95 c0 84 c1 74 0a be 04 00 00 00 e8 77 f2 5f ef 49 8d 7f 08 b8 ff ff 37
00 <4d> 63 6f 04 48 89 fa 48 c1 e0 2a 48 c1 ea 03 8a 04 02 48 89 fa 83
[ 30.196824] RSP: 0000:ffff888100fafc30 EFLAGS: 00010246
[ 30.196824] RAX: 000000000037ffff RBX: ffffffff937c6fc0 RCX:
ffffffff815fcf01
[ 30.196824] RDX: dffffc0000000000 RSI: 0000000000000001 RDI:
ffffffffff240008
[ 30.196824] RBP: ffff888100fafcf8 R08: ffffed10201f5f12 R09:
ffffed10201f5f12
[ 30.196824] R10: ffff888100faf88f R11: ffffed10201f5f11 R12:
dffffc0000000000
[ 30.196824] R13: ffff888100fafdc0 R14: ffff888100fafcd0 R15:
ffffffffff240000
[ 30.196824] FS: 0000000000000000(0000) GS:ffff88810ad80000(0000)
knlGS:0000000000000000
[ 30.196824] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 30.196824] CR2: ffffffffff240004 CR3: 0000000024e30000 CR4:
00000000000006e0
[ 30.196824] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
0000000000000000
[ 30.196824] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:
0000000000000400
[ 30.196824] Kernel panic - not syncing: Fatal exception
[ 30.196824] Dumping ftrace buffer:
[ 30.196824] (ftrace buffer empty)
[ 30.196824] Kernel Offset: disabled
[ 30.196824] Rebooting in 1 seconds..
George
next prev parent reply other threads:[~2021-02-23 21:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 20:56 [PATCH] mm, kasan: don't poison boot memory Andrey Konovalov
2021-02-18 8:55 ` David Hildenbrand
2021-02-18 19:40 ` Andrey Konovalov
2021-02-18 19:46 ` David Hildenbrand
2021-02-18 20:26 ` Andrey Konovalov
2021-02-19 0:06 ` George Kennedy
2021-02-19 0:09 ` Andrey Konovalov
2021-02-19 16:45 ` George Kennedy
2021-02-19 23:04 ` George Kennedy
2021-02-22 9:52 ` David Hildenbrand
2021-02-22 15:13 ` George Kennedy
2021-02-22 16:13 ` David Hildenbrand
2021-02-22 16:39 ` David Hildenbrand
2021-02-22 17:40 ` Konrad Rzeszutek Wilk
2021-02-22 18:45 ` Mike Rapoport
2021-02-22 18:42 ` George Kennedy
2021-02-22 21:55 ` Mike Rapoport
[not found] ` <9773282a-2854-25a4-9faa-9da5dd34e371@oracle.com>
2021-02-23 10:33 ` Mike Rapoport
[not found] ` <3ef9892f-d657-207f-d4cf-111f98dcb55c@oracle.com>
2021-02-23 15:47 ` Mike Rapoport
2021-02-23 18:05 ` George Kennedy
2021-02-23 20:09 ` Mike Rapoport
2021-02-23 21:16 ` George Kennedy
2021-02-23 21:32 ` Mike Rapoport
2021-02-23 21:46 ` George Kennedy [this message]
2021-02-24 10:37 ` Mike Rapoport
2021-02-24 14:22 ` George Kennedy
2021-02-25 8:53 ` Mike Rapoport
2021-02-25 12:38 ` George Kennedy
2021-02-25 14:57 ` Mike Rapoport
2021-02-25 15:22 ` George Kennedy
2021-02-25 16:06 ` George Kennedy
2021-02-25 16:07 ` Mike Rapoport
2021-02-25 16:31 ` George Kennedy
2021-02-25 17:23 ` David Hildenbrand
2021-02-25 17:41 ` Mike Rapoport
2021-02-25 17:50 ` Mike Rapoport
2021-02-25 17:33 ` George Kennedy
2021-02-26 1:19 ` George Kennedy
2021-02-26 11:17 ` Mike Rapoport
2021-02-26 16:16 ` George Kennedy
2021-02-28 18:08 ` Mike Rapoport
2021-03-01 14:29 ` George Kennedy
2021-03-02 1:20 ` George Kennedy
2021-03-02 9:57 ` Mike Rapoport
2021-02-23 21:26 ` George Kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450a9895-a2b4-d11b-97ca-1bd33d5308d4@oracle.com \
--to=george.kennedy@oracle.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=dhaval.giani@oracle.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=hch@infradead.org \
--cc=kasan-dev@googlegroups.com \
--cc=kevin.brodsky@arm.com \
--cc=konrad@darnok.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pcc@google.com \
--cc=rppt@linux.ibm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).