From: Vlastimil Babka <vbabka@suse.cz>
To: Rik van Riel <riel@surriel.com>,
linux-kernel@vger.kernel.org, riel@fb.com
Cc: kernel-team@fb.com, akpm@linux-foundation.org,
linux-mm@kvack.org, mhocko@kernel.org,
mgorman@techsingularity.net, rientjes@google.com,
aarcange@redhat.com
Subject: Re: [PATCH 1/2] mm,compaction,cma: add alloc_contig flag to compact_control
Date: Mon, 24 Feb 2020 16:04:27 +0100 [thread overview]
Message-ID: <49d4dec8-d908-80f3-d24c-6ab155aa3daf@suse.cz> (raw)
In-Reply-To: <c21c46cb76de2d991fd23164489f763bb385c152.1582321645.git.riel@surriel.com>
On 2/21/20 10:53 PM, Rik van Riel wrote:
> Add information to struct compact_control to indicate that the allocator
> would really like to clear out this specific part of memory, used by for
> example CMA.
>
> Signed-off-by: Rik van Riel <riel@surriel.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Could have been just squashed into patch 2, but no strong feelings.
> ---
> mm/internal.h | 1 +
> mm/page_alloc.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/mm/internal.h b/mm/internal.h
> index 3cf20ab3ca01..78492d9815b4 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -206,6 +206,7 @@ struct compact_control {
> bool whole_zone; /* Whole zone should/has been scanned */
> bool contended; /* Signal lock or sched contention */
> bool rescan; /* Rescanning the same pageblock */
> + bool alloc_contig; /* alloc_contig_range allocation */
> };
>
> /*
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 3c4eb750a199..a36736812596 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -8402,6 +8402,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
> .ignore_skip_hint = true,
> .no_set_skip_hint = true,
> .gfp_mask = current_gfp_context(gfp_mask),
> + .alloc_contig = true,
> };
> INIT_LIST_HEAD(&cc.migratepages);
>
>
next prev parent reply other threads:[~2020-02-24 15:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:53 [PATCH 0/2] fix THP migration for CMA allocations Rik van Riel
2020-02-21 21:53 ` [PATCH 1/2] mm,compaction,cma: add alloc_contig flag to compact_control Rik van Riel
2020-02-24 15:04 ` Vlastimil Babka [this message]
2020-02-21 21:53 ` [PATCH 2/2] mm,thp,compaction,cma: allow THP migration for CMA allocations Rik van Riel
2020-02-21 22:31 ` Zi Yan
2020-02-21 22:35 ` Rik van Riel
2020-02-24 15:29 ` Vlastimil Babka
2020-02-25 18:44 ` Rik van Riel
2020-02-26 9:48 ` Vlastimil Babka
2020-02-26 17:53 ` Rik van Riel
2020-02-28 15:17 ` Vlastimil Babka
2020-03-01 2:24 ` Rik van Riel
2020-02-27 21:32 [PATCH v2 0/2] fix " Rik van Riel
2020-02-27 21:32 ` [PATCH 1/2] mm,compaction,cma: add alloc_contig flag to compact_control Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49d4dec8-d908-80f3-d24c-6ab155aa3daf@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=riel@fb.com \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).