From: Rik van Riel <riel@surriel.com>
To: Zi Yan <ziy@nvidia.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
mhocko@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net,
rientjes@google.com, aarcange@redhat.com
Subject: Re: [PATCH 2/2] mm,thp,compaction,cma: allow THP migration for CMA allocations
Date: Fri, 21 Feb 2020 17:35:15 -0500 [thread overview]
Message-ID: <67d927c6161b15664b4a912ad34fc3a147109760.camel@surriel.com> (raw)
In-Reply-To: <FF5B51C0-8D6E-47AB-82C8-020D5C522502@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]
On Fri, 2020-02-21 at 17:31 -0500, Zi Yan wrote:
> On 21 Feb 2020, at 16:53, Rik van Riel wrote:
>
> > +++ b/mm/compaction.c
> > @@ -894,12 +894,12 @@ isolate_migratepages_block(struct
> > compact_control *cc, unsigned long low_pfn,
> >
> > /*
> > * Regardless of being on LRU, compound pages such as
> > THP and
> > - * hugetlbfs are not to be compacted. We can
> > potentially save
> > - * a lot of iterations if we skip them at once. The
> > check is
> > - * racy, but we can consider only valid values and the
> > only
> > - * danger is skipping too much.
> > + * hugetlbfs are not to be compacted most of the time.
> > We can
> > + * potentially save a lot of iterations if we skip them
> > at
> > + * once. The check is racy, but we can consider only
> > valid
> > + * values and the only danger is skipping too much.
> > */
>
> Maybe add “we do want to move them when allocating contiguous memory
> using CMA” to help
> people understand the context of using cc->alloc_contig?
I can certainly do that.
I'll wait for feedback from other people to see if
more changes are wanted, and plan to post v2 by
Tuesday or so :)
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-21 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:53 [PATCH 0/2] fix THP migration for CMA allocations Rik van Riel
2020-02-21 21:53 ` [PATCH 1/2] mm,compaction,cma: add alloc_contig flag to compact_control Rik van Riel
2020-02-24 15:04 ` Vlastimil Babka
2020-02-21 21:53 ` [PATCH 2/2] mm,thp,compaction,cma: allow THP migration for CMA allocations Rik van Riel
2020-02-21 22:31 ` Zi Yan
2020-02-21 22:35 ` Rik van Riel [this message]
2020-02-24 15:29 ` Vlastimil Babka
2020-02-25 18:44 ` Rik van Riel
2020-02-26 9:48 ` Vlastimil Babka
2020-02-26 17:53 ` Rik van Riel
2020-02-28 15:17 ` Vlastimil Babka
2020-03-01 2:24 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d927c6161b15664b4a912ad34fc3a147109760.camel@surriel.com \
--to=riel@surriel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).