From: Wei Wang <wei.w.wang@intel.com>
To: Dave Hansen <dave.hansen@intel.com>,
virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com,
david@redhat.com, cornelia.huck@de.ibm.com,
akpm@linux-foundation.org, mgorman@techsingularity.net,
aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com,
liliang.opensource@gmail.com
Subject: Re: [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ
Date: Tue, 13 Jun 2017 18:17:32 +0800 [thread overview]
Message-ID: <593FBBBC.3060603@intel.com> (raw)
In-Reply-To: <db8cc3d1-50fc-2412-af2f-1070dda38be3@intel.com>
On 06/12/2017 10:07 PM, Dave Hansen wrote:
> On 06/09/2017 03:41 AM, Wei Wang wrote:
>> + for_each_populated_zone(zone) {
>> + for (order = MAX_ORDER - 1; order > 0; order--) {
>> + for (migratetype = 0; migratetype < MIGRATE_TYPES;
>> + migratetype++) {
>> + do {
>> + ret = report_unused_page_block(zone,
>> + order, migratetype, &page);
>> + if (!ret) {
>> + pfn = (u64)page_to_pfn(page);
>> + add_one_chunk(vb, vq,
>> + PAGE_CHNUK_UNUSED_PAGE,
>> + pfn << VIRTIO_BALLOON_PFN_SHIFT,
>> + (u64)(1 << order) *
>> + VIRTIO_BALLOON_PAGES_PER_PAGE);
>> + }
>> + } while (!ret);
>> + }
>> + }
>> + }
> This is pretty unreadable. Please add some indentation. If you go
> over 80 cols, then you might need to break this up into a separate
> function. But, either way, it can't be left like this.
OK, I'll re-arrange it.
Best,
Wei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-13 10:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:41 [PATCH v11 0/6] Virtio-balloon Enhancement Wei Wang
2017-06-09 10:41 ` [PATCH v11 1/6] virtio-balloon: deflate via a page list Wei Wang
2017-06-09 10:41 ` [PATCH v11 2/6] virtio-balloon: coding format cleanup Wei Wang
2017-06-09 10:41 ` [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS Wei Wang
2017-06-13 17:56 ` Michael S. Tsirkin
2017-06-13 17:59 ` Dave Hansen
2017-06-13 18:55 ` Michael S. Tsirkin
2017-06-15 8:10 ` [virtio-dev] " Wei Wang
2017-06-16 3:19 ` Michael S. Tsirkin
2017-06-28 15:04 ` Matthew Wilcox
2017-07-12 13:05 ` Wei Wang
2017-06-09 10:41 ` [PATCH v11 4/6] mm: function to offer a page block on the free list Wei Wang
2017-06-12 14:10 ` Dave Hansen
2017-06-12 16:28 ` Michael S. Tsirkin
2017-06-12 16:42 ` Dave Hansen
2017-06-12 20:34 ` Michael S. Tsirkin
2017-06-12 20:54 ` Dave Hansen
2017-06-13 2:56 ` Wei Wang
2017-06-20 16:44 ` Rik van Riel
2017-06-20 16:49 ` David Hildenbrand
2017-06-20 17:29 ` Rik van Riel
2017-06-20 18:26 ` Michael S. Tsirkin
2017-06-20 19:51 ` Rik van Riel
2017-06-21 12:41 ` Michael S. Tsirkin
2017-06-21 8:38 ` [Qemu-devel] " Wei Wang
2017-06-20 18:17 ` Michael S. Tsirkin
2017-06-20 18:54 ` David Hildenbrand
2017-06-20 18:56 ` Michael S. Tsirkin
2017-06-20 19:01 ` David Hildenbrand
2017-06-21 12:56 ` Christian Borntraeger
2017-06-21 13:47 ` David Hildenbrand
2017-06-09 10:41 ` [PATCH v11 5/6] mm: export symbol of next_zone and first_online_pgdat Wei Wang
2017-06-09 10:41 ` [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ Wei Wang
2017-06-12 14:07 ` Dave Hansen
2017-06-13 10:17 ` Wei Wang [this message]
2017-06-20 16:18 ` Michael S. Tsirkin
2017-06-21 3:28 ` [virtio-dev] " Wei Wang
2017-06-21 12:28 ` Michael S. Tsirkin
2017-06-22 8:40 ` Wei Wang
2017-06-28 15:01 ` Michael S. Tsirkin
2017-07-12 12:57 ` Wei Wang
2017-06-09 11:18 ` [PATCH v11 0/6] Virtio-balloon Enhancement Wang, Wei W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593FBBBC.3060603@intel.com \
--to=wei.w.wang@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).