From: Tim Chen <tim.c.chen@linux.intel.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Cc: Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 0/2] Increase the size of LRU pagevecs
Date: Thu, 5 Nov 2020 16:51:10 -0800 [thread overview]
Message-ID: <6e91d4c1-d1fc-63ad-4ca5-261ad89d50e4@linux.intel.com> (raw)
In-Reply-To: <20201105172651.2455-1-willy@infradead.org>
On 11/5/20 9:26 AM, Matthew Wilcox (Oracle) wrote:
> This attempts to address some of the criticisms of Tim's original
> patch back in June:
>
> https://lore.kernel.org/linux-mm/d1cc9f12a8ad6c2a52cb600d93b06b064f2bbc57.1593205965.git.tim.c.chen@linux.intel.com/
>
> I don't love how messy this is.
I actually attempted a similar patch to allocate different sizes
for pagevec. But it is so ugly that
I didn't try to post it. This version looks much better than mine.
Tim
> Better suggestions (dynamic allocation of
> pagevecs?) welcome. It'd be even better if we could measure contention
> and resize the LRUvecs on demand.
>
> I do intend to add pagevec_alloc() and pagevec_free(), but that's to
> solve a different problem.
>
> Matthew Wilcox (Oracle) (2):
> pagevec: Allow pagevecs to be different sizes
> pagevec: Increase the size of LRU pagevecs
>
> include/linux/pagevec.h | 25 +++++++++++++++++++++----
> mm/swap.c | 23 +++++++++++++++++------
> 2 files changed, 38 insertions(+), 10 deletions(-)
>
prev parent reply other threads:[~2020-11-06 0:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 17:26 [PATCH 0/2] Increase the size of LRU pagevecs Matthew Wilcox (Oracle)
2020-11-05 17:26 ` [PATCH 1/2] pagevec: Allow pagevecs to be different sizes Matthew Wilcox (Oracle)
2020-11-06 17:17 ` Tim Chen
2020-11-06 19:12 ` Matthew Wilcox
2020-11-06 22:18 ` Tim Chen
2020-11-07 1:21 ` Matthew Wilcox
2020-11-05 17:26 ` [PATCH 2/2] pagevec: Increase the size of LRU pagevecs Matthew Wilcox (Oracle)
2020-11-06 0:51 ` Tim Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e91d4c1-d1fc-63ad-4ca5-261ad89d50e4@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).