* Re: [PATCH] mm/ksm: Fix a null pointer dereference
@ 2020-04-14 7:14 Markus Elfring
2020-04-14 7:19 ` [External] " Muchun Song
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-04-14 7:14 UTC (permalink / raw)
To: Muchun Song, Xiongchun duan, linux-mm; +Cc: linux-kernel, Andrew Morton
> The find_mergeable_vma can return NULL. In this case, it leads
> to crash when we access vma->vm_mm(which's offset is 0x40) in
I suggest to improve the commit message.
* Wording alternative:
to a crash when we access vma->vm_mm (its offset is 0x40) in
* Can a function name be nicer than the information “at 0000000000000040”
in the patch subject?
* Would you like to add the tag “Fixes” to the change description?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [External] Re: [PATCH] mm/ksm: Fix a null pointer dereference
2020-04-14 7:14 [PATCH] mm/ksm: Fix a null pointer dereference Markus Elfring
@ 2020-04-14 7:19 ` Muchun Song
0 siblings, 0 replies; 2+ messages in thread
From: Muchun Song @ 2020-04-14 7:19 UTC (permalink / raw)
To: Markus Elfring; +Cc: Xiongchun duan, linux-mm, linux-kernel, Andrew Morton
On Tue, Apr 14, 2020 at 3:14 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > The find_mergeable_vma can return NULL. In this case, it leads
> > to crash when we access vma->vm_mm(which's offset is 0x40) in
>
> I suggest to improve the commit message.
>
> * Wording alternative:
> to a crash when we access vma->vm_mm (its offset is 0x40) in
>
> * Can a function name be nicer than the information “at 0000000000000040”
> in the patch subject?
>
> * Would you like to add the tag “Fixes” to the change description?
>
Thanks for your suggestion. I will send a v2 patch later.
--
Yours,
Muchun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-14 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 7:14 [PATCH] mm/ksm: Fix a null pointer dereference Markus Elfring
2020-04-14 7:19 ` [External] " Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).