From: David Hildenbrand <david@redhat.com>
To: Qian Cai <cai@lca.pw>
Cc: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn
Date: Wed, 27 Nov 2019 20:52:40 +0100 [thread overview]
Message-ID: <7D8F1E5C-5A39-4C76-AD2F-4D0954DB57F5@redhat.com> (raw)
In-Reply-To: <CE5C4BD6-FAA6-4439-B869-679D24C17298@lca.pw>
> Am 27.11.2019 um 20:37 schrieb Qian Cai <cai@lca.pw>:
>
>
>
>> On Nov 27, 2019, at 2:06 PM, David Hildenbrand <david@redhat.com> wrote:
>>
>> The zone pointer is unique for every node. (in contrast to the zone index).
>
> I am not sure if it is worth optimizing there. The existing nid check looks quite straight-forward and cheap.
I understand but strongly dislike your attitude towards code changes ;)
>
next prev parent reply other threads:[~2019-11-27 19:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 17:41 [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn David Hildenbrand
2019-11-27 19:03 ` Qian Cai
2019-11-27 19:05 ` David Hildenbrand
2019-11-27 19:37 ` Qian Cai
2019-11-27 19:52 ` David Hildenbrand [this message]
2019-11-27 20:49 ` David Hildenbrand
2019-11-27 22:56 ` Qian Cai
2019-11-28 8:46 ` David Hildenbrand
2019-11-28 13:56 ` Qian Cai
2019-11-28 14:03 ` David Hildenbrand
2019-11-28 14:30 ` Qian Cai
2019-11-28 14:42 ` Michal Hocko
2019-11-28 14:52 ` David Hildenbrand
2019-11-28 15:29 ` Qian Cai
2019-11-28 15:31 ` David Hildenbrand
2019-11-28 17:31 ` Qian Cai
2019-11-28 15:46 ` Michal Hocko
2019-11-28 17:22 ` Qian Cai
2019-11-28 10:15 ` Michal Hocko
2019-11-28 13:52 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7D8F1E5C-5A39-4C76-AD2F-4D0954DB57F5@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).