From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Zi Yan <ziy@nvidia.com>, Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH 4/7] migrate_pages(): fix failure counting for THP subpages retrying
Date: Mon, 27 Jun 2022 13:56:57 +0800 [thread overview]
Message-ID: <7b98cabf-9a8f-2dcb-a410-9a8f9611ae88@linux.alibaba.com> (raw)
In-Reply-To: <87r13a7n04.fsf@yhuang6-desk2.ccr.corp.intel.com>
On 6/27/2022 12:23 PM, Huang, Ying wrote:
> Baolin Wang <baolin.wang@linux.alibaba.com> writes:
>
>> On 6/27/2022 9:46 AM, Huang, Ying wrote:
>>> Baolin Wang <baolin.wang@linux.alibaba.com> writes:
>>>
>>>> On 6/24/2022 10:53 AM, Huang Ying wrote:
>>>>> If THP is failed to be migrated for -ENOSYS and -ENOMEM, the THP will
>>>>> be split into thp_split_pages, and after other pages are migrated,
>>>>> pages in thp_split_pages will be migrated with no_subpage_counting ==
>>>>> true, because its failure have been counted already. If some pages in
>>>>> thp_split_pages are retried during migration, we should not count
>>>>> their failure if no_subpage_counting == true too. This is done this
>>>>> patch to fix the failure counting for THP subpages retrying.
>>>>
>>>> Good catch. Totally agree with you. It seems we can move the condition
>>>> into -EAGAIN case like other cases did?
>>>>
>>>> diff --git a/mm/migrate.c b/mm/migrate.c
>>>> index 1ece23d80bc4..491c2d07402b 100644
>>>> --- a/mm/migrate.c
>>>> +++ b/mm/migrate.c
>>>> @@ -1463,7 +1463,7 @@ int migrate_pages(struct list_head *from,
>>>> new_page_t get_new_page,
>>>> case -EAGAIN:
>>>> if (is_thp)
>>>> thp_retry++;
>>>> - else
>>>> + else if (!no_subpage_counting)
>>>> retry++;
>>>> break;
>>> This has another effect except fixing the failure counting. That
>>> is,
>>> the split subpages of THP will not be retried for 10 times for -EAGAIN.
>>
>> Ah, yes.
>>
>>> TBH, I think that we should do that. But because this has some behavior
>>
>> OK. So you afraid that 10 times retry for each subpage of THP will
>> waste lots of time?
>
> I just think that it's unnecessary. We have already regarded the
> migration as failed. And for the worst case, we will try 512 * 10 =
> 5120 times in total.
>
>>> change, it's better to be done in a separate patch? Do you have
>>> interest to do that on top of this patchset?
>>
>> Sure. I can send a patch which can be folded into your series. Is this
>> OK for you?
>>
>> By the way, if I do like I said, the patch 4 can be avoided.
>
> I tend to keep both. [4/7] is just a fix. You patch will introduce the
> behavior change. And your patch needn't to be folded into this series.
> You can send it and push it separately.
OK. Thanks.
next prev parent reply other threads:[~2022-06-27 5:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 2:53 [PATCH 0/7] migrate_pages(): fix several bugs in error path Huang Ying
2022-06-24 2:53 ` [PATCH 1/7] migrate: fix syscall move_pages() return value for failure Huang Ying
2022-06-24 2:53 ` [PATCH 2/7] migrate_pages(): remove unnecessary list_safe_reset_next() Huang Ying
2022-06-24 9:22 ` Baolin Wang
2022-06-24 2:53 ` [PATCH 3/7] migrate_pages(): fix THP failure counting for -ENOMEM Huang Ying
2022-06-24 9:36 ` Baolin Wang
2022-06-24 2:53 ` [PATCH 4/7] migrate_pages(): fix failure counting for THP subpages retrying Huang Ying
2022-06-24 9:45 ` Baolin Wang
2022-06-27 1:46 ` Huang, Ying
2022-06-27 3:59 ` Baolin Wang
2022-06-27 4:23 ` Huang, Ying
2022-06-27 5:56 ` Baolin Wang [this message]
2022-06-24 2:53 ` [PATCH 5/7] migrate_pages(): fix failure counting for THP on -ENOSYS Huang Ying
2022-06-24 9:51 ` Baolin Wang
2022-06-24 10:11 ` [PATCH 0/7] migrate_pages(): fix several bugs in error path Baolin Wang
2022-06-27 2:30 ` Huang, Ying
2022-06-27 2:24 ` [PATCH 6/7] migrate_pages(): fix failure counting for THP splitting Huang Ying
2022-06-27 4:24 ` Baolin Wang
2022-06-27 2:25 ` [PATCH 7/7] migrate_pages(): fix failure counting for retry Huang Ying
2022-06-27 4:29 ` Baolin Wang
2022-06-27 6:21 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b98cabf-9a8f-2dcb-a410-9a8f9611ae88@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).