From: "Huang, Ying" <ying.huang@intel.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <shy828301@gmail.com>, <ziy@nvidia.com>
Subject: Re: [PATCH 7/7] migrate_pages(): fix failure counting for retry
Date: Mon, 27 Jun 2022 14:21:31 +0800 [thread overview]
Message-ID: <87mtdy7hjo.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <5b40e07d-7ed3-7eba-ea71-52e5a06c1ec8@linux.alibaba.com> (Baolin Wang's message of "Mon, 27 Jun 2022 12:29:28 +0800")
Baolin Wang <baolin.wang@linux.alibaba.com> writes:
> On 6/27/2022 10:25 AM, Huang Ying wrote:
>> After 10 retries, we will give up and the remaining pages will be
>> counted as failure in nr_failed and nr_thp_failed. We should count
>> the failure in nr_failed_pages too. This is done in this patch.
>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>> Fixes: 5984fabb6e82 ("mm: move_pages: report the number of non-attempted pages")
>> Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
>> Cc: Zi Yan <ziy@nvidia.com>
>> Cc: Yang Shi <shy828301@gmail.com>
>> ---
>> mm/migrate.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>> diff --git a/mm/migrate.c b/mm/migrate.c
>> index 70a0e1f34c03..e42bd409d3aa 100644
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -1344,6 +1344,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
>> int thp_retry = 1;
>> int nr_failed = 0;
>> int nr_failed_pages = 0;
>> + int nr_retry_pages = 0;
>> int nr_succeeded = 0;
>> int nr_thp_succeeded = 0;
>> int nr_thp_failed = 0;
>> @@ -1364,6 +1365,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
>> for (pass = 0; pass < 10 && (retry || thp_retry); pass++) {
>> retry = 0;
>> thp_retry = 0;
>> + nr_retry_pages = 0;
>> list_for_each_entry_safe(page, page2, from, lru) {
>> /*
>> @@ -1449,12 +1451,14 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
>> nr_thp_failed += thp_retry;
>> if (!no_subpage_counting)
>> nr_failed += retry;
>> + nr_failed_pages += nr_retry_pages;
>
> Can you move this a little forward to update 'nr_failed_pages' in one
> place, which seems more readable?
> nr_failed_pages += nr_subpages + nr_retry_pages;
Sure. Will do this in the next version!
> Otherwise,
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Thanks!
Best Regards,
Huang, Ying
>
>> goto out;
>> case -EAGAIN:
>> if (is_thp)
>> thp_retry++;
>> else
>> retry++;
>> + nr_retry_pages += nr_subpages;
>> break;
>> case MIGRATEPAGE_SUCCESS:
>> nr_succeeded += nr_subpages;
>> @@ -1481,6 +1485,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
>> if (!no_subpage_counting)
>> nr_failed += retry;
>> nr_thp_failed += thp_retry;
>> + nr_failed_pages += nr_retry_pages;
>> /*
>> * Try to migrate subpages of fail-to-migrate THPs, no nr_failed
>> * counting in this round, since all subpages of a THP is counted
prev parent reply other threads:[~2022-06-27 6:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 2:53 [PATCH 0/7] migrate_pages(): fix several bugs in error path Huang Ying
2022-06-24 2:53 ` [PATCH 1/7] migrate: fix syscall move_pages() return value for failure Huang Ying
2022-06-24 2:53 ` [PATCH 2/7] migrate_pages(): remove unnecessary list_safe_reset_next() Huang Ying
2022-06-24 9:22 ` Baolin Wang
2022-06-24 2:53 ` [PATCH 3/7] migrate_pages(): fix THP failure counting for -ENOMEM Huang Ying
2022-06-24 9:36 ` Baolin Wang
2022-06-24 2:53 ` [PATCH 4/7] migrate_pages(): fix failure counting for THP subpages retrying Huang Ying
2022-06-24 9:45 ` Baolin Wang
2022-06-27 1:46 ` Huang, Ying
2022-06-27 3:59 ` Baolin Wang
2022-06-27 4:23 ` Huang, Ying
2022-06-27 5:56 ` Baolin Wang
2022-06-24 2:53 ` [PATCH 5/7] migrate_pages(): fix failure counting for THP on -ENOSYS Huang Ying
2022-06-24 9:51 ` Baolin Wang
2022-06-24 10:11 ` [PATCH 0/7] migrate_pages(): fix several bugs in error path Baolin Wang
2022-06-27 2:30 ` Huang, Ying
2022-06-27 2:24 ` [PATCH 6/7] migrate_pages(): fix failure counting for THP splitting Huang Ying
2022-06-27 4:24 ` Baolin Wang
2022-06-27 2:25 ` [PATCH 7/7] migrate_pages(): fix failure counting for retry Huang Ying
2022-06-27 4:29 ` Baolin Wang
2022-06-27 6:21 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtdy7hjo.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).