linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: zhong jiang <zhongjiang@huawei.com>, akpm@linux-foundation.org
Cc: aryabinin@virtuozzo.com, glider@google.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm/kasan: Fix an compile error
Date: Wed, 04 Dec 2019 10:06:25 +1100	[thread overview]
Message-ID: <87sgm1dn66.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <1575363013-43761-1-git-send-email-zhongjiang@huawei.com>

Hi,

Thanks, I see that Andrew has already picked this up, but for what it's
worth:

Reviewed-by: Daniel Axtens <dja@axtens.net>

Regards,
Daniel

> I hit the following compile error in arch/x86/
>
> mm/kasan/common.c: In function kasan_populate_vmalloc:
> mm/kasan/common.c:797:2: error: implicit declaration of function flush_cache_vmap; did you mean flush_rcu_work? [-Werror=implicit-function-declaration]
>   flush_cache_vmap(shadow_start, shadow_end);
>   ^~~~~~~~~~~~~~~~
>   flush_rcu_work
> cc1: some warnings being treated as errors
> make[2]: *** [mm/kasan/common.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [mm/kasan] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [mm] Error 2
> make: *** Waiting for unfinished jobs....
>
> Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory")
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  mm/kasan/common.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> index df3371d..2fa710b 100644
> --- a/mm/kasan/common.c
> +++ b/mm/kasan/common.c
> @@ -36,6 +36,7 @@
>  #include <linux/bug.h>
>  #include <linux/uaccess.h>
>  
> +#include <asm/cacheflush.h>
>  #include <asm/tlbflush.h>
>  
>  #include "kasan.h"
> -- 
> 1.7.12.4


      reply	other threads:[~2019-12-03 23:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  8:50 [PATCH] mm/kasan: Fix an compile error zhong jiang
2019-12-03 23:06 ` Daniel Axtens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgm1dn66.fsf@dja-thinkpad.axtens.net \
    --to=dja@axtens.net \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=glider@google.com \
    --cc=linux-mm@kvack.org \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).