From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Tian Tao <tiantao6@hisilicon.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: linuxarm@huawei.com
Subject: Re: [PATCH v2] vmalloc: Removing incorrect logs when vmalloc failed
Date: Thu, 9 Jul 2020 09:15:54 +0530 [thread overview]
Message-ID: <9799596a-ac03-2300-dbfb-2244ea706ffd@arm.com> (raw)
In-Reply-To: <1594257288-58269-1-git-send-email-tiantao6@hisilicon.com>
On 07/09/2020 06:44 AM, Tian Tao wrote:
> It is not possible to increase size with vmalloc=<size> in arm64
Small nit. s/in arm64/on arm64/
In fact "vmalloc=<size>" cmdline option is not available on many
platforms. Hence it is not something arm64 specific here, it is
a general problem.
> architecture and it will mislead.however vmalloc return failure
Small nit. s/.however/. However/
> is a rare occurrence in 'many architectures including arm64'.
Please reword the commit message here to describe the problem which
is a generic one, affecting multiple platforms that dont support
"vmalloc=<size>" cmdline option.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>
> v2:
> Add appropriate hints and let users decide if they can increase
> the size of the vmalloc by vmalloc=<size> depending on their platform
> ---
> mm/vmalloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 89e83d3..c6ae7e6 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1238,8 +1238,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
> }
>
> if (!(gfp_mask & __GFP_NOWARN) && printk_ratelimit())
> - pr_warn("vmap allocation for size %lu failed: use vmalloc=<size> to increase size\n",
> - size);
> + pr_warn("vmap allocation for size %lu failed: use vmalloc=<size> to increase size,
> + if your ARCH supports it\n", size);
This looks better.
prev parent reply other threads:[~2020-07-09 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 1:14 [PATCH v2] vmalloc: Removing incorrect logs when vmalloc failed Tian Tao
2020-07-09 3:45 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9799596a-ac03-2300-dbfb-2244ea706ffd@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).