* [PATCH v2] vmalloc: Removing incorrect logs when vmalloc failed
@ 2020-07-09 1:14 Tian Tao
2020-07-09 3:45 ` Anshuman Khandual
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-07-09 1:14 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel; +Cc: linuxarm
It is not possible to increase size with vmalloc=<size> in arm64
architecture and it will mislead.however vmalloc return failure
is a rare occurrence in 'many architectures including arm64'.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
v2:
Add appropriate hints and let users decide if they can increase
the size of the vmalloc by vmalloc=<size> depending on their platform
---
mm/vmalloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 89e83d3..c6ae7e6 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1238,8 +1238,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
}
if (!(gfp_mask & __GFP_NOWARN) && printk_ratelimit())
- pr_warn("vmap allocation for size %lu failed: use vmalloc=<size> to increase size\n",
- size);
+ pr_warn("vmap allocation for size %lu failed: use vmalloc=<size> to increase size,
+ if your ARCH supports it\n", size);
kmem_cache_free(vmap_area_cachep, va);
return ERR_PTR(-EBUSY);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] vmalloc: Removing incorrect logs when vmalloc failed
2020-07-09 1:14 [PATCH v2] vmalloc: Removing incorrect logs when vmalloc failed Tian Tao
@ 2020-07-09 3:45 ` Anshuman Khandual
0 siblings, 0 replies; 2+ messages in thread
From: Anshuman Khandual @ 2020-07-09 3:45 UTC (permalink / raw)
To: Tian Tao, akpm, linux-mm, linux-kernel; +Cc: linuxarm
On 07/09/2020 06:44 AM, Tian Tao wrote:
> It is not possible to increase size with vmalloc=<size> in arm64
Small nit. s/in arm64/on arm64/
In fact "vmalloc=<size>" cmdline option is not available on many
platforms. Hence it is not something arm64 specific here, it is
a general problem.
> architecture and it will mislead.however vmalloc return failure
Small nit. s/.however/. However/
> is a rare occurrence in 'many architectures including arm64'.
Please reword the commit message here to describe the problem which
is a generic one, affecting multiple platforms that dont support
"vmalloc=<size>" cmdline option.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>
> v2:
> Add appropriate hints and let users decide if they can increase
> the size of the vmalloc by vmalloc=<size> depending on their platform
> ---
> mm/vmalloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 89e83d3..c6ae7e6 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1238,8 +1238,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
> }
>
> if (!(gfp_mask & __GFP_NOWARN) && printk_ratelimit())
> - pr_warn("vmap allocation for size %lu failed: use vmalloc=<size> to increase size\n",
> - size);
> + pr_warn("vmap allocation for size %lu failed: use vmalloc=<size> to increase size,
> + if your ARCH supports it\n", size);
This looks better.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-09 3:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 1:14 [PATCH v2] vmalloc: Removing incorrect logs when vmalloc failed Tian Tao
2020-07-09 3:45 ` Anshuman Khandual
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).