From: Jane Chu <jane.chu@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: hwpoison: use do_send_sig_info() instead of force_sig() (Re: PMEM error-handling forces SIGKILL causes kernel panic)
Date: Wed, 16 Jan 2019 09:56:02 -0800 [thread overview]
Message-ID: <97e179e1-8a3a-5acb-78c1-a4b06b33db4c@oracle.com> (raw)
In-Reply-To: <20190116093046.GA29835@hori1.linux.bs1.fc.nec.co.jp>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
Hi, Naoya,
On 1/16/2019 1:30 AM, Naoya Horiguchi wrote:
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 7c72f2a95785..831be5ff5f4d 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -372,7 +372,8 @@ static void kill_procs(struct list_head *to_kill, int forcekill, bool fail,
> if (fail || tk->addr_valid == 0) {
> pr_err("Memory failure: %#lx: forcibly killing %s:%d because of failure to unmap corrupted page\n",
> pfn, tk->tsk->comm, tk->tsk->pid);
> - force_sig(SIGKILL, tk->tsk);
> + do_send_sig_info(SIGKILL, SEND_SIG_PRIV,
> + tk->tsk, PIDTYPE_PID);
> }
>
Since we don't care the return from do_send_sig_info(), would you mind to
prefix it with (void) ?
thanks!
-jane
[-- Attachment #2: Type: text/html, Size: 1163 bytes --]
next prev parent reply other threads:[~2019-01-16 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e3c4c0e0-1434-4353-b893-2973c04e7ff7@oracle.com>
[not found] ` <CAPcyv4j67n6H7hD6haXJqysbaauci4usuuj5c+JQ7VQBGngO1Q@mail.gmail.com>
[not found] ` <20190111081401.GA5080@hori1.linux.bs1.fc.nec.co.jp>
2019-01-16 9:30 ` [PATCH] mm: hwpoison: use do_send_sig_info() instead of force_sig() (Re: PMEM error-handling forces SIGKILL causes kernel panic) Naoya Horiguchi
2019-01-16 9:30 ` Naoya Horiguchi
2019-01-16 16:55 ` Dan Williams
2019-01-16 16:55 ` Dan Williams
2019-01-16 17:20 ` Jane Chu
2019-01-16 17:20 ` Jane Chu
2019-01-16 17:56 ` Jane Chu [this message]
2019-01-16 23:32 ` Naoya Horiguchi
2019-01-17 1:07 ` Jane Chu
2019-01-17 9:44 ` William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e179e1-8a3a-5acb-78c1-a4b06b33db4c@oracle.com \
--to=jane.chu@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).