From: Vlastimil Babka <vbabka@suse.cz>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, Ivan Teterevkov <ivan.teterevkov@nutanix.com>,
Michal Hocko <mhocko@kernel.org>,
David Rientjes <rientjes@google.com>,
Matthew Wilcox <willy@infradead.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
"Guilherme G . Piccoli" <gpiccoli@canonical.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH 3/3] kernel/hung_task convert hung_task_panic boot parameter to sysctl
Date: Wed, 1 Apr 2020 10:47:07 +0200 [thread overview]
Message-ID: <9a11d5c9-b830-040e-219a-64cdb24a9236@suse.cz> (raw)
In-Reply-To: <2ee52caa-0257-19bd-28ef-60a2b4041a8d@I-love.SAKURA.ne.jp>
On 4/1/20 1:12 AM, Tetsuo Handa wrote:
> On 2020/03/30 20:55, Vlastimil Babka wrote:
>> @@ -63,16 +63,6 @@ static struct task_struct *watchdog_task;
>> unsigned int __read_mostly sysctl_hung_task_panic =
>> CONFIG_BOOTPARAM_HUNG_TASK_PANIC_VALUE;
>>
>> -static int __init hung_task_panic_setup(char *str)
>> -{
>> - int rc = kstrtouint(str, 0, &sysctl_hung_task_panic);
>> -
>> - if (rc)
>> - return rc;
>> - return 1;
>> -}
>> -__setup("hung_task_panic=", hung_task_panic_setup);
>
> Can we defer removal of this handler for "one release cycle" (and instead emit a line
> saying that "this parameter will be replaced by ..." during that cycle) ? I welcome
The old parameter is not removed, it's just handled differently, see patch 2.
Both old name and new sysctl.name will work.
> PATCH 1/3, but kernel testing projects (e.g. syzbot) needs to update their settings
> between PATCH 1/3 was merged into linux.git and PATCH 3/3 is merged into linux.git .
>
> https://lkml.kernel.org/r/CACT4Y+YE-j5ncjTGN6UhngfCNRgVo-QDZ3VCBGACdbs9-v+axQ@mail.gmail.com says
> "Announcing unmerged changes is too early (as this patch showed). And once it's in linux-next it's already too late.."
>
>> -
>> static int
>> hung_task_panic(struct notifier_block *this, unsigned long event, void *ptr)
>> {
>>
>
prev parent reply other threads:[~2020-04-01 8:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 11:55 [PATCH 0/3] support setting sysctl parameters from kernel command line Vlastimil Babka
2020-03-30 11:55 ` [PATCH 1/3] kernel/sysctl: " Vlastimil Babka
2020-03-30 16:23 ` Vlastimil Babka
2020-03-30 17:40 ` Kees Cook
2020-03-30 17:39 ` Kees Cook
2020-03-30 22:44 ` Luis Chamberlain
2020-03-31 7:42 ` Vlastimil Babka
2020-03-31 7:48 ` Michal Hocko
2020-03-31 18:26 ` Kees Cook
2020-03-31 14:31 ` Luis Chamberlain
2020-04-01 11:01 ` Vlastimil Babka
2020-04-02 16:04 ` Luis Chamberlain
2020-04-02 17:23 ` Kees Cook
2020-04-02 20:59 ` Luis Chamberlain
2020-04-03 23:57 ` Kees Cook
2020-04-06 14:08 ` Luis Chamberlain
2020-04-06 15:58 ` Kees Cook
2020-04-06 17:08 ` Luis Chamberlain
2020-04-14 11:25 ` Vlastimil Babka
2020-04-15 3:23 ` Masami Hiramatsu
2020-04-15 6:08 ` Luis Chamberlain
2020-03-30 11:55 ` [PATCH 2/3] kernel/sysctl: support handling command line aliases Vlastimil Babka
2020-03-30 17:41 ` Kees Cook
2020-03-31 14:35 ` Luis Chamberlain
2020-03-30 11:55 ` [PATCH 3/3] kernel/hung_task convert hung_task_panic boot parameter to sysctl Vlastimil Babka
2020-03-30 17:43 ` Kees Cook
2020-03-31 0:34 ` John Hubbard
2020-03-31 7:27 ` Vlastimil Babka
2020-03-31 15:49 ` John Hubbard
2020-03-31 23:12 ` Tetsuo Handa
2020-04-01 8:47 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a11d5c9-b830-040e-219a-64cdb24a9236@suse.cz \
--to=vbabka@suse.cz \
--cc=adobriyan@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=gpiccoli@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.teterevkov@nutanix.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).