From: Andy Lutomirski <luto@amacapital.net>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Florian Weimer <fweimer@redhat.com>,
Linux-MM <linux-mm@kvack.org>,
Linux API <linux-api@vger.kernel.org>,
linux-x86_64@vger.kernel.org,
linux-arch <linux-arch@vger.kernel.org>, X86 ML <x86@kernel.org>,
linuxram@us.ibm.com
Subject: Re: [PATCH] pkeys: Introduce PKEY_ALLOC_SIGNALINHERIT and change signal semantics
Date: Wed, 2 May 2018 18:14:11 -0700 [thread overview]
Message-ID: <AE502DA2-5B8E-4144-937F-E39DCCC57540@amacapital.net> (raw)
In-Reply-To: <cf71c470-9712-ce7c-a84a-f78468ebb4a8@intel.com>
> On May 2, 2018, at 4:58 PM, Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 05/02/2018 04:32 PM, Andy Lutomirski wrote:
>>> But, where do those come from in this scenario? I'm not getting
>>> the secondary mechanism is that *makes* them unsafe.
>> pkey_alloc() itself. If someone tries to allocate a key with a given
>> default mode, unless there’s already a key that already had that
>> value in all threads or pkey_alloc() needs to asynchronously create
>> such a key.
>
> I think you are saying: If a thread calls pkey_alloc(), all threads
> should, by default, implicitly get access.
No, I’m saying that all threads should get the *requested* access. If I’m protecting the GOT, I want all threads to get RO access. If I’m writing a crypto library, I probably want all threads to have no access. If I’m writing a database, I probably want all threads to get RO by default. If I’m writing some doodad to sandbox some carefully constructed code, I might want all threads to have full access by default.
—Andy
next prev parent reply other threads:[~2018-05-03 1:14 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 13:26 [PATCH] pkeys: Introduce PKEY_ALLOC_SIGNALINHERIT and change signal semantics Florian Weimer
2018-05-02 14:30 ` Dave Hansen
2018-05-02 15:12 ` Florian Weimer
2018-05-02 15:28 ` Dave Hansen
2018-05-02 21:08 ` Florian Weimer
2018-05-02 22:03 ` Dave Hansen
2018-05-07 9:47 ` Florian Weimer
2018-05-02 17:09 ` Andy Lutomirski
2018-05-02 17:17 ` Florian Weimer
2018-05-02 20:41 ` Andy Lutomirski
2018-05-02 21:06 ` Florian Weimer
2018-05-02 21:23 ` Andy Lutomirski
2018-05-02 22:08 ` Dave Hansen
2018-05-02 22:22 ` Andy Lutomirski
2018-05-02 22:32 ` Dave Hansen
2018-05-02 23:32 ` Andy Lutomirski
2018-05-02 23:58 ` Dave Hansen
2018-05-03 1:14 ` Andy Lutomirski [this message]
2018-05-03 14:42 ` Dave Hansen
2018-05-03 14:42 ` Florian Weimer
2018-05-03 2:10 ` Ram Pai
2018-05-03 4:05 ` Andy Lutomirski
2018-05-07 9:48 ` Florian Weimer
2018-05-08 2:49 ` Andy Lutomirski
2018-05-08 12:40 ` Florian Weimer
2018-05-09 14:41 ` Andy Lutomirski
2018-05-14 12:01 ` Florian Weimer
2018-05-14 15:32 ` Andy Lutomirski
2018-05-14 15:34 ` Florian Weimer
2018-05-16 17:01 ` Dave Hansen
2018-05-16 20:52 ` Ram Pai
2018-05-16 20:54 ` Andy Lutomirski
2018-05-16 20:35 ` Ram Pai
2018-05-16 20:37 ` Andy Lutomirski
2018-05-16 21:07 ` Ram Pai
2018-05-17 10:09 ` Florian Weimer
2018-05-17 10:11 ` Florian Weimer
2018-05-03 14:37 ` Florian Weimer
2018-05-02 21:12 ` Ram Pai
2018-05-02 21:18 ` Andy Lutomirski
2018-05-02 23:38 ` Ram Pai
2018-05-07 9:47 ` Florian Weimer
2018-05-07 9:43 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE502DA2-5B8E-4144-937F-E39DCCC57540@amacapital.net \
--to=luto@amacapital.net \
--cc=dave.hansen@intel.com \
--cc=fweimer@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-x86_64@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=luto@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).