From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Shuah Khan <shuah@kernel.org>,
patches@kernelci.org,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
linux- stable <stable@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Christoph Lameter <cl@linux.com>, Roman Gushchin <guro@fb.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm <linux-mm@kvack.org>,
mm-commits@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Shakeel Butt <shakeelb@google.com>,
Vlastimil Babka <vbabka@suse.cz>, Arnd Bergmann <arnd@arndb.de>,
lkft-triage@lists.linaro.org,
clang-built-linux@googlegroups.com
Subject: Re: [External] Re: [PATCH 4.19 00/86] 4.19.135-rc1 review
Date: Tue, 28 Jul 2020 20:05:16 +0530 [thread overview]
Message-ID: <CA+G9fYs__nNa-090Cm8j_EPYGRfh+y+VTX3ZqR_W1Jcu2suNEQ@mail.gmail.com> (raw)
In-Reply-To: <CAMZfGtVV-u7K+Z0vFLkoKv1UOTfk=a9+r_6G4PYfGLywwnkm3Q@mail.gmail.com>
On Tue, 28 Jul 2020 at 18:33, Muchun Song <songmuchun@bytedance.com> wrote:
>
> Thanks for your test. I have reviewed the patch:
>
> [PATCH 4.19 76/86] mm: memcg/slab: fix memory leak at non-root
> kmem_cache destroy
>
> There is a backport problem and I have pointed out the problem in that email.
Thanks for your suggestions on the other email thread.
I have made changes as you said and boot test pass on x86 now.
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 9c5eb4b08fc3..65bc49f19504 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -842,9 +842,7 @@ static int shutdown_memcg_caches(struct kmem_cache *s)
static void memcg_set_kmem_cache_dying(struct kmem_cache *s)
{
- mutex_lock(&slab_mutex);
s->memcg_params.dying = true;
- mutex_unlock(&slab_mutex);
}
static void flush_memcg_workqueue(struct kmem_cache *s)
- Naresh
prev parent reply other threads:[~2020-07-28 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200727134914.312934924@linuxfoundation.org>
2020-07-28 8:34 ` [PATCH 4.19 00/86] 4.19.135-rc1 review Naresh Kamboju
2020-07-28 13:03 ` [External] " Muchun Song
2020-07-28 14:35 ` Naresh Kamboju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+G9fYs__nNa-090Cm8j_EPYGRfh+y+VTX3ZqR_W1Jcu2suNEQ@mail.gmail.com \
--to=naresh.kamboju@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ben.hutchings@codethink.co.uk \
--cc=cl@linux.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=guro@fb.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=mm-commits@vger.kernel.org \
--cc=patches@kernelci.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).