linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe'
@ 2020-11-19 22:16 kernel test robot
  2020-11-23 14:15 ` Andrey Konovalov
  0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2020-11-19 22:16 UTC (permalink / raw)
  To: Andrey Konovalov
  Cc: kbuild-all, clang-built-linux, linux-kernel, Andrew Morton,
	Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 3375 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3494d58865ad4a47611dbb427b214cc5227fa5eb
commit: cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4 kasan: allow enabling stack tagging for tag-based mode
date:   3 months ago
config: arm64-randconfig-r002-20201119 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe' [-Wframe-larger-than=]
   static int slic_ds26522_probe(struct spi_device *spi)
              ^
   1 warning generated.
--
>> drivers/gpu/drm/panel/panel-sitronix-st7789v.c:194:12: warning: stack frame size of 18352 bytes in function 'st7789v_prepare' [-Wframe-larger-than=]
   static int st7789v_prepare(struct drm_panel *panel)
              ^
   1 warning generated.

vim +/slic_ds26522_probe +205 drivers/net/wan/slic_ds26522.c

c37d4a0085c58d Zhao Qiang     2016-06-27  204  
c37d4a0085c58d Zhao Qiang     2016-06-27 @205  static int slic_ds26522_probe(struct spi_device *spi)
c37d4a0085c58d Zhao Qiang     2016-06-27  206  {
c37d4a0085c58d Zhao Qiang     2016-06-27  207  	int ret = 0;
c37d4a0085c58d Zhao Qiang     2016-06-27  208  
c37d4a0085c58d Zhao Qiang     2016-06-27  209  	g_spi = spi;
c37d4a0085c58d Zhao Qiang     2016-06-27  210  	spi->bits_per_word = 8;
c37d4a0085c58d Zhao Qiang     2016-06-27  211  
c37d4a0085c58d Zhao Qiang     2016-06-27  212  	if (!get_slic_product_code(spi))
c37d4a0085c58d Zhao Qiang     2016-06-27  213  		return ret;
c37d4a0085c58d Zhao Qiang     2016-06-27  214  
c37d4a0085c58d Zhao Qiang     2016-06-27  215  	ret = slic_ds26522_init_configure(spi);
c37d4a0085c58d Zhao Qiang     2016-06-27  216  	if (ret == 0)
60133867f1f111 Colin Ian King 2016-12-28  217  		pr_info("DS26522 cs%d configured\n", spi->chip_select);
c37d4a0085c58d Zhao Qiang     2016-06-27  218  
c37d4a0085c58d Zhao Qiang     2016-06-27  219  	return ret;
c37d4a0085c58d Zhao Qiang     2016-06-27  220  }
c37d4a0085c58d Zhao Qiang     2016-06-27  221  

:::::: The code at line 205 was first introduced by commit
:::::: c37d4a0085c58d9e45930ead6acd13ac75a8fb67 Maxim/driver: Add driver for maxim ds26522

:::::: TO: Zhao Qiang <qiang.zhao@nxp.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31275 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe'
  2020-11-19 22:16 drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe' kernel test robot
@ 2020-11-23 14:15 ` Andrey Konovalov
  2020-11-24  8:01   ` [kbuild-all] " Rong Chen
  0 siblings, 1 reply; 5+ messages in thread
From: Andrey Konovalov @ 2020-11-23 14:15 UTC (permalink / raw)
  To: kernel test robot
  Cc: kbuild-all, clang-built-linux, LKML, Andrew Morton,
	Linux Memory Management List

On Thu, Nov 19, 2020 at 11:16 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   3494d58865ad4a47611dbb427b214cc5227fa5eb
> commit: cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4 kasan: allow enabling stack tagging for tag-based mode
> date:   3 months ago
> config: arm64-randconfig-r002-20201119 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm64 cross compiling tool for clang build
>         # apt-get install binutils-aarch64-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe' [-Wframe-larger-than=]
>    static int slic_ds26522_probe(struct spi_device *spi)
>               ^
>    1 warning generated.
> --
> >> drivers/gpu/drm/panel/panel-sitronix-st7789v.c:194:12: warning: stack frame size of 18352 bytes in function 'st7789v_prepare' [-Wframe-larger-than=]
>    static int st7789v_prepare(struct drm_panel *panel)
>               ^
>    1 warning generated.

Same issue as reported previously. Copying my response from the other
email just in case:

This is the same issue in LLVM that was reported by Arnd for generic
KASAN (also see KASAN_STACK_ENABLE option description). By default
KASAN shouldn't have stack instrumentation enabled unless
KASAN_STACK_ENABLE is specified. Perhaps it makes sense to disable it
for KASAN_SW_TAGS config on the kernel test robot.

[1] https://bugs.llvm.org/show_bug.cgi?id=38809


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [kbuild-all] Re: drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe'
  2020-11-23 14:15 ` Andrey Konovalov
@ 2020-11-24  8:01   ` Rong Chen
  2020-11-24 11:51     ` Andrey Konovalov
  0 siblings, 1 reply; 5+ messages in thread
From: Rong Chen @ 2020-11-24  8:01 UTC (permalink / raw)
  To: Andrey Konovalov, kernel test robot
  Cc: kbuild-all, clang-built-linux, LKML, Andrew Morton,
	Linux Memory Management List



On 11/23/20 10:15 PM, Andrey Konovalov wrote:
> On Thu, Nov 19, 2020 at 11:16 PM kernel test robot <lkp@intel.com> wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   3494d58865ad4a47611dbb427b214cc5227fa5eb
>> commit: cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4 kasan: allow enabling stack tagging for tag-based mode
>> date:   3 months ago
>> config: arm64-randconfig-r002-20201119 (attached as .config)
>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7)
>> reproduce (this is a W=1 build):
>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          # install arm64 cross compiling tool for clang build
>>          # apt-get install binutils-aarch64-linux-gnu
>>          # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
>>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>          git fetch --no-tags linus master
>>          git checkout cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
>>          # save the attached .config to linux build tree
>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe' [-Wframe-larger-than=]
>>     static int slic_ds26522_probe(struct spi_device *spi)
>>                ^
>>     1 warning generated.
>> --
>>>> drivers/gpu/drm/panel/panel-sitronix-st7789v.c:194:12: warning: stack frame size of 18352 bytes in function 'st7789v_prepare' [-Wframe-larger-than=]
>>     static int st7789v_prepare(struct drm_panel *panel)
>>                ^
>>     1 warning generated.
> Same issue as reported previously. Copying my response from the other
> email just in case:
>
> This is the same issue in LLVM that was reported by Arnd for generic
> KASAN (also see KASAN_STACK_ENABLE option description). By default
> KASAN shouldn't have stack instrumentation enabled unless
> KASAN_STACK_ENABLE is specified. Perhaps it makes sense to disable it
> for KASAN_SW_TAGS config on the kernel test robot.
>
> [1] https://bugs.llvm.org/show_bug.cgi?id=38809

Hi Andrey,

Thanks for the explanation, we'll disable CONFIG_KASAN_SW_TAGS.

Best Regards,
Rong Chen



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [kbuild-all] Re: drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe'
  2020-11-24  8:01   ` [kbuild-all] " Rong Chen
@ 2020-11-24 11:51     ` Andrey Konovalov
  2020-11-25  0:33       ` Rong Chen
  0 siblings, 1 reply; 5+ messages in thread
From: Andrey Konovalov @ 2020-11-24 11:51 UTC (permalink / raw)
  To: Rong Chen
  Cc: kernel test robot, kbuild-all, clang-built-linux, LKML,
	Andrew Morton, Linux Memory Management List

On Tue, Nov 24, 2020 at 9:02 AM Rong Chen <rong.a.chen@intel.com> wrote:
>
> On 11/23/20 10:15 PM, Andrey Konovalov wrote:
> > On Thu, Nov 19, 2020 at 11:16 PM kernel test robot <lkp@intel.com> wrote:
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> >> head:   3494d58865ad4a47611dbb427b214cc5227fa5eb
> >> commit: cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4 kasan: allow enabling stack tagging for tag-based mode
> >> date:   3 months ago
> >> config: arm64-randconfig-r002-20201119 (attached as .config)
> >> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7)
> >> reproduce (this is a W=1 build):
> >>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >>          chmod +x ~/bin/make.cross
> >>          # install arm64 cross compiling tool for clang build
> >>          # apt-get install binutils-aarch64-linux-gnu
> >>          # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
> >>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >>          git fetch --no-tags linus master
> >>          git checkout cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
> >>          # save the attached .config to linux build tree
> >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
> >>
> >> If you fix the issue, kindly add following tag as appropriate
> >> Reported-by: kernel test robot <lkp@intel.com>
> >>
> >> All warnings (new ones prefixed by >>):
> >>
> >>>> drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe' [-Wframe-larger-than=]
> >>     static int slic_ds26522_probe(struct spi_device *spi)
> >>                ^
> >>     1 warning generated.
> >> --
> >>>> drivers/gpu/drm/panel/panel-sitronix-st7789v.c:194:12: warning: stack frame size of 18352 bytes in function 'st7789v_prepare' [-Wframe-larger-than=]
> >>     static int st7789v_prepare(struct drm_panel *panel)
> >>                ^
> >>     1 warning generated.
> > Same issue as reported previously. Copying my response from the other
> > email just in case:
> >
> > This is the same issue in LLVM that was reported by Arnd for generic
> > KASAN (also see KASAN_STACK_ENABLE option description). By default
> > KASAN shouldn't have stack instrumentation enabled unless
> > KASAN_STACK_ENABLE is specified. Perhaps it makes sense to disable it
> > for KASAN_SW_TAGS config on the kernel test robot.
> >
> > [1] https://bugs.llvm.org/show_bug.cgi?id=38809
>
> Hi Andrey,
>
> Thanks for the explanation, we'll disable CONFIG_KASAN_SW_TAGS.

Hi Rong,

No, no, if you have a CONFIG_KASAN_SW_TAGS-based config - keep it
enabled, just disable CONFIG_KASAN_STACK_ENABLE to avoid these stack
overflows.

Thanks!


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [kbuild-all] Re: drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe'
  2020-11-24 11:51     ` Andrey Konovalov
@ 2020-11-25  0:33       ` Rong Chen
  0 siblings, 0 replies; 5+ messages in thread
From: Rong Chen @ 2020-11-25  0:33 UTC (permalink / raw)
  To: Andrey Konovalov
  Cc: kernel test robot, kbuild-all, clang-built-linux, LKML,
	Andrew Morton, Linux Memory Management List



On 11/24/20 7:51 PM, Andrey Konovalov wrote:
> On Tue, Nov 24, 2020 at 9:02 AM Rong Chen <rong.a.chen@intel.com> wrote:
>> On 11/23/20 10:15 PM, Andrey Konovalov wrote:
>>> On Thu, Nov 19, 2020 at 11:16 PM kernel test robot <lkp@intel.com> wrote:
>>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>>> head:   3494d58865ad4a47611dbb427b214cc5227fa5eb
>>>> commit: cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4 kasan: allow enabling stack tagging for tag-based mode
>>>> date:   3 months ago
>>>> config: arm64-randconfig-r002-20201119 (attached as .config)
>>>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7)
>>>> reproduce (this is a W=1 build):
>>>>           wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>           chmod +x ~/bin/make.cross
>>>>           # install arm64 cross compiling tool for clang build
>>>>           # apt-get install binutils-aarch64-linux-gnu
>>>>           # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
>>>>           git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>>>           git fetch --no-tags linus master
>>>>           git checkout cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4
>>>>           # save the attached .config to linux build tree
>>>>           COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
>>>>
>>>> If you fix the issue, kindly add following tag as appropriate
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>
>>>> All warnings (new ones prefixed by >>):
>>>>
>>>>>> drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe' [-Wframe-larger-than=]
>>>>      static int slic_ds26522_probe(struct spi_device *spi)
>>>>                 ^
>>>>      1 warning generated.
>>>> --
>>>>>> drivers/gpu/drm/panel/panel-sitronix-st7789v.c:194:12: warning: stack frame size of 18352 bytes in function 'st7789v_prepare' [-Wframe-larger-than=]
>>>>      static int st7789v_prepare(struct drm_panel *panel)
>>>>                 ^
>>>>      1 warning generated.
>>> Same issue as reported previously. Copying my response from the other
>>> email just in case:
>>>
>>> This is the same issue in LLVM that was reported by Arnd for generic
>>> KASAN (also see KASAN_STACK_ENABLE option description). By default
>>> KASAN shouldn't have stack instrumentation enabled unless
>>> KASAN_STACK_ENABLE is specified. Perhaps it makes sense to disable it
>>> for KASAN_SW_TAGS config on the kernel test robot.
>>>
>>> [1] https://bugs.llvm.org/show_bug.cgi?id=38809
>> Hi Andrey,
>>
>> Thanks for the explanation, we'll disable CONFIG_KASAN_SW_TAGS.
> Hi Rong,
>
> No, no, if you have a CONFIG_KASAN_SW_TAGS-based config - keep it
> enabled, just disable CONFIG_KASAN_STACK_ENABLE to avoid these stack
> overflows.
>
> Thanks!

Ah.. my fault, will disable CONFIG_KASAN_STACK_ENABLE for this case.

Best Regards,
Rong Chen


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-25  0:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 22:16 drivers/net/wan/slic_ds26522.c:205:12: warning: stack frame size of 12288 bytes in function 'slic_ds26522_probe' kernel test robot
2020-11-23 14:15 ` Andrey Konovalov
2020-11-24  8:01   ` [kbuild-all] " Rong Chen
2020-11-24 11:51     ` Andrey Konovalov
2020-11-25  0:33       ` Rong Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).