From: Greentime Hu <green.hu@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Huang Ying <ying.huang@intel.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Nick Hu <nickhu@andestech.com>,
Vincent Chen <deanbo422@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] nds32: flush_dcache_page: use page_mapping_file to avoid races with swapoff
Date: Wed, 31 Mar 2021 15:30:51 +0800 [thread overview]
Message-ID: <CAEbi=3fXUnpJDxaWoYtDqmEHDrziR==6-6bvrobaKboBFnLyew@mail.gmail.com> (raw)
In-Reply-To: <CAEbi=3ePyQwc07krUHUtXVQ=qfWFYpyMVZdx5o=T+B9yHuc=Jg@mail.gmail.com>
Greentime Hu <green.hu@gmail.com> 於 2021年3月31日 週三 下午3:30寫道：
>
> Matthew Wilcox <willy@infradead.org> 於 2021年3月31日 週三 上午2:14寫道：
> >
> > On Tue, Mar 30, 2021 at 08:51:26PM +0300, Mike Rapoport wrote:
> > > From: Mike Rapoport <rppt@linux.ibm.com>
> > >
> > > Commit cb9f753a3731 ("mm: fix races between swapoff and flush dcache")
> > > updated flush_dcache_page implementations on several architectures to use
> > > page_mapping_file() in order to avoid races between page_mapping() and
> > > swapoff().
> > >
> > > This update missed arch/nds32 and there is a possibility of a race there.
> > >
> > > Replace page_mapping() with page_mapping_file() in nds32 implementation of
> > > flush_dcache_page().
> > >
> > > Fixes: cb9f753a3731 ("mm: fix races between swapoff and flush dcache")
> > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> >
> > Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> Acked-by: Greentiime Hu <green.hu@gmail.com>
Typo.
Acked-by: Greentime Hu <green.hu@gmail.com>
prev parent reply other threads:[~2021-03-31 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 17:51 [PATCH] nds32: flush_dcache_page: use page_mapping_file to avoid races with swapoff Mike Rapoport
2021-03-30 18:13 ` Matthew Wilcox
2021-03-31 7:30 ` Greentime Hu
2021-03-31 7:30 ` Greentime Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEbi=3fXUnpJDxaWoYtDqmEHDrziR==6-6bvrobaKboBFnLyew@mail.gmail.com' \
--to=green.hu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=deanbo422@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickhu@andestech.com \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).