From: Andreas Gruenbacher <agruenba@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Hugh Dickins <hughd@google.com>,
linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
cluster-devel@redhat.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org
Subject: Re: [Cluster-devel] return an ERR_PTR from __filemap_get_folio v3
Date: Tue, 7 Mar 2023 16:23:50 +0100 [thread overview]
Message-ID: <CAHc6FU4G5S+5S+1OdatY3apQvmDcvzOQSPPPQdQZTwMNjSq5tw@mail.gmail.com> (raw)
In-Reply-To: <20230307143410.28031-1-hch@lst.de>
On Tue, Mar 7, 2023 at 4:07 PM Christoph Hellwig <hch@lst.de> wrote:
> __filemap_get_folio and its wrappers can return NULL for three different
> conditions, which in some cases requires the caller to reverse engineer
> the decision making. This is fixed by returning an ERR_PTR instead of
> NULL and thus transporting the reason for the failure. But to make
> that work we first need to ensure that no xa_value special case is
> returned and thus return the FGP_ENTRY flag. It turns out that flag
> is barely used and can usually be deal with in a better way.
Thanks for working on this cleanup; looking good at a first glance.
Andreas
next parent reply other threads:[~2023-03-07 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230307143410.28031-1-hch@lst.de>
2023-03-07 15:23 ` Andreas Gruenbacher [this message]
[not found] ` <20230307143410.28031-5-hch@lst.de>
2023-03-20 5:19 ` [PATCH 4/7] shmem: remove shmem_get_partial_folio Hugh Dickins
2023-03-20 13:58 ` Christoph Hellwig
[not found] ` <20230307143410.28031-6-hch@lst.de>
2023-03-20 5:23 ` [PATCH 5/7] shmem: open code the page cache lookup in shmem_get_folio_gfp Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHc6FU4G5S+5S+1OdatY3apQvmDcvzOQSPPPQdQZTwMNjSq5tw@mail.gmail.com \
--to=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).