linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
	Michal Hocko <mhocko@suse.com>, Mel Gorman <mgorman@suse.de>,
	 "Kirill A . Shutemov" <kirill@shutemov.name>,
	Andrea Arcangeli <aarcange@redhat.com>,
	 Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>,
	mm-commits@vger.kernel.org
Subject: Re: [patch 01/11] mm, thp: tweak reclaim/compaction effort of local-only and all-node allocations
Date: Mon, 13 Jan 2020 18:16:52 -0800	[thread overview]
Message-ID: <CAHk-=whckmydNN7Ph1ihnA_tycQcc6XaRO2hikvYzyL8ZoMwOQ@mail.gmail.com> (raw)
In-Reply-To: <20200114002904.h9bSo%akpm@linux-foundation.org>

On Mon, Jan 13, 2020 at 4:29 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> From: Vlastimil Babka <vbabka@suse.cz>
> Subject: mm, thp: tweak reclaim/compaction effort of local-only and all-node allocations

I absolutely _detest_ how we've had this pattern of trying to change
the THP logic in a late -rc game.

Considering how unsuccessful some of the earlier attempts have been,
late -rc kernels really are *not* the time to make changes like this.

I'm going to take it this time, but

 (a) I'm going to revert *immediately* if anybody even peeps about the
new behavior

 (b) I want this to stop. Andrew - send THP "tweaks" during the merge
window, and not like some late-rc "fixes", when there are absolutely
_zero_ performance numbers or anything else critical associated with
the patch.

IOW, there is a decided lack of "bugfix" here. And if there actually
_were_ performance numbers, they should have been in the explanation.

So stop randomly messing with the THP allocation code, since it's
_known_ to be fragile with subtle side effects.

                    Linus


  reply	other threads:[~2020-01-14  2:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14  0:28 incoming Andrew Morton
2020-01-14  0:29 ` [patch 01/11] mm, thp: tweak reclaim/compaction effort of local-only and all-node allocations Andrew Morton
2020-01-14  2:16   ` Linus Torvalds [this message]
2020-01-14  8:05     ` Vlastimil Babka
2020-01-14  8:46       ` Michal Hocko
2020-01-14  0:29 ` [patch 02/11] mm/memory_hotplug: don't free usage map when removing a re-added early section Andrew Morton
2020-01-14  0:29 ` [patch 03/11] mm/huge_memory.c: thp: fix conflict of above-47bit hint address and PMD alignment Andrew Morton
2020-01-14  0:29 ` [patch 04/11] mm/shmem.c: thp, shmem: " Andrew Morton
2020-01-14  0:29 ` [patch 05/11] mm: memcg/slab: fix percpu slab vmstats flushing Andrew Morton
2020-01-14  0:29 ` [patch 06/11] mm, debug_pagealloc: don't rely on static keys too early Andrew Morton
2020-01-14  0:29 ` [patch 07/11] mm/page-writeback.c: avoid potential division by zero in wb_min_max_ratio() Andrew Morton
2020-01-14  0:29 ` [patch 08/11] mm/page-writeback.c: use div64_ul() for u64-by-unsigned-long divide Andrew Morton
2020-01-14  0:29 ` [patch 09/11] mm/page-writeback.c: improve arithmetic divisions Andrew Morton
2020-01-14  0:29 ` [patch 10/11] mm: memcg/slab: call flush_memcg_workqueue() only if memcg workqueue is valid Andrew Morton
2020-01-14  0:29 ` [patch 11/11] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=whckmydNN7Ph1ihnA_tycQcc6XaRO2hikvYzyL8ZoMwOQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill@shutemov.name \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).