From: Suren Baghdasaryan <surenb@google.com>
To: Liam Howlett <liam.howlett@oracle.com>
Cc: "Rolf Eike Beer" <eb@emlix.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Colin Cross" <ccross@google.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Michal Hocko" <mhocko@suse.com>,
"Dave Hansen" <dave.hansen@intel.com>,
"Kees Cook" <keescook@chromium.org>,
"Matthew Wilcox" <willy@infradead.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Kalesh Singh" <kaleshsingh@google.com>,
"Peter Xu" <peterx@redhat.com>,
"rppt@kernel.org" <rppt@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"vincenzo.frascino@arm.com" <vincenzo.frascino@arm.com>,
"Chinwen Chang (張錦文)" <chinwen.chang@mediatek.com>,
"Axel Rasmussen" <axelrasmussen@google.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Jann Horn" <jannh@google.com>,
"apopple@nvidia.com" <apopple@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Yu Zhao" <yuzhao@google.com>, "Will Deacon" <will@kernel.org>,
"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"Hugh Dickins" <hughd@google.com>,
"feng.tang@intel.com" <feng.tang@intel.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>, "Roman Gushchin" <guro@fb.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"krisman@collabora.com" <krisman@collabora.com>,
"Chris Hyser" <chris.hyser@oracle.com>,
"Peter Collingbourne" <pcc@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Jens Axboe" <axboe@kernel.dk>,
"legion@kernel.org" <legion@kernel.org>,
"Cyrill Gorcunov" <gorcunov@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
"Muchun Song" <songmuchun@bytedance.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Thomas Cedeno" <thomascedeno@google.com>,
"sashal@kernel.org" <sashal@kernel.org>,
"cxfcosmos@gmail.com" <cxfcosmos@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
kernel-team <kernel-team@android.com>,
"Pekka Enberg" <penberg@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Oleg Nesterov" <oleg@redhat.com>,
"Jan Glauber" <jan.glauber@gmail.com>,
"John Stultz" <john.stultz@linaro.org>,
"Rob Landley" <rob@landley.net>,
"Cyrill Gorcunov" <gorcunov@openvz.org>,
"Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
"David Rientjes" <rientjes@google.com>,
"Mel Gorman" <mgorman@suse.de>, "Shaohua Li" <shli@fusionio.com>,
"Minchan Kim" <minchan@kernel.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v10 1/3] mm: rearrange madvise code to allow for reuse
Date: Tue, 5 Oct 2021 14:30:48 -0700 [thread overview]
Message-ID: <CAJuCfpGaxhpePj8KN3S=Q7jMUjaeWZfoBTAHqjodhoH5MV-9yQ@mail.gmail.com> (raw)
In-Reply-To: <20211005210003.v3zgqhefn5j65gig@revolver>
On Tue, Oct 5, 2021 at 2:00 PM Liam Howlett <liam.howlett@oracle.com> wrote:
>
> * Suren Baghdasaryan <surenb@google.com> [211004 12:18]:
> > On Mon, Oct 4, 2021 at 12:03 AM Rolf Eike Beer <eb@emlix.com> wrote:
> > >
> > > > --- a/mm/madvise.c
> > > > +++ b/mm/madvise.c
> > > > @@ -63,76 +63,20 @@ static int madvise_need_mmap_write(int behavior)
> > > > }
> > > >
> > > > /*
> > > > - * We can potentially split a vm area into separate
> > > > - * areas, each area with its own behavior.
> > > > + * Update the vm_flags on regiion of a vma, splitting it or merging it as
> > > ^^
> >
> > Thanks! Will fix in the next version.
>
> Since you'll be respinning for this comment, can you please point out
> that the split will keep the VMA as [vma->vm_start, new_end)? That is,
> __split_vma() is passed 0 for new_below. It might prove useful since
> the code is being reused.
Hmm. There are two cases here:
if (start != vma->vm_start) {
...
error = __split_vma(mm, vma, start, 1);
}
and
if (end != vma->vm_end) {
...
error = __split_vma(mm, vma, end, 0);
}
so, I don't think such a comment would be completely correct, no?
>
> Thanks,
> Liam
>
> >
> > >
> > > Eike
> > > --
> > > Rolf Eike Beer, emlix GmbH, http://www.emlix.com
> > > Fon +49 551 30664-0, Fax +49 551 30664-11
> > > Gothaer Platz 3, 37083 Göttingen, Germany
> > > Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
> > > Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055
> > >
> > > emlix - smart embedded open source
> > >
> > > --
> > > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
> >
next prev parent reply other threads:[~2021-10-05 21:31 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 20:56 [PATCH v10 1/3] mm: rearrange madvise code to allow for reuse Suren Baghdasaryan
2021-10-01 20:56 ` [PATCH v10 2/3] mm: add a field to store names for private anonymous memory Suren Baghdasaryan
2021-10-01 23:08 ` Andrew Morton
2021-10-02 0:52 ` Suren Baghdasaryan
2021-10-04 16:21 ` Suren Baghdasaryan
2021-10-07 2:39 ` Andrew Morton
2021-10-07 2:50 ` Suren Baghdasaryan
2021-10-01 20:56 ` [PATCH v10 3/3] mm: add anonymous vma name refcounting Suren Baghdasaryan
2021-10-05 18:42 ` Pavel Machek
2021-10-05 19:14 ` Suren Baghdasaryan
2021-10-05 19:21 ` Kees Cook
2021-10-05 20:04 ` Pavel Machek
2021-10-05 20:43 ` Suren Baghdasaryan
2021-10-06 6:57 ` John Hubbard
2021-10-06 8:27 ` Michal Hocko
2021-10-06 9:27 ` David Hildenbrand
2021-10-06 15:01 ` Suren Baghdasaryan
2021-10-06 15:07 ` David Hildenbrand
2021-10-06 15:20 ` Suren Baghdasaryan
2021-10-07 2:29 ` Andrew Morton
2021-10-07 2:46 ` Suren Baghdasaryan
2021-10-07 2:53 ` Andrew Morton
2021-10-07 3:01 ` Suren Baghdasaryan
2021-10-07 7:27 ` David Hildenbrand
2021-10-07 7:33 ` David Hildenbrand
2021-10-07 15:42 ` Suren Baghdasaryan
2021-10-06 17:58 ` Pavel Machek
2021-10-06 18:18 ` Suren Baghdasaryan
2021-10-07 8:10 ` Michal Hocko
2021-10-07 8:41 ` Pavel Machek
2021-10-07 8:47 ` Rasmus Villemoes
2021-10-07 10:15 ` Pavel Machek
2021-10-07 16:04 ` Suren Baghdasaryan
2021-10-07 16:40 ` Michal Hocko
2021-10-07 16:58 ` Suren Baghdasaryan
2021-10-07 17:31 ` Michal Hocko
2021-10-07 17:50 ` Suren Baghdasaryan
2021-10-07 18:12 ` Kees Cook
2021-10-07 18:50 ` Suren Baghdasaryan
2021-10-07 19:02 ` John Hubbard
2021-10-07 21:32 ` Suren Baghdasaryan
2021-10-08 1:04 ` Liam Howlett
2021-10-08 7:25 ` Rasmus Villemoes
2021-10-08 7:43 ` David Hildenbrand
2021-10-08 21:13 ` Kees Cook
2021-10-08 6:34 ` Michal Hocko
2021-10-08 14:14 ` Dave Hansen
2021-10-08 14:57 ` Michal Hocko
2021-10-08 16:10 ` Suren Baghdasaryan
2021-10-08 20:58 ` Kees Cook
2021-10-11 8:36 ` Michal Hocko
2021-10-12 1:18 ` Suren Baghdasaryan
2021-10-12 1:20 ` Suren Baghdasaryan
2021-10-12 3:00 ` Johannes Weiner
2021-10-12 5:36 ` Suren Baghdasaryan
2021-10-12 18:26 ` Johannes Weiner
2021-10-12 18:52 ` Suren Baghdasaryan
2021-10-12 20:41 ` Johannes Weiner
2021-10-12 20:59 ` Suren Baghdasaryan
2021-10-12 7:36 ` Michal Hocko
2021-10-12 16:50 ` Suren Baghdasaryan
2021-10-12 7:43 ` David Hildenbrand
2021-10-12 17:01 ` Suren Baghdasaryan
2021-10-14 20:16 ` Suren Baghdasaryan
2021-10-15 8:03 ` David Hildenbrand
2021-10-15 16:30 ` Suren Baghdasaryan
2021-10-15 16:39 ` David Hildenbrand
2021-10-15 18:33 ` Suren Baghdasaryan
2021-10-15 17:45 ` Kees Cook
2021-10-07 7:59 ` Michal Hocko
2021-10-07 15:45 ` Suren Baghdasaryan
2021-10-07 16:37 ` Michal Hocko
2021-10-07 16:43 ` Suren Baghdasaryan
2021-10-07 17:25 ` Michal Hocko
2021-10-07 17:30 ` Suren Baghdasaryan
2021-10-04 7:03 ` [PATCH v10 1/3] mm: rearrange madvise code to allow for reuse Rolf Eike Beer
2021-10-04 16:18 ` Suren Baghdasaryan
2021-10-05 21:00 ` Liam Howlett
2021-10-05 21:30 ` Suren Baghdasaryan [this message]
2021-10-06 17:33 ` Liam Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpGaxhpePj8KN3S=Q7jMUjaeWZfoBTAHqjodhoH5MV-9yQ@mail.gmail.com' \
--to=surenb@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=axboe@kernel.dk \
--cc=axelrasmussen@google.com \
--cc=catalin.marinas@arm.com \
--cc=ccross@google.com \
--cc=chinwen.chang@mediatek.com \
--cc=chris.hyser@oracle.com \
--cc=corbet@lwn.net \
--cc=cxfcosmos@gmail.com \
--cc=dave.hansen@intel.com \
--cc=eb@emlix.com \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=fenghua.yu@intel.com \
--cc=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jan.glauber@gmail.com \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=john.stultz@linaro.org \
--cc=kaleshsingh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=krisman@collabora.com \
--cc=legion@kernel.org \
--cc=liam.howlett@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=pavel@ucw.cz \
--cc=pcc@google.com \
--cc=penberg@kernel.org \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=rob@landley.net \
--cc=rppt@kernel.org \
--cc=sashal@kernel.org \
--cc=serge.hallyn@ubuntu.com \
--cc=shli@fusionio.com \
--cc=songmuchun@bytedance.com \
--cc=sumit.semwal@linaro.org \
--cc=tglx@linutronix.de \
--cc=thomascedeno@google.com \
--cc=thunder.leizhen@huawei.com \
--cc=vbabka@suse.cz \
--cc=vincenzo.frascino@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).