From: Yafang Shao <laoar.shao@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm, memcg: clear page protection when memcg oom group happens
Date: Mon, 25 Nov 2019 19:37:59 +0800 [thread overview]
Message-ID: <CALOAHbA4PGZXaXSUE7Mwd3R_gYefkJrOFL=j83QY7q1tL60qyw@mail.gmail.com> (raw)
In-Reply-To: <20191125110848.GH31714@dhcp22.suse.cz>
On Mon, Nov 25, 2019 at 7:08 PM Michal Hocko <mhocko@kernel.org> wrote:
>
> On Mon 25-11-19 05:14:53, Yafang Shao wrote:
> > We set memory.oom.group to make all processes in this memcg are killed by
> > OOM killer to free more pages. In this case, it doesn't make sense to
> > protect the pages with memroy.{min, low} again if they are set.
>
> I do not see why? What does group OOM killing has anything to do with
> the reclaim protection? What is the actual problem you are trying to
> solve?
>
The cgroup is treated as a indivisible workload when cgroup.oom.group
is set and OOM killer is trying to kill a prcess in this cgroup.
We set cgroup.oom.group is to guarantee the workload integrity, now
that processes ara all killed, why keeps the page cache here?
Thanks
Yafang
next prev parent reply other threads:[~2019-11-25 11:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 10:14 [PATCH] mm, memcg: clear page protection when memcg oom group happens Yafang Shao
2019-11-25 11:08 ` Michal Hocko
2019-11-25 11:37 ` Yafang Shao [this message]
2019-11-25 11:54 ` Michal Hocko
2019-11-25 12:17 ` Yafang Shao
2019-11-25 12:31 ` Michal Hocko
2019-11-25 12:37 ` Yafang Shao
2019-11-25 12:45 ` Michal Hocko
2019-11-25 14:11 ` Yafang Shao
2019-11-25 14:21 ` Michal Hocko
2019-11-25 14:42 ` Johannes Weiner
2019-11-25 14:45 ` Yafang Shao
2019-11-26 3:52 ` Yafang Shao
2019-11-26 7:31 ` Michal Hocko
2019-11-26 9:35 ` Yafang Shao
2019-11-26 9:50 ` Michal Hocko
2019-11-26 10:02 ` Yafang Shao
2019-11-26 10:22 ` Michal Hocko
2019-11-26 10:56 ` Yafang Shao
2019-11-25 14:44 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbA4PGZXaXSUE7Mwd3R_gYefkJrOFL=j83QY7q1tL60qyw@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).