linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] zsmalloc: remove unless line in obj_free
@ 2015-10-13  6:31 Hui Zhu
  2015-10-13  8:00 ` Sergey Senozhatsky
  0 siblings, 1 reply; 5+ messages in thread
From: Hui Zhu @ 2015-10-13  6:31 UTC (permalink / raw)
  To: Minchan Kim, Nitin Gupta, linux-mm, linux-kernel; +Cc: teawater, Hui Zhu

Signed-off-by: Hui Zhu <zhuhui@xiaomi.com>
---
 mm/zsmalloc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index f135b1b..c7338f0 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
 	struct page *first_page, *f_page;
 	unsigned long f_objidx, f_offset;
 	void *vaddr;
-	int class_idx;
-	enum fullness_group fullness;
 
 	BUG_ON(!obj);
 
@@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
 	obj_to_location(obj, &f_page, &f_objidx);
 	first_page = get_first_page(f_page);
 
-	get_zspage_mapping(first_page, &class_idx, &fullness);
 	f_offset = obj_idx_to_offset(f_page, f_objidx, class->size);
 
 	vaddr = kmap_atomic(f_page);
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] zsmalloc: remove unless line in obj_free
  2015-10-13  6:31 [PATCH] zsmalloc: remove unless line in obj_free Hui Zhu
@ 2015-10-13  8:00 ` Sergey Senozhatsky
  2015-10-13  9:06   ` Hui Zhu
  2015-10-13  9:07   ` [PATCH v2] zsmalloc: remove useless " Hui Zhu
  0 siblings, 2 replies; 5+ messages in thread
From: Sergey Senozhatsky @ 2015-10-13  8:00 UTC (permalink / raw)
  To: Hui Zhu
  Cc: Minchan Kim, Andrew Morton, linux-mm, linux-kernel, teawater,
	Sergey Senozhatsky

On (10/13/15 14:31), Hui Zhu wrote:
> Signed-off-by: Hui Zhu <zhuhui@xiaomi.com>

s/unless/useless/

other than that

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss

> ---
>  mm/zsmalloc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index f135b1b..c7338f0 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
>  	struct page *first_page, *f_page;
>  	unsigned long f_objidx, f_offset;
>  	void *vaddr;
> -	int class_idx;
> -	enum fullness_group fullness;
>  
>  	BUG_ON(!obj);
>  
> @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
>  	obj_to_location(obj, &f_page, &f_objidx);
>  	first_page = get_first_page(f_page);
>  
> -	get_zspage_mapping(first_page, &class_idx, &fullness);
>  	f_offset = obj_idx_to_offset(f_page, f_objidx, class->size);
>  
>  	vaddr = kmap_atomic(f_page);
> -- 
> 1.9.1
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] zsmalloc: remove unless line in obj_free
  2015-10-13  8:00 ` Sergey Senozhatsky
@ 2015-10-13  9:06   ` Hui Zhu
  2015-10-13  9:07   ` [PATCH v2] zsmalloc: remove useless " Hui Zhu
  1 sibling, 0 replies; 5+ messages in thread
From: Hui Zhu @ 2015-10-13  9:06 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Hui Zhu, Minchan Kim, Andrew Morton,
	Linux Memory Management List, linux-kernel, Sergey Senozhatsky

Thanks.  I will post a new version later.

Best,
Hui

On Tue, Oct 13, 2015 at 4:00 PM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
> On (10/13/15 14:31), Hui Zhu wrote:
>> Signed-off-by: Hui Zhu <zhuhui@xiaomi.com>
>
> s/unless/useless/
>
> other than that
>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
>         -ss
>
>> ---
>>  mm/zsmalloc.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
>> index f135b1b..c7338f0 100644
>> --- a/mm/zsmalloc.c
>> +++ b/mm/zsmalloc.c
>> @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
>>       struct page *first_page, *f_page;
>>       unsigned long f_objidx, f_offset;
>>       void *vaddr;
>> -     int class_idx;
>> -     enum fullness_group fullness;
>>
>>       BUG_ON(!obj);
>>
>> @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
>>       obj_to_location(obj, &f_page, &f_objidx);
>>       first_page = get_first_page(f_page);
>>
>> -     get_zspage_mapping(first_page, &class_idx, &fullness);
>>       f_offset = obj_idx_to_offset(f_page, f_objidx, class->size);
>>
>>       vaddr = kmap_atomic(f_page);
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org.  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH v2] zsmalloc: remove useless line in obj_free
  2015-10-13  8:00 ` Sergey Senozhatsky
  2015-10-13  9:06   ` Hui Zhu
@ 2015-10-13  9:07   ` Hui Zhu
  2015-10-14  0:31     ` Sergey Senozhatsky
  1 sibling, 1 reply; 5+ messages in thread
From: Hui Zhu @ 2015-10-13  9:07 UTC (permalink / raw)
  To: Minchan Kim, Nitin Gupta, linux-mm, linux-kernel, sergey.senozhatsky
  Cc: teawater, Hui Zhu

Signed-off-by: Hui Zhu <zhuhui@xiaomi.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
 mm/zsmalloc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index f135b1b..c7338f0 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
 	struct page *first_page, *f_page;
 	unsigned long f_objidx, f_offset;
 	void *vaddr;
-	int class_idx;
-	enum fullness_group fullness;
 
 	BUG_ON(!obj);
 
@@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
 	obj_to_location(obj, &f_page, &f_objidx);
 	first_page = get_first_page(f_page);
 
-	get_zspage_mapping(first_page, &class_idx, &fullness);
 	f_offset = obj_idx_to_offset(f_page, f_objidx, class->size);
 
 	vaddr = kmap_atomic(f_page);
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] zsmalloc: remove useless line in obj_free
  2015-10-13  9:07   ` [PATCH v2] zsmalloc: remove useless " Hui Zhu
@ 2015-10-14  0:31     ` Sergey Senozhatsky
  0 siblings, 0 replies; 5+ messages in thread
From: Sergey Senozhatsky @ 2015-10-14  0:31 UTC (permalink / raw)
  To: Hui Zhu
  Cc: Andrew Morton, Minchan Kim, linux-mm, linux-kernel,
	sergey.senozhatsky, teawater

On (10/13/15 17:07), Hui Zhu wrote:
> 
> Signed-off-by: Hui Zhu <zhuhui@xiaomi.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Please Cc Andrew Morton to mm/ patches.

	-ss

> ---
>  mm/zsmalloc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index f135b1b..c7338f0 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
>  	struct page *first_page, *f_page;
>  	unsigned long f_objidx, f_offset;
>  	void *vaddr;
> -	int class_idx;
> -	enum fullness_group fullness;
>  
>  	BUG_ON(!obj);
>  
> @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
>  	obj_to_location(obj, &f_page, &f_objidx);
>  	first_page = get_first_page(f_page);
>  
> -	get_zspage_mapping(first_page, &class_idx, &fullness);
>  	f_offset = obj_idx_to_offset(f_page, f_objidx, class->size);
>  
>  	vaddr = kmap_atomic(f_page);
> -- 
> 1.9.1
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-14  0:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-13  6:31 [PATCH] zsmalloc: remove unless line in obj_free Hui Zhu
2015-10-13  8:00 ` Sergey Senozhatsky
2015-10-13  9:06   ` Hui Zhu
2015-10-13  9:07   ` [PATCH v2] zsmalloc: remove useless " Hui Zhu
2015-10-14  0:31     ` Sergey Senozhatsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).