* [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early'
@ 2021-01-10 1:02 kernel test robot
2021-01-11 19:18 ` Souptick Joarder
0 siblings, 1 reply; 7+ messages in thread
From: kernel test robot @ 2021-01-10 1:02 UTC (permalink / raw)
To: Laurent Dufour
Cc: kbuild-all, clang-built-linux, Greg Kroah-Hartman, Andrew Morton,
Linux Memory Management List, David Hildenbrand, Oscar Salvador
[-- Attachment #1: Type: text/plain, Size: 3389 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
head: 610bdbf6a174c9a91e34e276a9594114b44bef74
commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations
config: x86_64-randconfig-a001-20210110 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.19.y
git checkout b6f69f72c15d7f973f5709c5351f378f235b3654
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes]
int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg)
^
drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg)
^
static
1 warning generated.
vim +/register_mem_block_under_node_early +429 drivers/base/node.c
427
428 /* register memory section under specified node if it spans that node */
> 429 int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg)
430 {
431 int nid = *(int *)arg;
432 unsigned long pfn, sect_start_pfn, sect_end_pfn;
433
434 sect_start_pfn = section_nr_to_pfn(mem_blk->start_section_nr);
435 sect_end_pfn = section_nr_to_pfn(mem_blk->end_section_nr);
436 sect_end_pfn += PAGES_PER_SECTION - 1;
437 for (pfn = sect_start_pfn; pfn <= sect_end_pfn; pfn++) {
438 int page_nid;
439
440 /*
441 * memory block could have several absent sections from start.
442 * skip pfn range from absent section
443 */
444 if (!pfn_present(pfn)) {
445 pfn = round_down(pfn + PAGES_PER_SECTION,
446 PAGES_PER_SECTION) - 1;
447 continue;
448 }
449
450 /*
451 * We need to check if page belongs to nid only at the boot
452 * case because node's ranges can be interleaved.
453 */
454 page_nid = get_nid_for_pfn(pfn);
455 if (page_nid < 0)
456 continue;
457 if (page_nid != nid)
458 continue;
459
460 return do_register_memory_block_under_node(nid, mem_blk);
461 }
462 /* mem section does not span the specified node */
463 return 0;
464 }
465
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25319 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' 2021-01-10 1:02 [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' kernel test robot @ 2021-01-11 19:18 ` Souptick Joarder 2021-01-11 20:03 ` Greg Kroah-Hartman 0 siblings, 1 reply; 7+ messages in thread From: Souptick Joarder @ 2021-01-11 19:18 UTC (permalink / raw) To: kernel test robot Cc: Laurent Dufour, kbuild-all, clang-built-linux, Greg Kroah-Hartman, Andrew Morton, Linux Memory Management List, David Hildenbrand, Oscar Salvador On Sun, Jan 10, 2021 at 6:33 AM kernel test robot <lkp@intel.com> wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > head: 610bdbf6a174c9a91e34e276a9594114b44bef74 > commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations > config: x86_64-randconfig-a001-20210110 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654 > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > git fetch --no-tags linux-stable-rc linux-4.19.y > git checkout b6f69f72c15d7f973f5709c5351f378f235b3654 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > >> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes] > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > ^ > drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > ^ > static > 1 warning generated. It is fixed in the mainline. Will stable tree pick it from there ? > > > vim +/register_mem_block_under_node_early +429 drivers/base/node.c > > 427 > 428 /* register memory section under specified node if it spans that node */ > > 429 int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > 430 { > 431 int nid = *(int *)arg; > 432 unsigned long pfn, sect_start_pfn, sect_end_pfn; > 433 > 434 sect_start_pfn = section_nr_to_pfn(mem_blk->start_section_nr); > 435 sect_end_pfn = section_nr_to_pfn(mem_blk->end_section_nr); > 436 sect_end_pfn += PAGES_PER_SECTION - 1; > 437 for (pfn = sect_start_pfn; pfn <= sect_end_pfn; pfn++) { > 438 int page_nid; > 439 > 440 /* > 441 * memory block could have several absent sections from start. > 442 * skip pfn range from absent section > 443 */ > 444 if (!pfn_present(pfn)) { > 445 pfn = round_down(pfn + PAGES_PER_SECTION, > 446 PAGES_PER_SECTION) - 1; > 447 continue; > 448 } > 449 > 450 /* > 451 * We need to check if page belongs to nid only at the boot > 452 * case because node's ranges can be interleaved. > 453 */ > 454 page_nid = get_nid_for_pfn(pfn); > 455 if (page_nid < 0) > 456 continue; > 457 if (page_nid != nid) > 458 continue; > 459 > 460 return do_register_memory_block_under_node(nid, mem_blk); > 461 } > 462 /* mem section does not span the specified node */ > 463 return 0; > 464 } > 465 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' 2021-01-11 19:18 ` Souptick Joarder @ 2021-01-11 20:03 ` Greg Kroah-Hartman 2021-01-12 19:19 ` Souptick Joarder 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2021-01-11 20:03 UTC (permalink / raw) To: Souptick Joarder Cc: kernel test robot, Laurent Dufour, kbuild-all, clang-built-linux, Andrew Morton, Linux Memory Management List, David Hildenbrand, Oscar Salvador On Tue, Jan 12, 2021 at 12:48:22AM +0530, Souptick Joarder wrote: > On Sun, Jan 10, 2021 at 6:33 AM kernel test robot <lkp@intel.com> wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > > head: 610bdbf6a174c9a91e34e276a9594114b44bef74 > > commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations > > config: x86_64-randconfig-a001-20210110 (attached as .config) > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install x86_64 cross compiling tool for clang build > > # apt-get install binutils-x86-64-linux-gnu > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654 > > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > git fetch --no-tags linux-stable-rc linux-4.19.y > > git checkout b6f69f72c15d7f973f5709c5351f378f235b3654 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@intel.com> > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes] > > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > > ^ > > drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > > ^ > > static > > 1 warning generated. > > It is fixed in the mainline. Will stable tree pick it from there ? What is the git commit id for this? thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' 2021-01-11 20:03 ` Greg Kroah-Hartman @ 2021-01-12 19:19 ` Souptick Joarder 2021-01-12 19:30 ` Greg Kroah-Hartman 0 siblings, 1 reply; 7+ messages in thread From: Souptick Joarder @ 2021-01-12 19:19 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: kernel test robot, Laurent Dufour, kbuild-all, clang-built-linux, Andrew Morton, Linux Memory Management List, David Hildenbrand, Oscar Salvador On Tue, Jan 12, 2021 at 1:32 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Tue, Jan 12, 2021 at 12:48:22AM +0530, Souptick Joarder wrote: > > On Sun, Jan 10, 2021 at 6:33 AM kernel test robot <lkp@intel.com> wrote: > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > > > head: 610bdbf6a174c9a91e34e276a9594114b44bef74 > > > commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations > > > config: x86_64-randconfig-a001-20210110 (attached as .config) > > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # install x86_64 cross compiling tool for clang build > > > # apt-get install binutils-x86-64-linux-gnu > > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654 > > > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > > git fetch --no-tags linux-stable-rc linux-4.19.y > > > git checkout b6f69f72c15d7f973f5709c5351f378f235b3654 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot <lkp@intel.com> > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes] > > > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > > > ^ > > > drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > > > ^ > > > static > > > 1 warning generated. > > > > It is fixed in the mainline. Will stable tree pick it from there ? > > What is the git commit id for this? commit f85086f95fa3 (mm: don't rely on system state to detect hot-plug operations) which marks this function as static. > > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' 2021-01-12 19:19 ` Souptick Joarder @ 2021-01-12 19:30 ` Greg Kroah-Hartman 2021-01-12 19:31 ` Greg Kroah-Hartman 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2021-01-12 19:30 UTC (permalink / raw) To: Souptick Joarder Cc: kernel test robot, Laurent Dufour, kbuild-all, clang-built-linux, Andrew Morton, Linux Memory Management List, David Hildenbrand, Oscar Salvador On Wed, Jan 13, 2021 at 12:49:52AM +0530, Souptick Joarder wrote: > On Tue, Jan 12, 2021 at 1:32 AM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > On Tue, Jan 12, 2021 at 12:48:22AM +0530, Souptick Joarder wrote: > > > On Sun, Jan 10, 2021 at 6:33 AM kernel test robot <lkp@intel.com> wrote: > > > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > > > > head: 610bdbf6a174c9a91e34e276a9594114b44bef74 > > > > commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations > > > > config: x86_64-randconfig-a001-20210110 (attached as .config) > > > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36) > > > > reproduce (this is a W=1 build): > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > # install x86_64 cross compiling tool for clang build > > > > # apt-get install binutils-x86-64-linux-gnu > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654 > > > > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > > > git fetch --no-tags linux-stable-rc linux-4.19.y > > > > git checkout b6f69f72c15d7f973f5709c5351f378f235b3654 > > > > # save the attached .config to linux build tree > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > Reported-by: kernel test robot <lkp@intel.com> > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > >> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes] > > > > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > > > > ^ > > > > drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > > > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > > > > ^ > > > > static > > > > 1 warning generated. > > > > > > It is fixed in the mainline. Will stable tree pick it from there ? > > > > What is the git commit id for this? > > commit f85086f95fa3 (mm: don't rely on system state to detect > hot-plug operations) > which marks this function as static. Ah, that's not ok for stable trees. Don't worry about this, sparse issues for stuff like this is not a big deal for stable releases. thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' 2021-01-12 19:30 ` Greg Kroah-Hartman @ 2021-01-12 19:31 ` Greg Kroah-Hartman 2021-01-13 6:45 ` [kbuild-all] " Rong Chen 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2021-01-12 19:31 UTC (permalink / raw) To: Souptick Joarder Cc: kernel test robot, Laurent Dufour, kbuild-all, clang-built-linux, Andrew Morton, Linux Memory Management List, David Hildenbrand, Oscar Salvador On Tue, Jan 12, 2021 at 08:30:16PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 13, 2021 at 12:49:52AM +0530, Souptick Joarder wrote: > > On Tue, Jan 12, 2021 at 1:32 AM Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> wrote: > > > > > > On Tue, Jan 12, 2021 at 12:48:22AM +0530, Souptick Joarder wrote: > > > > On Sun, Jan 10, 2021 at 6:33 AM kernel test robot <lkp@intel.com> wrote: > > > > > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > > > > > head: 610bdbf6a174c9a91e34e276a9594114b44bef74 > > > > > commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations > > > > > config: x86_64-randconfig-a001-20210110 (attached as .config) > > > > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36) > > > > > reproduce (this is a W=1 build): > > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > > > chmod +x ~/bin/make.cross > > > > > # install x86_64 cross compiling tool for clang build > > > > > # apt-get install binutils-x86-64-linux-gnu > > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654 > > > > > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > > > > git fetch --no-tags linux-stable-rc linux-4.19.y > > > > > git checkout b6f69f72c15d7f973f5709c5351f378f235b3654 > > > > > # save the attached .config to linux build tree > > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > > > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > > > >> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes] > > > > > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > > > > > ^ > > > > > drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > > > > int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) > > > > > ^ > > > > > static > > > > > 1 warning generated. > > > > > > > > It is fixed in the mainline. Will stable tree pick it from there ? > > > > > > What is the git commit id for this? > > > > commit f85086f95fa3 (mm: don't rely on system state to detect > > hot-plug operations) > > which marks this function as static. > > Ah, that's not ok for stable trees. Don't worry about this, sparse > issues for stuff like this is not a big deal for stable releases. And it's already in the 4.19 tree, so I have no idea why 0-day is complaining... ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kbuild-all] Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' 2021-01-12 19:31 ` Greg Kroah-Hartman @ 2021-01-13 6:45 ` Rong Chen 0 siblings, 0 replies; 7+ messages in thread From: Rong Chen @ 2021-01-13 6:45 UTC (permalink / raw) To: Greg Kroah-Hartman, Souptick Joarder Cc: kernel test robot, Laurent Dufour, kbuild-all, clang-built-linux, Andrew Morton, Linux Memory Management List, David Hildenbrand, Oscar Salvador On 1/13/21 3:31 AM, Greg Kroah-Hartman wrote: > On Tue, Jan 12, 2021 at 08:30:16PM +0100, Greg Kroah-Hartman wrote: >> On Wed, Jan 13, 2021 at 12:49:52AM +0530, Souptick Joarder wrote: >>> On Tue, Jan 12, 2021 at 1:32 AM Greg Kroah-Hartman >>> <gregkh@linuxfoundation.org> wrote: >>>> On Tue, Jan 12, 2021 at 12:48:22AM +0530, Souptick Joarder wrote: >>>>> On Sun, Jan 10, 2021 at 6:33 AM kernel test robot <lkp@intel.com> wrote: >>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y >>>>>> head: 610bdbf6a174c9a91e34e276a9594114b44bef74 >>>>>> commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations >>>>>> config: x86_64-randconfig-a001-20210110 (attached as .config) >>>>>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36) >>>>>> reproduce (this is a W=1 build): >>>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>>>> chmod +x ~/bin/make.cross >>>>>> # install x86_64 cross compiling tool for clang build >>>>>> # apt-get install binutils-x86-64-linux-gnu >>>>>> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654 >>>>>> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git >>>>>> git fetch --no-tags linux-stable-rc linux-4.19.y >>>>>> git checkout b6f69f72c15d7f973f5709c5351f378f235b3654 >>>>>> # save the attached .config to linux build tree >>>>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 >>>>>> >>>>>> If you fix the issue, kindly add following tag as appropriate >>>>>> Reported-by: kernel test robot <lkp@intel.com> >>>>>> >>>>>> All warnings (new ones prefixed by >>): >>>>>> >>>>>>>> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes] >>>>>> int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) >>>>>> ^ >>>>>> drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >>>>>> int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) >>>>>> ^ >>>>>> static >>>>>> 1 warning generated. >>>>> It is fixed in the mainline. Will stable tree pick it from there ? >>>> What is the git commit id for this? >>> commit f85086f95fa3 (mm: don't rely on system state to detect >>> hot-plug operations) >>> which marks this function as static. >> Ah, that's not ok for stable trees. Don't worry about this, sparse >> issues for stuff like this is not a big deal for stable releases. > And it's already in the 4.19 tree, so I have no idea why 0-day is > complaining... Hi Greg, The function isn't marked as static in the 4.19 tree. # commit in mainline is "f85086f95fa3 (mm: don't rely on system state to detect hot-plug operations)" $ git show f85086f95fa3 | grep register_mem_block_under_node_early\( +static int register_mem_block_under_node_early(struct memory_block *mem_blk, # commit in linux-stable-rc/linux-4.19.y is "b6f69f72c15d (mm: don't rely on system state to detect hot-plug operations)" $ git show b6f69f72c15d | grep register_mem_block_under_node_early\( +int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) Best Regards, Rong Chen ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-13 6:46 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-01-10 1:02 [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' kernel test robot 2021-01-11 19:18 ` Souptick Joarder 2021-01-11 20:03 ` Greg Kroah-Hartman 2021-01-12 19:19 ` Souptick Joarder 2021-01-12 19:30 ` Greg Kroah-Hartman 2021-01-12 19:31 ` Greg Kroah-Hartman 2021-01-13 6:45 ` [kbuild-all] " Rong Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).