linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Jacob Wen <jian.w.wen@oracle.com>
Cc: Michal Hocko <mhocko@suse.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] mm/vmscan: DRY cleanup for do_try_to_free_pages()
Date: Sat, 19 Dec 2020 01:21:07 +0000	[thread overview]
Message-ID: <X91Vg1Mg1nPk/Bsx@chrisdown.name> (raw)
In-Reply-To: <63e8a821-a3f6-47a6-f438-b27c32f4a05f@oracle.com>

Jacob Wen writes:
>set_task_reclaim_state() is a function with 3 lines of code of which 2 
>lines contain WARN_ON_ONCE.
>
>I am not comfortable with the current repetition.

Ok, but could you please go into _why_ others should feel that way too? There 
are equally also reasons to err on the side of leaving code as-is -- since we 
know it already works, and this code generally has pretty high inertia -- and 
avoid mutation of code without concrete description of the benefits.


  reply	other threads:[~2020-12-19  1:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 10:22 [PATCH] mm/vmscan: DRY cleanup for do_try_to_free_pages() Jacob Wen
2020-12-18 10:51 ` Michal Hocko
2020-12-18 13:51   ` Jacob Wen
2020-12-18 14:27     ` Michal Hocko
2020-12-18 17:41       ` Jacob Wen
2020-12-19  1:21         ` Chris Down [this message]
2020-12-19  3:18           ` Jacob Wen
2020-12-18 12:17 ` Matthew Wilcox
2020-12-18 13:54   ` Jacob Wen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X91Vg1Mg1nPk/Bsx@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=akpm@linux-foundation.org \
    --cc=jian.w.wen@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).