linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix
@ 2021-02-23  5:51 Yafang Shao
  2021-02-23 14:49 ` Petr Mladek
  2021-03-09 10:22 ` Petr Mladek
  0 siblings, 2 replies; 3+ messages in thread
From: Yafang Shao @ 2021-02-23  5:51 UTC (permalink / raw)
  To: pmladek, willy, andriy.shevchenko, david, linmiaohe, vbabka, cl,
	penberg, rientjes, iamjoonsoo.kim, akpm, rostedt,
	sergey.senozhatsky, joe
  Cc: linux-mm, linux-kernel, Yafang Shao

The name of the flag should be printed using default_str_spec.
There's no difference in the output after this change because the string is
printed as-is with both default_dec_spec and default_flag_spec.

This patch is a followup of the patchset
"mm, vsprintf: dump full information of page flags in pGp" [1]

[1]. https://lore.kernel.org/linux-mm/20210215155141.47432-1-laoar.shao@gmail.com/
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Miaohe Lin <linmiaohe@huawei.com>
Cc: Joe Perches <joe@perches.com>
Cc: David Hildenbrand <david@redhat.com>
---
 lib/vsprintf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 533ac5404180..5d034e799c06 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1963,7 +1963,7 @@ char *format_page_flags(char *buf, char *end, unsigned long flags)
 			buf++;
 		}
 
-		buf = string(buf, end, p->name, *p->spec);
+		buf = string(buf, end, p->name, default_str_spec);
 		if (buf < end)
 			*buf = '=';
 		buf++;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix
  2021-02-23  5:51 [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix Yafang Shao
@ 2021-02-23 14:49 ` Petr Mladek
  2021-03-09 10:22 ` Petr Mladek
  1 sibling, 0 replies; 3+ messages in thread
From: Petr Mladek @ 2021-02-23 14:49 UTC (permalink / raw)
  To: Yafang Shao
  Cc: willy, andriy.shevchenko, david, linmiaohe, vbabka, cl, penberg,
	rientjes, iamjoonsoo.kim, akpm, rostedt, sergey.senozhatsky, joe,
	linux-mm, linux-kernel

On Tue 2021-02-23 13:51:24, Yafang Shao wrote:
> The name of the flag should be printed using default_str_spec.
> There's no difference in the output after this change because the string is
> printed as-is with both default_dec_spec and default_flag_spec.
> 
> This patch is a followup of the patchset
> "mm, vsprintf: dump full information of page flags in pGp" [1]
> 
> [1]. https://lore.kernel.org/linux-mm/20210215155141.47432-1-laoar.shao@gmail.com/
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> Cc: Petr Mladek <pmladek@suse.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Miaohe Lin <linmiaohe@huawei.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: David Hildenbrand <david@redhat.com>

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix
  2021-02-23  5:51 [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix Yafang Shao
  2021-02-23 14:49 ` Petr Mladek
@ 2021-03-09 10:22 ` Petr Mladek
  1 sibling, 0 replies; 3+ messages in thread
From: Petr Mladek @ 2021-03-09 10:22 UTC (permalink / raw)
  To: Yafang Shao
  Cc: willy, andriy.shevchenko, david, linmiaohe, vbabka, cl, penberg,
	rientjes, iamjoonsoo.kim, akpm, rostedt, sergey.senozhatsky, joe,
	linux-mm, linux-kernel

On Tue 2021-02-23 13:51:24, Yafang Shao wrote:
> The name of the flag should be printed using default_str_spec.
> There's no difference in the output after this change because the string is
> printed as-is with both default_dec_spec and default_flag_spec.
> 
> This patch is a followup of the patchset
> "mm, vsprintf: dump full information of page flags in pGp" [1]
> 
> [1]. https://lore.kernel.org/linux-mm/20210215155141.47432-1-laoar.shao@gmail.com/
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>

The patch is comitted in printk/linux.git,
branch for-5.13-vsprintf-pgp.

Best Regards,
Petr


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-09 10:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23  5:51 [PATCH 1/1] vsprintf: dump full information of page flags in pGp fix Yafang Shao
2021-02-23 14:49 ` Petr Mladek
2021-03-09 10:22 ` Petr Mladek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).