From: Michal Hocko <mhocko@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Paul E . McKenney" <paulmck@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
tglx@linutronix.de, john.ogness@linutronix.de, urezki@gmail.com,
ast@fb.com, Eric Dumazet <edumazet@google.com>,
Mina Almasry <almasrymina@google.com>,
peterz@infradead.org
Subject: Re: [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use
Date: Thu, 11 Mar 2021 09:20:36 +0100 [thread overview]
Message-ID: <YEnS1EcVCGuMuhMy@dhcp22.suse.cz> (raw)
In-Reply-To: <20210310214316.6d1ffb19a4219b4e70123e19@linux-foundation.org>
On Wed 10-03-21 21:43:16, Andrew Morton wrote:
> On Wed, 10 Mar 2021 18:13:21 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> > put_page does not correctly handle all calling contexts for hugetlb
> > pages. This was recently discussed in the threads [1] and [2].
> >
> > free_huge_page is the routine called for the final put_page of huegtlb
> > pages. Since at least the beginning of git history, free_huge_page has
> > acquired the hugetlb_lock to move the page to a free list and possibly
> > perform other processing. When this code was originally written, the
> > hugetlb_lock should have been made irq safe.
> >
> > For many years, nobody noticed this situation until lockdep code caught
> > free_huge_page being called from irq context. By this time, another
> > lock (hugetlb subpool) was also taken in the free_huge_page path. In
> > addition, hugetlb cgroup code had been added which could hold
> > hugetlb_lock for a considerable period of time. Because of this, commit
> > c77c0a8ac4c5 ("mm/hugetlb: defer freeing of huge pages if in non-task
> > context") was added to address the issue of free_huge_page being called
> > from irq context. That commit hands off free_huge_page processing to a
> > workqueue if !in_task.
> >
> > The !in_task check handles the case of being called from irq context.
> > However, it does not take into account the case when called with irqs
> > disabled as in [1].
> >
> > To complicate matters, functionality has been added to hugetlb
> > such that free_huge_page may block/sleep in certain situations. The
> > hugetlb_lock is of course dropped before potentially blocking.
> >
> > One way to handle all calling contexts is to have free_huge_page always
> > send pages to the workqueue for processing. This idea was briefly
> > discussed here [3], but has some undesirable side effects.
> >
> > Ideally, the hugetlb_lock should have been irq safe from the beginning
> > and any code added to the free_huge_page path should have taken this
> > into account. However, this has not happened. The code today does have
> > the ability to hand off requests to a workqueue. It does this for calls
> > from irq context. Changing the check in the code from !in_task to
> > in_atomic would handle the situations when called with irqs disabled.
> > However, it does not not handle the case when called with a spinlock
> > held. This is needed because the code could block/sleep.
> >
> > Select PREEMPT_COUNT if HUGETLB_PAGE is enabled so that in_atomic can be
> > used to detect all atomic contexts where sleeping is not possible.
> >
> > [1] https://lore.kernel.org/linux-mm/000000000000f1c03b05bc43aadc@google.com/
> > [2] https://lore.kernel.org/linux-mm/YEjji9oAwHuZaZEt@dhcp22.suse.cz/
> > [3] https://lore.kernel.org/linux-mm/YDzaAWK41K4gD35V@dhcp22.suse.cz/
> >
> > --- a/fs/Kconfig
> > +++ b/fs/Kconfig
> > @@ -235,6 +235,7 @@ config HUGETLBFS
> >
> > config HUGETLB_PAGE
> > def_bool HUGETLBFS
> > + select PREEMPT_COUNT
> >
>
> Well this is unfortunate. hugetlb is forcing PREEMPT_COUNT because we
> screwed things up.
Yes this is far from ideal but we have tried to explore other ways all
looking much more complex. [1] shows that this is a problem already and
needs a reasonable fix to be backported for older kernels.
> Did we consider changing the networking code to call a new
> free_huge_tlb_from_irq()? So the callee doesn't need to guess.
I do not think we want to pollute networking or any other code that
simply wants to put_page with a hugetlb specific knowledge.
> Or something else?
>
> Is anyone looking onto fixing this for real?
Mike said he would be looking into making hugetlb_lock irq safe but
there is a non trivial way there and this would be not a great candidate
for backporting.
Btw. RCU already wants to have a reliable in_atomic as well and that
effectivelly means enabling PREEMPT_COUNT for everybody. The overhead of
per-cpu preempt counter should pretty much invisible AFAIK.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-03-11 8:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 2:13 [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use Mike Kravetz
2021-03-11 5:43 ` Andrew Morton
2021-03-11 8:20 ` Michal Hocko [this message]
2021-03-11 8:26 ` Michal Hocko
2021-03-11 8:27 ` Michal Hocko
2021-03-11 8:46 ` Peter Zijlstra
2021-03-11 9:01 ` Michal Hocko
2021-03-11 9:32 ` Peter Zijlstra
2021-03-11 9:44 ` Michal Hocko
2021-03-11 9:52 ` Peter Zijlstra
2021-03-11 11:09 ` Michal Hocko
2021-03-11 11:36 ` Peter Zijlstra
2021-03-11 12:02 ` Michal Hocko
2021-03-11 17:25 ` Mike Kravetz
2021-03-11 12:49 ` Michal Hocko
2021-03-11 17:50 ` Paul E. McKenney
2021-03-11 9:49 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEnS1EcVCGuMuhMy@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=ast@fb.com \
--cc=edumazet@google.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).