linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
@ 2021-06-22 22:54 kernel test robot
  2021-06-23  7:59 ` Marc Zyngier
  0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-06-22 22:54 UTC (permalink / raw)
  To: Marc Zyngier; +Cc: kbuild-all, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 4351 bytes --]

Hi Stephen,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   4238b1710eadd18dd16de0288a2bc5bb84614b4e
commit: 954e285eafdd4ac36b114a7f6abce3f792591ea8 [12154/12271] Merge remote-tracking branch 'kvm-arm/next'
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=954e285eafdd4ac36b114a7f6abce3f792591ea8
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 954e285eafdd4ac36b114a7f6abce3f792591ea8
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   x86_64/hyperv_features.c: In function 'main':
>> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration]
     618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
         |  ^~~~~~~~~~~~~~~~~~~
   /usr/bin/ld: /tmp/ccIBsVo3.o: in function `main':
>> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
   collect2: error: ld returned 1 exit status
--
   x86_64/hyperv_features.c: In function 'main':
>> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration]
     618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
         |  ^~~~~~~~~~~~~~~~~~~
   /usr/bin/ld: /tmp/cc7zqGvp.o: in function `main':
>> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
   collect2: error: ld returned 1 exit status


vim +618 tools/testing/selftests/kvm/x86_64/hyperv_features.c

e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  593  
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  594  int main(void)
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  595  {
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  596  	struct kvm_cpuid2 *best;
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  597  	struct kvm_vm *vm;
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  598  	vm_vaddr_t msr_gva, hcall_page, hcall_params;
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  599  	struct kvm_enable_cap cap = {
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  600  		.cap = KVM_CAP_HYPERV_ENFORCE_CPUID,
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  601  		.args = {1}
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  602  	};
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  603  
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  604  	/* Test MSRs */
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  605  	vm = vm_create_default(VCPU_ID, 0, guest_msr);
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  606  
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  607  	msr_gva = vm_vaddr_alloc(vm, getpagesize(), 0x10000, 0, 0);
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  608  	memset(addr_gva2hva(vm, msr_gva), 0x0, getpagesize());
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  609  	vcpu_args_set(vm, VCPU_ID, 1, msr_gva);
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  610  	vcpu_enable_cap(vm, VCPU_ID, &cap);
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  611  
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  612  	vcpu_set_hv_cpuid(vm, VCPU_ID);
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  613  
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  614  	best = kvm_get_supported_hv_cpuid();
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  615  
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  616  	vm_init_descriptor_tables(vm);
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21  617  	vcpu_init_descriptor_tables(vm, VCPU_ID);
e2e1cc1fbe54a9 Vitaly Kuznetsov 2021-05-21 @618  	vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);

:::::: The code at line 618 was first introduced by commit
:::::: e2e1cc1fbe54a9520956a4539a3676d2ebf122dd KVM: selftests: Introduce hyperv_features test

:::::: TO: Vitaly Kuznetsov <vkuznets@redhat.com>
:::::: CC: Paolo Bonzini <pbonzini@redhat.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42038 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
  2021-06-22 22:54 [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' kernel test robot
@ 2021-06-23  7:59 ` Marc Zyngier
  2021-06-23  8:39   ` Paolo Bonzini
  2021-06-24  1:01   ` Ricardo Koller
  0 siblings, 2 replies; 4+ messages in thread
From: Marc Zyngier @ 2021-06-23  7:59 UTC (permalink / raw)
  To: kernel test robot, Paolo Bonzini, Vitaly Kuznetsov, Ricardo Koller
  Cc: kbuild-all, Linux Memory Management List

+ Paolo, Vitaly, Ricardo,

On Tue, 22 Jun 2021 23:54:17 +0100,
kernel test robot <lkp@intel.com> wrote:
> 
> Hi Stephen,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   4238b1710eadd18dd16de0288a2bc5bb84614b4e
> commit: 954e285eafdd4ac36b114a7f6abce3f792591ea8 [12154/12271] Merge remote-tracking branch 'kvm-arm/next'
> config: x86_64-rhel-8.3-kselftests (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=954e285eafdd4ac36b114a7f6abce3f792591ea8
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 954e285eafdd4ac36b114a7f6abce3f792591ea8
>         # save the attached .config to linux build tree
>         make W=1 ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    x86_64/hyperv_features.c: In function 'main':
> >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration]
>      618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
>          |  ^~~~~~~~~~~~~~~~~~~
>    /usr/bin/ld: /tmp/ccIBsVo3.o: in function `main':
> >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
>    collect2: error: ld returned 1 exit status
> --
>    x86_64/hyperv_features.c: In function 'main':
> >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration]
>      618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
>          |  ^~~~~~~~~~~~~~~~~~~
>    /usr/bin/ld: /tmp/cc7zqGvp.o: in function `main':
> >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
>    collect2: error: ld returned 1 exit status
>

This stems from the following commit:

commit b78f4a596692f6805e796a4c13f2d921b8a95166
Author: Ricardo Koller <ricarkol@google.com>
Date:   Thu Jun 10 18:10:15 2021 -0700

    KVM: selftests: Rename vm_handle_exception
    
    Rename the vm_handle_exception function to a name that indicates more
    clearly that it installs something: vm_install_exception_handler.
    
    Reported-by: kernel test robot <oliver.sang@intel.com>
    Suggested-by: Marc Zyngier <maz@kernel.org>
    Suggested-by: Andrew Jones <drjones@redhat.com>
    Signed-off-by: Ricardo Koller <ricarkol@google.com>
    Reviewed-by: Andrew Jones <drjones@redhat.com>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20210611011020.3420067-2-ricarkol@google.com

If there is a stable branch with this patch on it, I can take it in
the kvmarm tree and fix it up myself. Otherwise, Paolo could take the
stable branch at [1] (or even that particular commit which is right on
top of v5.13-rc4) and do a similar fixup. Just let me know.

Thanks,

	M.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/selftest/debug

-- 
Without deviation from the norm, progress is not possible.


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
  2021-06-23  7:59 ` Marc Zyngier
@ 2021-06-23  8:39   ` Paolo Bonzini
  2021-06-24  1:01   ` Ricardo Koller
  1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2021-06-23  8:39 UTC (permalink / raw)
  To: Marc Zyngier, kernel test robot, Vitaly Kuznetsov, Ricardo Koller
  Cc: kbuild-all, Linux Memory Management List

On 23/06/21 09:59, Marc Zyngier wrote:
> If there is a stable branch with this patch on it, I can take it in
> the kvmarm tree and fix it up myself. Otherwise, Paolo could take the
> stable branch at [1] (or even that particular commit which is right on
> top of v5.13-rc4) and do a similar fixup. Just let me know.

There's no super hurry, I can fix the semantic conflict when you send me 
the kvmarm pull request (which should be a matter of days anyway).

Paolo



^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
  2021-06-23  7:59 ` Marc Zyngier
  2021-06-23  8:39   ` Paolo Bonzini
@ 2021-06-24  1:01   ` Ricardo Koller
  1 sibling, 0 replies; 4+ messages in thread
From: Ricardo Koller @ 2021-06-24  1:01 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: kernel test robot, Paolo Bonzini, Vitaly Kuznetsov, kbuild-all,
	Linux Memory Management List

On Wed, Jun 23, 2021 at 08:59:59AM +0100, Marc Zyngier wrote:
> + Paolo, Vitaly, Ricardo,
> 
> On Tue, 22 Jun 2021 23:54:17 +0100,
> kernel test robot <lkp@intel.com> wrote:
> > 
> > Hi Stephen,
> > 
> > First bad commit (maybe != root cause):
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   4238b1710eadd18dd16de0288a2bc5bb84614b4e
> > commit: 954e285eafdd4ac36b114a7f6abce3f792591ea8 [12154/12271] Merge remote-tracking branch 'kvm-arm/next'
> > config: x86_64-rhel-8.3-kselftests (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> > reproduce (this is a W=1 build):
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=954e285eafdd4ac36b114a7f6abce3f792591ea8
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout 954e285eafdd4ac36b114a7f6abce3f792591ea8
> >         # save the attached .config to linux build tree
> >         make W=1 ARCH=x86_64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All error/warnings (new ones prefixed by >>):
> > 
> >    x86_64/hyperv_features.c: In function 'main':
> > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration]
> >      618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
> >          |  ^~~~~~~~~~~~~~~~~~~
> >    /usr/bin/ld: /tmp/ccIBsVo3.o: in function `main':
> > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
> >    collect2: error: ld returned 1 exit status
> > --
> >    x86_64/hyperv_features.c: In function 'main':
> > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration]
> >      618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
> >          |  ^~~~~~~~~~~~~~~~~~~
> >    /usr/bin/ld: /tmp/cc7zqGvp.o: in function `main':
> > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
> >    collect2: error: ld returned 1 exit status
> >
> 
> This stems from the following commit:
> 
> commit b78f4a596692f6805e796a4c13f2d921b8a95166
> Author: Ricardo Koller <ricarkol@google.com>
> Date:   Thu Jun 10 18:10:15 2021 -0700
> 
>     KVM: selftests: Rename vm_handle_exception
>     
>     Rename the vm_handle_exception function to a name that indicates more
>     clearly that it installs something: vm_install_exception_handler.
>     
>     Reported-by: kernel test robot <oliver.sang@intel.com>
>     Suggested-by: Marc Zyngier <maz@kernel.org>
>     Suggested-by: Andrew Jones <drjones@redhat.com>
>     Signed-off-by: Ricardo Koller <ricarkol@google.com>
>     Reviewed-by: Andrew Jones <drjones@redhat.com>
>     Signed-off-by: Marc Zyngier <maz@kernel.org>
>     Link: https://lore.kernel.org/r/20210611011020.3420067-2-ricarkol@google.com

Yes, that's my change (again). Thanks you both for handling it.

Thanks,
Ricardo

> 
> If there is a stable branch with this patch on it, I can take it in
> the kvmarm tree and fix it up myself. Otherwise, Paolo could take the
> stable branch at [1] (or even that particular commit which is right on
> top of v5.13-rc4) and do a similar fixup. Just let me know.
> 
> Thanks,
> 
> 	M.
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/selftest/debug
> 
> -- 
> Without deviation from the norm, progress is not possible.


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-24  1:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 22:54 [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' kernel test robot
2021-06-23  7:59 ` Marc Zyngier
2021-06-23  8:39   ` Paolo Bonzini
2021-06-24  1:01   ` Ricardo Koller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).