[PATCH] hugetlbfs: fix mount mode command line processing

[PATCH] hugetlbfs: fix mount mode command line processing

[Mike Kravetz]

In commit 32021982a324 ("hugetlbfs: Convert to fs_context") processing
of the mount mode string was changed from match_octal() to fsparam_u32.
This changed existing behavior as match_octal does not require octal
values to have a '0' prefix, but fsparam_u32 does.

Use fsparam_u32oct which provides the same behavior as match_octal.

Reported-by: Dennis Camera <bugs+kernel.org@dtnr.ch>
Fixes: 32021982a324 ("hugetlbfs: Convert to fs_context")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
CC: <stable@vger.kernel.org>
---
 fs/hugetlbfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 926eeb9bf4eb..cdfb1ae78a3f 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -77,7 +77,7 @@ enum hugetlb_param {
 static const struct fs_parameter_spec hugetlb_fs_parameters[] = {
 	fsparam_u32   ("gid",		Opt_gid),
 	fsparam_string("min_size",	Opt_min_size),
-	fsparam_u32   ("mode",		Opt_mode),
+	fsparam_u32oct("mode",		Opt_mode),
 	fsparam_string("nr_inodes",	Opt_nr_inodes),
 	fsparam_string("pagesize",	Opt_pagesize),
 	fsparam_string("size",		Opt_size),
-- 
2.31.1

Re: [PATCH] hugetlbfs: fix mount mode command line processing

[Matthew Wilcox]

On Wed, Jul 21, 2021 at 11:33:26AM -0700, Mike Kravetz wrote:
> In commit 32021982a324 ("hugetlbfs: Convert to fs_context") processing
> of the mount mode string was changed from match_octal() to fsparam_u32.
> This changed existing behavior as match_octal does not require octal
> values to have a '0' prefix, but fsparam_u32 does.
> 
> Use fsparam_u32oct which provides the same behavior as match_octal.
> 
> Reported-by: Dennis Camera <bugs+kernel.org@dtnr.ch>
> Fixes: 32021982a324 ("hugetlbfs: Convert to fs_context")
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> CC: <stable@vger.kernel.org>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>