From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-mm@kvack.org, Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH nf-next] netfilter: core: Fix clang warnings about unused static inlines
Date: Sun, 17 Oct 2021 15:48:16 +0200 [thread overview]
Message-ID: <YWwpoI7DmT31GRW+@salvia> (raw)
In-Reply-To: <7bc9f3ee15533d170bc412d6bcdd122632af169d.1634370995.git.lukas@wunner.de>
On Sat, Oct 16, 2021 at 10:13:27AM +0200, Lukas Wunner wrote:
> Unlike gcc, clang warns about unused static inlines that are not in an
> include file:
>
> net/netfilter/core.c:344:20: error: unused function 'nf_ingress_hook' [-Werror,-Wunused-function]
> static inline bool nf_ingress_hook(const struct nf_hook_ops *reg, int pf)
> ^
> net/netfilter/core.c:353:20: error: unused function 'nf_egress_hook' [-Werror,-Wunused-function]
> static inline bool nf_egress_hook(const struct nf_hook_ops *reg, int pf)
> ^
>
> According to commit 6863f5643dd7 ("kbuild: allow Clang to find unused
> static inline functions for W=1 build"), the proper resolution is to
> mark the affected functions as __maybe_unused. An alternative approach
> would be to move them to include/linux/netfilter_netdev.h, but since
> Pablo didn't do that in commit ddcfa710d40b ("netfilter: add
> nf_ingress_hook() helper function"), I'm guessing __maybe_unused is
> preferred.
>
> This fixes both the warning introduced by Pablo in v5.10 as well as the
> one recently introduced by myself with commit 42df6e1d221d ("netfilter:
> Introduce egress hook").
Applied, thanks.
prev parent reply other threads:[~2021-10-17 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 22:12 [linux-next:master 7868/8410] net/netfilter/core.c:353:20: error: unused function 'nf_egress_hook' kernel test robot
2021-10-16 8:13 ` [PATCH nf-next] netfilter: core: Fix clang warnings about unused static inlines Lukas Wunner
2021-10-17 13:48 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWwpoI7DmT31GRW+@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=lukas@wunner.de \
--cc=natechancellor@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).