* [PATCH] mm/vmalloc: fix comments about vmap_area struct
@ 2022-03-05 1:15 Bang Li
2022-03-07 15:47 ` Uladzislau Rezki
0 siblings, 1 reply; 2+ messages in thread
From: Bang Li @ 2022-03-05 1:15 UTC (permalink / raw)
To: akpm; +Cc: urezki, lpf.vector, linux-mm, linux-kernel, libang.linuxer
the vmap_area_root should be in the "busy" tree and the free_vmap_area_root
should be in the "free" tree.
Fixes: 688fcbfc06e4 ("mm/vmalloc: modify struct vmap_area to reduce its size")
Signed-off-by: Bang Li <libang.linuxer@gmail.com>
---
include/linux/vmalloc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h
index 880227b9f044..05065915edd7 100644
--- a/include/linux/vmalloc.h
+++ b/include/linux/vmalloc.h
@@ -80,8 +80,8 @@ struct vmap_area {
/*
* The following two variables can be packed, because
* a vmap_area object can be either:
- * 1) in "free" tree (root is vmap_area_root)
- * 2) or "busy" tree (root is free_vmap_area_root)
+ * 1) in "free" tree (root is free_vmap_area_root)
+ * 2) or "busy" tree (root is vmap_area_root)
*/
union {
unsigned long subtree_max_size; /* in "free" tree */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/vmalloc: fix comments about vmap_area struct
2022-03-05 1:15 [PATCH] mm/vmalloc: fix comments about vmap_area struct Bang Li
@ 2022-03-07 15:47 ` Uladzislau Rezki
0 siblings, 0 replies; 2+ messages in thread
From: Uladzislau Rezki @ 2022-03-07 15:47 UTC (permalink / raw)
To: Bang Li; +Cc: akpm, urezki, lpf.vector, linux-mm, linux-kernel
On Sat, Mar 05, 2022 at 09:15:10AM +0800, Bang Li wrote:
> the vmap_area_root should be in the "busy" tree and the free_vmap_area_root
> should be in the "free" tree.
>
> Fixes: 688fcbfc06e4 ("mm/vmalloc: modify struct vmap_area to reduce its size")
> Signed-off-by: Bang Li <libang.linuxer@gmail.com>
> ---
> include/linux/vmalloc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h
> index 880227b9f044..05065915edd7 100644
> --- a/include/linux/vmalloc.h
> +++ b/include/linux/vmalloc.h
> @@ -80,8 +80,8 @@ struct vmap_area {
> /*
> * The following two variables can be packed, because
> * a vmap_area object can be either:
> - * 1) in "free" tree (root is vmap_area_root)
> - * 2) or "busy" tree (root is free_vmap_area_root)
> + * 1) in "free" tree (root is free_vmap_area_root)
> + * 2) or "busy" tree (root is vmap_area_root)
> */
> union {
> unsigned long subtree_max_size; /* in "free" tree */
> --
> 2.25.1
>
Agree, those comments were messed up.
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
--
Vlad Rezki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-07 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-05 1:15 [PATCH] mm/vmalloc: fix comments about vmap_area struct Bang Li
2022-03-07 15:47 ` Uladzislau Rezki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).