From: Christoph Hellwig <hch@infradead.org>
To: Song Liu <song@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kernel-team@fb.com, akpm@linux-foundation.org,
rick.p.edgecombe@intel.com, hch@infradead.org,
imbrenda@linux.ibm.com
Subject: Re: [PATCH bpf 2/2] bpf: use vmalloc with VM_ALLOW_HUGE_VMAP for bpf_prog_pack
Date: Fri, 8 Apr 2022 22:29:59 -0700 [thread overview]
Message-ID: <YlEZ1+amMITl7TaR@infradead.org> (raw)
In-Reply-To: <20220408223443.3303509-3-song@kernel.org>
On Fri, Apr 08, 2022 at 03:34:43PM -0700, Song Liu wrote:
> +static void *bpf_prog_pack_vmalloc(unsigned long size)
> +{
> +#if defined(MODULES_VADDR)
> + unsigned long start = MODULES_VADDR;
> + unsigned long end = MODULES_END;
> +#else
> + unsigned long start = VMALLOC_START;
> + unsigned long end = VMALLOC_END;
> +#endif
> +
> + return __vmalloc_node_range(size, PAGE_SIZE, start, end, GFP_KERNEL, PAGE_KERNEL,
> + VM_DEFER_KMEMLEAK | VM_ALLOW_HUGE_VMAP,
> + NUMA_NO_NODE, __builtin_return_address(0));
> +}
Instead of having this magic in bpf I think a module_alloc_large would
seems like the better interface here.
next prev parent reply other threads:[~2022-04-09 5:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 22:34 [PATCH bpf 0/2] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP Song Liu
2022-04-08 22:34 ` [PATCH bpf 1/2] vmalloc: replace VM_NO_HUGE_VMAP with VM_ALLOW_HUGE_VMAP Song Liu
2022-04-09 5:28 ` Christoph Hellwig
2022-04-10 1:25 ` Song Liu
2022-04-08 22:34 ` [PATCH bpf 2/2] bpf: use vmalloc with VM_ALLOW_HUGE_VMAP for bpf_prog_pack Song Liu
2022-04-09 5:29 ` Christoph Hellwig [this message]
2022-04-10 1:34 ` Song Liu
2022-04-11 6:56 ` Christoph Hellwig
2022-04-11 22:18 ` Song Liu
2022-04-09 11:43 ` [PATCH bpf 0/2] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP Thorsten Leemhuis
2022-04-10 1:36 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlEZ1+amMITl7TaR@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=imbrenda@linux.ibm.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).